From: David Marchand <david.marchand@redhat.com>
To: Jerin Jacob <jerinjacobk@gmail.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH 2/2] lib: make graph optional
Date: Tue, 20 Jun 2023 09:09:43 +0200 [thread overview]
Message-ID: <CAJFAV8yzXR0oO2dwGek4edGvNuHn1Ka00QYAysbCMQmDjwOwmQ@mail.gmail.com> (raw)
In-Reply-To: <CALBAE1M5Ku_XB4JaHcbfvwaEqKKYUY0LhQW8f-dfXDonGJRYNA@mail.gmail.com>
On Tue, Jun 20, 2023 at 8:56 AM Jerin Jacob <jerinjacobk@gmail.com> wrote:
>
> On Tue, Jun 20, 2023 at 2:17 AM David Marchand
> <david.marchand@redhat.com> wrote:
> >
> > Allow disabling of the graph library in builds.
>
> Good to make graph as optional.
> I did not check the build, will examples/l3fwd-graph/ skip automatically ?
Yes.
Each example exposes its required dependencies.
examples/meson.build will skip any example with unmet requirements
unless the example was explicitly set in the -Dexamples= list of
examples to build.
See:
https://git.dpdk.org/dpdk/tree/examples/meson.build#n105
https://git.dpdk.org/dpdk/tree/examples/meson.build#n79
https://git.dpdk.org/dpdk/tree/examples/meson.build#n117
>
> >
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
> > ---
> > +if dpdk_conf.has('RTE_LIB_GRAPH')
>
> Can devtools/test-meson-builds.sh updated to check build with
> disabling all optional libs?
I already tested this series with our script: we already have a "mini" target.
build build-mini cc skipABI $use_shared -Ddisable_libs=* \
-Denable_drivers=net/null
...
Message: Skipping example "l2fwd-jobstats"
Library rt found: YES
Message: Missing dependency "graph" for example "l3fwd-graph"
Message: Skipping example "l3fwd-graph"
Message: Missing dependency "power" for example "l3fwd-power"
Message: Skipping example "l3fwd-power"
...
--
David Marchand
next prev parent reply other threads:[~2023-06-20 7:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-19 20:46 [PATCH 1/2] test: add graph tests David Marchand
2023-06-19 20:46 ` [PATCH 2/2] lib: make graph optional David Marchand
2023-06-20 6:56 ` Jerin Jacob
2023-06-20 7:09 ` David Marchand [this message]
2023-06-20 8:10 ` Bruce Richardson
2023-06-20 8:20 ` Jerin Jacob
2023-06-22 17:33 ` Thomas Monjalon
2023-06-20 6:45 ` [PATCH 1/2] test: add graph tests David Marchand
2023-06-20 6:50 ` Jerin Jacob
2023-06-20 6:56 ` David Marchand
2023-06-20 10:32 ` Kevin Traynor
2023-06-20 11:52 ` David Marchand
2023-06-20 13:06 ` Kevin Traynor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8yzXR0oO2dwGek4edGvNuHn1Ka00QYAysbCMQmDjwOwmQ@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=jerinjacobk@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).