DPDK patches and discussions
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: Sachin Saxena <sachin.saxena@nxp.com>
Cc: "Babu Radhakrishnan,
	AgalyaX" <agalyax.babu.radhakrishnan@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	"Pattan, Reshma" <reshma.pattan@intel.com>,
	Hemant Agrawal <hemant.agrawal@nxp.com>,
	 "Parthasarathy, JananeeX M" <jananeex.m.parthasarathy@intel.com>,
	"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] bus/fslmc: fix for resource leak coverity issue
Date: Thu, 24 Oct 2019 21:17:18 +0200	[thread overview]
Message-ID: <CAJFAV8z3GoBpN8nPzVY+b5k+f6GA8f8pFjC6_wio+6CUr7ax5Q@mail.gmail.com> (raw)
In-Reply-To: <VI1PR04MB4845D9DDE06BE8F46925B752E39F0@VI1PR04MB4845.eurprd04.prod.outlook.com>

On Thu, Oct 3, 2019 at 10:43 AM Sachin Saxena <sachin.saxena@nxp.com> wrote:
>
>
> > -----Original Message-----
> > From: Babu Radhakrishnan, AgalyaX
> > <agalyax.babu.radhakrishnan@intel.com>
> > Sent: Tuesday, September 10, 2019 1:11 PM
> > To: dev@dpdk.org
> > Cc: Pattan, Reshma <reshma.pattan@intel.com>; Hemant Agrawal
> > <hemant.agrawal@nxp.com>; Sachin Saxena <sachin.saxena@nxp.com>;
> > Parthasarathy, JananeeX M <jananeex.m.parthasarathy@intel.com>;
> > stable@dpdk.org
> > Subject: RE: [PATCH] bus/fslmc: fix for resource leak coverity issue
> > Importance: High
> >
> > Hi,
> >
> > > -----Original Message-----
> > > From: Babu Radhakrishnan, AgalyaX
> > > Sent: Tuesday, September 10, 2019 1:01 PM
> > > To: dev@dpdk.org
> > > Cc: Pattan, Reshma <reshma.pattan@intel.com>;
> > hemant.agrawal@nxp.com;
> > > sachin.saxena@nxp.com; Parthasarathy, JananeeX M
> > > <jananeex.m.parthasarathy@intel.com>; Babu Radhakrishnan, AgalyaX
> > > <agalyax.babu.radhakrishnan@intel.com>; stable@dpdk.org
> > > Subject: [PATCH] bus/fslmc: fix for resource leak coverity issue
> > >
> > > From: Agalya Babu RadhaKrishnan
> > <agalyax.babu.radhakrishnan@intel.com>
> > >
> > > 1 issue caught by 344967
> > > Leaked_storage: Variable sep going out of scope leaks the storage it
> > > points to.
> > >
> > > When 'sep' is not null and sep_exist is 0, 'sep' is freed before going
> > > out of scope of the function irrespective of 'addr' exists or not.
> > >
> > > Coverity Issue: 344967
> > > Fixes: e67a61614d0b ("bus/fslmc: support device iteration")
> > > Cc: stable@dpdk.org
> > >
> > > Signed-off-by: Agalya Babu RadhaKrishnan
> > > <agalyax.babu.radhakrishnan@intel.com>
> > > ---
> >
> > if (strncmp("dpni", sep, 4) &&
> >             strncmp("dpseci", sep, 6) &&
> >             strncmp("dpcon", sep, 5) &
> >             .....
> >
> > We think validation of device name is done using AND operator instead it
> > should be done by OR operator.
> > Please confirm
> [Sachin Saxena] The purpose of this logic to confirm that one of the device name should match to supported list and as soon as one strncmp() matches the string it will return 0 and the control comes out of IF condition.
> So, existing logic is correct.
>

Should I understand this as a confirmation of the initial ACK?


-- 
David Marchand


  reply	other threads:[~2019-10-24 19:17 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-10  7:30 Agalya Babu RadhaKrishnan
2019-09-10  7:41 ` Babu Radhakrishnan, AgalyaX
2019-10-03  8:43   ` Sachin Saxena
2019-10-24 19:17     ` David Marchand [this message]
2019-10-31 11:16       ` Sachin Saxena
2019-10-03  8:40 ` Sachin Saxena
2019-10-31 16:18 ` David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJFAV8z3GoBpN8nPzVY+b5k+f6GA8f8pFjC6_wio+6CUr7ax5Q@mail.gmail.com \
    --to=david.marchand@redhat.com \
    --cc=agalyax.babu.radhakrishnan@intel.com \
    --cc=dev@dpdk.org \
    --cc=hemant.agrawal@nxp.com \
    --cc=jananeex.m.parthasarathy@intel.com \
    --cc=reshma.pattan@intel.com \
    --cc=sachin.saxena@nxp.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).