From: David Marchand <david.marchand@redhat.com>
To: Tyler Retzlaff <roretzla@linux.microsoft.com>
Cc: dev <dev@dpdk.org>, Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Subject: Re: [PATCH] eal/windows: set Windows main lcore affinitization
Date: Thu, 14 Apr 2022 11:50:55 +0200 [thread overview]
Message-ID: <CAJFAV8zDbxVLwuMLxU-0ZMM5UAskGaiJAaCTnrT-FUk2d7S8Og@mail.gmail.com> (raw)
In-Reply-To: <20220412163013.GA25114@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
Hello Tyler,
On Tue, Apr 12, 2022 at 6:30 PM Tyler Retzlaff
<roretzla@linux.microsoft.com> wrote:
> > - Which makes me notice that windows/eal_thread.c probably dumps
> > random stuff in logs because it is missing a call to
> > eal_thread_dump_current_affinity() to format affinity as a string.
>
> oh yeah, that's not so good.
>
> i think the series you submitted for eal_thread_loop should resolve this
> shouldn't it? shall we ride your change to fix the issue or do you feel
> it's worth me adding the missing call in this series?
This issue here is only for a log on cpu affinity.
Lcores cpu affinity is not correct for Windows in LTS releases, in any case.
So let's keep it as is and don't bother fixing it.
I'll add a note in my series about this log and apply it.
I marked this current patch as "Changes requested", wrt to my first comment.
--
David Marchand
next prev parent reply other threads:[~2022-04-14 9:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-30 9:00 Tyler Retzlaff
2022-04-07 13:14 ` David Marchand
2022-04-12 16:30 ` Tyler Retzlaff
2022-04-14 9:50 ` David Marchand [this message]
2022-04-14 12:40 ` [PATCH v2] " Tyler Retzlaff
2022-04-14 12:43 ` [PATCH v3] " Tyler Retzlaff
2022-04-14 13:08 ` David Marchand
2022-04-25 8:28 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8zDbxVLwuMLxU-0ZMM5UAskGaiJAaCTnrT-FUk2d7S8Og@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=roretzla@linux.microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).