DPDK patches and discussions
 help / color / Atom feed
* [dpdk-dev] [PATCH 1/2] pipeline: fix jump instruction population
@ 2020-10-16 13:57 Cristian Dumitrescu
  2020-10-16 14:12 ` P, Venkata Suresh Kumar
  2020-10-19  7:09 ` David Marchand
  0 siblings, 2 replies; 5+ messages in thread
From: Cristian Dumitrescu @ 2020-10-16 13:57 UTC (permalink / raw)
  To: dev; +Cc: venkata.suresh.kumar.p, cristian.dumitrescu

From: Venkata Suresh Kumar P <venkata.suresh.kumar.p@intel.com>

This patch fixes jump next instruction pointer
population

Fixes: b3947e25bed4 ("pipeline: introduce SWX jump and return instructions")
Cc: cristian.dumitrescu@intel.com

Signed-off-by: Venkata Suresh Kumar P <venkata.suresh.kumar.p@intel.com>
Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
---
 lib/librte_pipeline/rte_swx_pipeline.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/librte_pipeline/rte_swx_pipeline.c b/lib/librte_pipeline/rte_swx_pipeline.c
index d5b4a1c..2c9fbf4 100644
--- a/lib/librte_pipeline/rte_swx_pipeline.c
+++ b/lib/librte_pipeline/rte_swx_pipeline.c
@@ -5647,7 +5647,7 @@ struct_field_parse(struct rte_swx_pipeline *p,
 				   data->jmp_label);
 		CHECK(found, EINVAL);
 
-		instr->jmp.ip = &instr[found - instruction_data];
+		instr->jmp.ip = &instructions[found - instruction_data];
 	}
 
 	return 0;
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-dev] [PATCH 1/2] pipeline: fix jump instruction population
  2020-10-16 13:57 [dpdk-dev] [PATCH 1/2] pipeline: fix jump instruction population Cristian Dumitrescu
@ 2020-10-16 14:12 ` P, Venkata Suresh Kumar
  2020-10-16 14:17   ` David Marchand
  2020-10-19  7:09 ` David Marchand
  1 sibling, 1 reply; 5+ messages in thread
From: P, Venkata Suresh Kumar @ 2020-10-16 14:12 UTC (permalink / raw)
  To: Dumitrescu, Cristian, dev

Thanks a lot Cristian for sending the patches for review.
I sent patches for review multiple times somehow didn't see in official https://patches.dpdk.org/project/dpdk/list/.

Thanks & Regards,
Suresh.

-----Original Message-----
From: Dumitrescu, Cristian <cristian.dumitrescu@intel.com> 
Sent: Friday, October 16, 2020 7:28 PM
To: dev@dpdk.org
Cc: P, Venkata Suresh Kumar <venkata.suresh.kumar.p@intel.com>; Dumitrescu, Cristian <cristian.dumitrescu@intel.com>
Subject: [PATCH 1/2] pipeline: fix jump instruction population

From: Venkata Suresh Kumar P <venkata.suresh.kumar.p@intel.com>

This patch fixes jump next instruction pointer population

Fixes: b3947e25bed4 ("pipeline: introduce SWX jump and return instructions")
Cc: cristian.dumitrescu@intel.com

Signed-off-by: Venkata Suresh Kumar P <venkata.suresh.kumar.p@intel.com>
Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
---
 lib/librte_pipeline/rte_swx_pipeline.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/librte_pipeline/rte_swx_pipeline.c b/lib/librte_pipeline/rte_swx_pipeline.c
index d5b4a1c..2c9fbf4 100644
--- a/lib/librte_pipeline/rte_swx_pipeline.c
+++ b/lib/librte_pipeline/rte_swx_pipeline.c
@@ -5647,7 +5647,7 @@ struct_field_parse(struct rte_swx_pipeline *p,
 				   data->jmp_label);
 		CHECK(found, EINVAL);
 
-		instr->jmp.ip = &instr[found - instruction_data];
+		instr->jmp.ip = &instructions[found - instruction_data];
 	}
 
 	return 0;
--
1.8.3.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-dev] [PATCH 1/2] pipeline: fix jump instruction population
  2020-10-16 14:12 ` P, Venkata Suresh Kumar
@ 2020-10-16 14:17   ` David Marchand
  2020-10-16 14:20     ` David Marchand
  0 siblings, 1 reply; 5+ messages in thread
From: David Marchand @ 2020-10-16 14:17 UTC (permalink / raw)
  To: P, Venkata Suresh Kumar; +Cc: Dumitrescu, Cristian, dev, Yigit, Ferruh

On Fri, Oct 16, 2020 at 4:12 PM P, Venkata Suresh Kumar
<venkata.suresh.kumar.p@intel.com> wrote:
>
> Thanks a lot Cristian for sending the patches for review.
> I sent patches for review multiple times somehow didn't see in official https://patches.dpdk.org/project/dpdk/list/.

I just checked the dev ml moderation queue, but could only find spam,
and nothing from you.
SMTP issue?


-- 
David Marchand


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-dev] [PATCH 1/2] pipeline: fix jump instruction population
  2020-10-16 14:17   ` David Marchand
@ 2020-10-16 14:20     ` David Marchand
  0 siblings, 0 replies; 5+ messages in thread
From: David Marchand @ 2020-10-16 14:20 UTC (permalink / raw)
  To: P, Venkata Suresh Kumar; +Cc: Dumitrescu, Cristian, dev, Yigit, Ferruh

On Fri, Oct 16, 2020 at 4:17 PM David Marchand
<david.marchand@redhat.com> wrote:
>
> On Fri, Oct 16, 2020 at 4:12 PM P, Venkata Suresh Kumar
> <venkata.suresh.kumar.p@intel.com> wrote:
> >
> > Thanks a lot Cristian for sending the patches for review.
> > I sent patches for review multiple times somehow didn't see in official https://patches.dpdk.org/project/dpdk/list/.
>
> I just checked the dev ml moderation queue, but could only find spam,
> and nothing from you.
> SMTP issue?

And please, do not top post.
Those patches got duplicate tokens in patchwork because of it.


-- 
David Marchand


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-dev] [PATCH 1/2] pipeline: fix jump instruction population
  2020-10-16 13:57 [dpdk-dev] [PATCH 1/2] pipeline: fix jump instruction population Cristian Dumitrescu
  2020-10-16 14:12 ` P, Venkata Suresh Kumar
@ 2020-10-19  7:09 ` David Marchand
  1 sibling, 0 replies; 5+ messages in thread
From: David Marchand @ 2020-10-19  7:09 UTC (permalink / raw)
  To: Cristian Dumitrescu; +Cc: dev, P, Venkata Suresh Kumar, churchill.khangar

On Fri, Oct 16, 2020 at 3:58 PM Cristian Dumitrescu
<cristian.dumitrescu@intel.com> wrote:
>
> From: Venkata Suresh Kumar P <venkata.suresh.kumar.p@intel.com>
>
> This patch fixes jump next instruction pointer
> population
>
> Fixes: b3947e25bed4 ("pipeline: introduce SWX jump and return instructions")
> Cc: cristian.dumitrescu@intel.com
>
> Signed-off-by: Venkata Suresh Kumar P <venkata.suresh.kumar.p@intel.com>
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>

Series applied, thanks.


-- 
David Marchand


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, back to index

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-16 13:57 [dpdk-dev] [PATCH 1/2] pipeline: fix jump instruction population Cristian Dumitrescu
2020-10-16 14:12 ` P, Venkata Suresh Kumar
2020-10-16 14:17   ` David Marchand
2020-10-16 14:20     ` David Marchand
2020-10-19  7:09 ` David Marchand

DPDK patches and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/ public-inbox