From: Jerin Jacob <jerinjacobk@gmail.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: jerinj@marvell.com, dev@dpdk.org, techboard@dpdk.org
Subject: Re: [dpdk-dev] [v3] doc: define qualification criteria for external library
Date: Mon, 8 Jan 2024 13:23:46 +0530 [thread overview]
Message-ID: <CALBAE1MF2Whmg5sLukyOJyyyt4zbCRA5otw6VMY_RVrJwOedBw@mail.gmail.com> (raw)
In-Reply-To: <20240105092725.4f21045e@hermes.local>
On Sat, Jan 6, 2024 at 12:14 AM Stephen Hemminger
<stephen@networkplumber.org> wrote:
>
> On Fri, 5 Jan 2024 17:42:15 +0530
> <jerinj@marvell.com> wrote:
>
>
>
> I would a clause about optional dependency.
> Something like:
>
> If external dependency is not available, then it must be detectable by the
> build process. Missing external library must not impact the core functionality
> of the DPDK; only the library or driver in DPDK will not be built.
OK. I will send the next verison with following update
[main][dpdk.org] $ git diff
diff --git a/doc/guides/contributing/library_dependency.rst
b/doc/guides/contributing/library_dependency.rst
index 367e380a89..7b008d7e8a 100644
--- a/doc/guides/contributing/library_dependency.rst
+++ b/doc/guides/contributing/library_dependency.rst
@@ -44,3 +44,9 @@ used as dependencies in DPDK drivers or libraries.
- Optional dependencies should use stubs to minimize ``ifdef``
clutter, promoting improved
code readability.
+
+#. **Dependency nature:**
+
+ - The external library dependency should be optional.
+ i.e Missing external library must not impact the core
functionality of the DPDK, specififc
+ library and/or driver will not built if dependencies are not meet.
prev parent reply other threads:[~2024-01-08 7:54 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-28 5:16 [dpdk-dev] [PATCH] " jerinj
2023-09-28 5:40 ` [dpdk-dev] [PATCH v2] " jerinj
2023-11-17 4:33 ` Jerin Jacob
2023-11-17 8:27 ` Morten Brørup
2023-11-17 9:52 ` Bruce Richardson
2023-11-17 10:57 ` Morten Brørup
2023-11-19 7:07 ` Jerin Jacob
2023-11-19 8:53 ` Morten Brørup
2023-11-20 17:46 ` Jerin Jacob
2023-11-27 16:25 ` Thomas Monjalon
2023-11-27 17:13 ` Stephen Hemminger
2024-01-05 12:12 ` [dpdk-dev] [v3] " jerinj
2024-01-05 12:24 ` Thomas Monjalon
2024-01-05 12:30 ` [dpdk-dev] [v4] " jerinj
2024-01-08 7:58 ` [dpdk-dev] [v5] " jerinj
2024-01-08 8:17 ` Hemant Agrawal
2024-01-08 8:31 ` Jerin Jacob
2024-01-08 13:27 ` Hemant Agrawal
2024-01-09 13:41 ` Jerin Jacob
2024-01-08 17:18 ` Stephen Hemminger
2024-01-08 19:55 ` Morten Brørup
2024-01-09 13:42 ` Jerin Jacob
2024-01-08 9:25 ` Morten Brørup
2024-01-09 14:01 ` Jerin Jacob
2024-01-09 14:10 ` [dpdk-dev] [v6] " jerinj
2024-03-19 3:32 ` Jerin Jacob
2024-03-19 5:08 ` Hemant Agrawal
2024-03-19 11:59 ` Ferruh Yigit
2024-01-05 17:27 ` [dpdk-dev] [v3] " Stephen Hemminger
2024-01-08 7:53 ` Jerin Jacob [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALBAE1MF2Whmg5sLukyOJyyyt4zbCRA5otw6VMY_RVrJwOedBw@mail.gmail.com \
--to=jerinjacobk@gmail.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=stephen@networkplumber.org \
--cc=techboard@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).