From: Jerin Jacob <jerinjacobk@gmail.com>
To: Rahul Bhansali <rbhansali@marvell.com>,
Ferruh Yigit <ferruh.yigit@xilinx.com>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Cc: dpdk-dev <dev@dpdk.org>,
Nithin Dabilpuram <ndabilpuram@marvell.com>,
Kiran Kumar K <kirankumark@marvell.com>,
Sunil Kumar Kori <skori@marvell.com>,
Satha Rao <skoteshwar@marvell.com>,
Jerin Jacob <jerinj@marvell.com>
Subject: Re: [PATCH 2/2] net/cnxk: use ROC errata API
Date: Tue, 3 May 2022 00:03:30 +0530 [thread overview]
Message-ID: <CALBAE1MvPjii2cMtqodxJdQzU8yZAxKmBAAO0c2=a7o-UrsMbA@mail.gmail.com> (raw)
In-Reply-To: <20220330084356.3614662-2-rbhansali@marvell.com>
On Wed, Mar 30, 2022 at 2:14 PM Rahul Bhansali <rbhansali@marvell.com> wrote:
>
> Used errata APIs roc_errata_nix_has_no_drop_re() and
> roc_errata_nix_has_cq_min_size_4k() instead of direct
> ROC model check.
>
> Signed-off-by: Rahul Bhansali <rbhansali@marvell.com>
Series Acked-by: Jerin Jacob <jerinj@marvell.com>
Series applied to dpdk-next-net-mrvl/for-next-net. Thanks
> ---
> drivers/net/cnxk/cn10k_ethdev.c | 4 +---
> drivers/net/cnxk/cn9k_ethdev.c | 2 +-
> 2 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/cnxk/cn10k_ethdev.c b/drivers/net/cnxk/cn10k_ethdev.c
> index 15dbea2180..6f37bf5a4b 100644
> --- a/drivers/net/cnxk/cn10k_ethdev.c
> +++ b/drivers/net/cnxk/cn10k_ethdev.c
> @@ -778,9 +778,7 @@ cn10k_nix_probe(struct rte_pci_driver *pci_drv, struct rte_pci_device *pci_dev)
> /* DROP_RE is not supported with inline IPSec for CN10K A0 and
> * when vector mode is enabled.
> */
> - if ((roc_model_is_cn10ka_a0() || roc_model_is_cnf10ka_a0() ||
> - roc_model_is_cnf10kb_a0()) &&
> - !roc_env_is_asim()) {
> + if (roc_errata_nix_has_no_drop_re() && !roc_env_is_asim()) {
> dev->ipsecd_drop_re_dis = 1;
> dev->vec_drop_re_dis = 1;
> }
> diff --git a/drivers/net/cnxk/cn9k_ethdev.c b/drivers/net/cnxk/cn9k_ethdev.c
> index eda33dc8c5..be1276180c 100644
> --- a/drivers/net/cnxk/cn9k_ethdev.c
> +++ b/drivers/net/cnxk/cn9k_ethdev.c
> @@ -737,7 +737,7 @@ cn9k_nix_probe(struct rte_pci_driver *pci_drv, struct rte_pci_device *pci_dev)
> roc_nix_ptp_info_cb_register(&dev->nix, cn9k_nix_ptp_info_update_cb);
>
> /* Update HW erratas */
> - if (roc_model_is_cn96_a0() || roc_model_is_cn95_a0())
> + if (roc_errata_nix_has_cq_min_size_4k())
> dev->cq_min_4k = 1;
> return 0;
> }
> --
> 2.25.1
>
prev parent reply other threads:[~2022-05-02 18:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-30 8:43 [PATCH 1/2] common/cnxk: add ROC errata list Rahul Bhansali
2022-03-30 8:43 ` [PATCH 2/2] net/cnxk: use ROC errata API Rahul Bhansali
2022-05-02 18:33 ` Jerin Jacob [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALBAE1MvPjii2cMtqodxJdQzU8yZAxKmBAAO0c2=a7o-UrsMbA@mail.gmail.com' \
--to=jerinjacobk@gmail.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@xilinx.com \
--cc=jerinj@marvell.com \
--cc=kirankumark@marvell.com \
--cc=ndabilpuram@marvell.com \
--cc=rbhansali@marvell.com \
--cc=skori@marvell.com \
--cc=skoteshwar@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).