From: Jerin Jacob <jerinjacobk@gmail.com>
To: Vamsi Attunuru <vattunuru@marvell.com>
Cc: dpdk-dev <dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>,
Jerin Jacob <jerinj@marvell.com>
Subject: Re: [dpdk-dev] [PATCH v1 1/1] mempool/octeontx2: remove minimum chunck size limitation
Date: Fri, 4 Oct 2019 21:18:54 +0530 [thread overview]
Message-ID: <CALBAE1NHb5aif5kC-jjgz4J2pADh=p75TYjW=1BP24XweZb=Og@mail.gmail.com> (raw)
In-Reply-To: <20190910110324.27861-1-vattunuru@marvell.com>
On Tue, Sep 10, 2019 at 4:33 PM <vattunuru@marvell.com> wrote:
>
> From: Vamsi Attunuru <vattunuru@marvell.com>
>
> Memory required for the mempool objects need not be physically
> contiguous on octeontx2's HW, mempool pmd supports the minimum chunk
> size set by the default handler. Hence discarding the limitation set
> by the pmd on the min_chunk_size value.
>
> Signed-off-by: Vamsi Attunuru <vattunuru@marvell.com>
Acked-by: Jerin Jacob <jerinj@marvell.com>
This patch needs to go through to master repo based on MAINTAINERS
file. Changing the "Delegate to" to Thomas in patchwork.
> ---
> drivers/mempool/octeontx2/otx2_mempool_ops.c | 16 ++--------------
> 1 file changed, 2 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/mempool/octeontx2/otx2_mempool_ops.c b/drivers/mempool/octeontx2/otx2_mempool_ops.c
> index f5a4fe3..d769575 100644
> --- a/drivers/mempool/octeontx2/otx2_mempool_ops.c
> +++ b/drivers/mempool/octeontx2/otx2_mempool_ops.c
> @@ -713,24 +713,12 @@ static ssize_t
> otx2_npa_calc_mem_size(const struct rte_mempool *mp, uint32_t obj_num,
> uint32_t pg_shift, size_t *min_chunk_size, size_t *align)
> {
> - ssize_t mem_size;
> -
> /*
> * Simply need space for one more object to be able to
> * fulfill alignment requirements.
> */
> - mem_size = rte_mempool_op_calc_mem_size_default(mp, obj_num + 1,
> - pg_shift,
> - min_chunk_size, align);
> - if (mem_size >= 0) {
> - /*
> - * Memory area which contains objects must be physically
> - * contiguous.
> - */
> - *min_chunk_size = mem_size;
> - }
> -
> - return mem_size;
> + return rte_mempool_op_calc_mem_size_default(mp, obj_num + 1, pg_shift,
> + min_chunk_size, align);
> }
>
> static int
> --
> 2.8.4
>
next prev parent reply other threads:[~2019-10-04 15:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-10 11:03 vattunuru
2019-10-04 15:48 ` Jerin Jacob [this message]
2019-10-24 19:43 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALBAE1NHb5aif5kC-jjgz4J2pADh=p75TYjW=1BP24XweZb=Og@mail.gmail.com' \
--to=jerinjacobk@gmail.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=thomas@monjalon.net \
--cc=vattunuru@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).