DPDK patches and discussions
 help / color / mirror / Atom feed
From: Jerin Jacob <jerinjacobk@gmail.com>
To: Amit Prakash Shukla <amitprakashs@marvell.com>
Cc: Jerin Jacob <jerinj@marvell.com>,
	dev@dpdk.org, s.v.naga.harish.k@intel.com,
	erik.g.carrillo@intel.com, abhinandan.gujjar@intel.com,
	 pbhagavatula@marvell.com, timothy.mcdaniel@intel.com,
	hemant.agrawal@nxp.com,  harry.van.haaren@intel.com,
	mattias.ronnblom@ericsson.com,  liangma@liangbit.com,
	peter.mccarthy@intel.com, skori@marvell.com,
	 thomas@monjalon.net, fengchengwen@huawei.com,
	bruce.richardson@intel.com,  kevin.laatz@intel.com,
	conor.walsh@intel.com, radhac@marvell.com,  g.singh@nxp.com,
	sachin.saxena@oss.nxp.com
Subject: Re: [RFC PATCH] eventdev: introduce DMA event adapter library
Date: Fri, 18 Aug 2023 13:15:10 +0530	[thread overview]
Message-ID: <CALBAE1Om8ZJGFWcVFQa-d-y3pLZY8g6OLrxdg2HBCEpFwwXBPQ@mail.gmail.com> (raw)
In-Reply-To: <20230724080744.1209290-1-amitprakashs@marvell.com>

On Mon, Jul 24, 2023 at 1:39 PM Amit Prakash Shukla
<amitprakashs@marvell.com> wrote:
>
> Introduce event DMA adapter APIs. This patch provides information
> on adapter modes and usage. Application can use this event adapter
> interface to transfer packets between DMA device and event device.
>
> Signed-off-by: Amit Prakash Shukla <amitprakashs@marvell.com>

> +/**
> + * DMA event request structure will be filled by application to provide event request information to
> + * the adapter.
> + */
> +struct rte_event_dma_request {
> +
> +       int16_t dmadev_id;
> +       /**< DMA device ID to be used */
> +
> +       uint16_t queue_pair_id;
> +       /**< DMA queue pair ID to be used */

dmadev wont have queue pair. Use vchan_id or so

> +
> +       uint32_t rsvd;
> +       /**< Reserved bits */
> +};
> +
> +/**
> + * Adapter configuration structure that the adapter configuration callback function is expected to
> + * fill out.
> + *
> + * @see rte_event_dma_adapter_conf_cb
> + */
> +struct rte_event_dma_adapter_conf {
> +       uint8_t event_port_id;
> +       /** < Event port identifier, the adapter enqueues events to this port and dequeues DMA
> +        * request events in RTE_EVENT_DMA_ADAPTER_OP_FORWARD mode.
> +        */
> +
> +       uint32_t max_nb;
> +       /**< The adapter can return early if it has processed at least max_nb DMA ops. This isn't

DMA -> dma

> +        * treated as a requirement; batching may cause the adapter to process more than max_nb DMA
> +        * ops.
> +        */
> +};
> +

> +       rte_event_dma_adapter_create_ext;
> +       rte_event_dma_adapter_create;
> +       rte_event_dma_adapter_free;
> +       rte_event_dma_adapter_queue_pair_add;
> +       rte_event_dma_adapter_queue_pair_del;
> +       rte_event_dma_adapter_start;
> +       rte_event_dma_adapter_stop;
> +       rte_event_dma_adapter_stats_get;
> +       rte_event_dma_adapter_stats_reset;

Fix the build issues in
http://mails.dpdk.org/archives/test-report/2023-July/431120.html by
have dummy functions.


Since it is very similar to crypto adapter, Could not find more review comments.

If there are no review comments, Please send v1 with app changes and
driver changes.

      reply	other threads:[~2023-08-18  7:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-24  8:07 Amit Prakash Shukla
2023-08-18  7:45 ` Jerin Jacob [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CALBAE1Om8ZJGFWcVFQa-d-y3pLZY8g6OLrxdg2HBCEpFwwXBPQ@mail.gmail.com \
    --to=jerinjacobk@gmail.com \
    --cc=abhinandan.gujjar@intel.com \
    --cc=amitprakashs@marvell.com \
    --cc=bruce.richardson@intel.com \
    --cc=conor.walsh@intel.com \
    --cc=dev@dpdk.org \
    --cc=erik.g.carrillo@intel.com \
    --cc=fengchengwen@huawei.com \
    --cc=g.singh@nxp.com \
    --cc=harry.van.haaren@intel.com \
    --cc=hemant.agrawal@nxp.com \
    --cc=jerinj@marvell.com \
    --cc=kevin.laatz@intel.com \
    --cc=liangma@liangbit.com \
    --cc=mattias.ronnblom@ericsson.com \
    --cc=pbhagavatula@marvell.com \
    --cc=peter.mccarthy@intel.com \
    --cc=radhac@marvell.com \
    --cc=s.v.naga.harish.k@intel.com \
    --cc=sachin.saxena@oss.nxp.com \
    --cc=skori@marvell.com \
    --cc=thomas@monjalon.net \
    --cc=timothy.mcdaniel@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).