From: William Tu <u9012063@gmail.com>
To: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Cc: "Kadam, Pallavi" <pallavi.kadam@intel.com>,
dpdk-dev <dev@dpdk.org>,
Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>,
Dmitry Malloy <dmitrym@microsoft.com>
Subject: Re: [dpdk-dev] [PATCH] doc/windows_gsg: update section on driver installation
Date: Sat, 9 Oct 2021 18:28:14 -0700 [thread overview]
Message-ID: <CALDO+SYvXmyMM3HHc3dVfXoVX6q+XxHTbwHysXeHJV8Dks7VAg@mail.gmail.com> (raw)
In-Reply-To: <20211009232016.49f62460@sovereign>
On Sat, Oct 9, 2021 at 1:20 PM Dmitry Kozlyuk <dmitry.kozliuk@gmail.com> wrote:
snip
> > > +Access to physical addresses is provided by a kernel-mode driver, virt2phys.
> > > +It is mandatory for allocating physically-contiguous memory which is required
> > > +by hardware PMDs.
> >
> > Should we add specific link to virt2phys README in this section as well?
> >
> > https://git.dpdk.org/dpdk-kmods/tree/windows/README.rst
>
> This link is given above and I consider it general information for all
> drivers. However, reading it carefully, I think docs in dpdk-kmods could be
> restructured as well:
> * Keep windows/README.rst unchanged, except for Device Manager steps,
> which are actually specific to virt2phys.
> * Create windows/virt2phys/README.rst with instructions above.
> * Change windows/netuio/README.rst: remove the bulk of its content, as it
> repeats generic instructions, keep netuio-specific Device Manager part.
> Then a specific link for virt2phys here would make sense
> and there will be even less duplication in dpdk-kmods.
> If no one objects, I'll do this in v2.
Looks good to me! Thanks
William
next prev parent reply other threads:[~2021-10-10 1:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-08 21:11 Dmitry Kozlyuk
2021-10-09 19:38 ` Kadam, Pallavi
2021-10-09 20:20 ` Dmitry Kozlyuk
2021-10-10 1:28 ` William Tu [this message]
2021-10-11 16:33 ` Kadam, Pallavi
2021-10-11 19:15 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALDO+SYvXmyMM3HHc3dVfXoVX6q+XxHTbwHysXeHJV8Dks7VAg@mail.gmail.com \
--to=u9012063@gmail.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=dmitrym@microsoft.com \
--cc=navasile@linux.microsoft.com \
--cc=pallavi.kadam@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).