Re: [PATCH v9 15/23] net/ark: replace use of term sanity

[Ed Czeck <ed.czeck@atomicrules.com>]

[-- Attachment #1: Type: text/plain, Size: 2834 bytes --]

On Mon, Feb 5, 2024 at 1:03 PM Stephen Hemminger <stephen@networkplumber.org>
wrote:
>
> Do not use non inclusive terms.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
>  drivers/net/ark/ark_ethdev.c    | 8 ++++----
>  drivers/net/ark/ark_ethdev_rx.c | 2 +-
>  2 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/net/ark/ark_ethdev.c b/drivers/net/ark/ark_ethdev.c
> index 0ffd4b9e9e4a..68edb542db43 100644
> --- a/drivers/net/ark/ark_ethdev.c
> +++ b/drivers/net/ark/ark_ethdev.c
> @@ -346,10 +346,10 @@ eth_ark_dev_init(struct rte_eth_dev *dev)
>         ARK_PMD_LOG(NOTICE, "Arkville HW Commit_ID: %08x\n",
>                     rte_be_to_cpu_32(ark->sysctrl.t32[0x20 / 4]));
>
> -       /* If HW sanity test fails, return an error */
> +       /* If HW test fails, return an error */
>         if (ark->sysctrl.t32[4] != 0xcafef00d) {
>                 ARK_PMD_LOG(ERR,
> -                           "HW Sanity test has failed, expected constant"
> +                           "HW test has failed, expected constant"
>                             " 0x%x, read 0x%x (%s)\n",
>                             0xcafef00d,
>                             ark->sysctrl.t32[4], __func__);
> @@ -357,7 +357,7 @@ eth_ark_dev_init(struct rte_eth_dev *dev)
>         }
>
>         ARK_PMD_LOG(DEBUG,
> -                   "HW Sanity test has PASSED, expected constant"
> +                   "HW test has PASSED, expected constant"
>                     " 0x%x, read 0x%x (%s)\n",
>                     0xcafef00d, ark->sysctrl.t32[4], __func__);
>
> @@ -587,7 +587,7 @@ eth_ark_dev_start(struct rte_eth_dev *dev)
>                 rte_thread_t thread;
>
>                 /* Delay packet generator start allow the hardware to be
ready
> -                * This is only used for sanity checking with internal
generator
> +                * This is only used for checking with internal generator
>                  */
>                 char tname[RTE_THREAD_INTERNAL_NAME_SIZE];
>                 snprintf(tname, sizeof(tname), "ark-pg%d",
dev->data->port_id);
> diff --git a/drivers/net/ark/ark_ethdev_rx.c
b/drivers/net/ark/ark_ethdev_rx.c
> index 24f1c65690eb..8ac9d904e795 100644
> --- a/drivers/net/ark/ark_ethdev_rx.c
> +++ b/drivers/net/ark/ark_ethdev_rx.c
> @@ -283,7 +283,7 @@ eth_ark_recv_pkts(void *rx_queue,
>                 mbuf->pkt_len = meta->pkt_len;
>                 mbuf->data_len = meta->pkt_len;
>
> -               if (ARK_DEBUG_CORE) {   /* debug sanity checks */
> +               if (ARK_DEBUG_CORE) {   /* debug checks */
>
>                         if ((meta->pkt_len > (1024 * 16)) ||
>                             (meta->pkt_len == 0)) {
> --
> 2.43.0
>
Acked-by: Ed Czeck <ed.czeck@atomicrules.com>

[-- Attachment #2: Type: text/html, Size: 3753 bytes --]