From: Edwin Brossette <edwin.brossette@6wind.com>
To: dev@dpdk.org
Cc: Olivier Matz <olivier.matz@6wind.com>,
Laurent Hardy <laurent.hardy@6wind.com>
Subject: net/e1000: Test issues following change in max rx/tx queues
Date: Thu, 30 Nov 2023 12:25:15 +0100 [thread overview]
Message-ID: <CANDF9xAQ-Woo9_2fQF3rrKYRCWfiVuJJbR3UtYxGaBAiTsbzdg@mail.gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 917 bytes --]
Hello,
We recently started to observe concerning behaviour on our continuous
integration platform following this commit, which set the maximum amount
of tx/rx queues at 2 for the e1000 pmd:
net/e1000: fix queue number initialization
https://git.dpdk.org/dpdk/commit/?id=c1a42d646472fd3477429bf016f682e0865b77f0
Reverting this change locally on our side was enough to fix our test issues.
There is a considerately long explanation in a comment just above the
change explaining why the number of rx/tx queues is limited at 1, yet it
was changed at 2 anyway.
Since I couldn't see any mention in logs about theses restrictions being
removed, I wished to inquire whether this change was truly intended and if
there was any problem which motivated it.
Maybe the max number of rx/tx queues should reverted back to 1? Or maybe
the comment should be updated if limitations are no longer true?
Regards,
Edwin Brossette.
[-- Attachment #2: Type: text/html, Size: 1271 bytes --]
next reply other threads:[~2023-11-30 11:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-30 11:25 Edwin Brossette [this message]
2023-11-30 12:01 ` Morten Brørup
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANDF9xAQ-Woo9_2fQF3rrKYRCWfiVuJJbR3UtYxGaBAiTsbzdg@mail.gmail.com \
--to=edwin.brossette@6wind.com \
--cc=dev@dpdk.org \
--cc=laurent.hardy@6wind.com \
--cc=olivier.matz@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).