DPDK patches and discussions
 help / color / mirror / Atom feed
From: kumaraparameshwaran rathinavel <kumaraparamesh92@gmail.com>
To: dev@dpdk.org
Subject: [dpdk-dev] Admin Queue ENA
Date: Sat, 19 Oct 2019 23:56:08 +0530	[thread overview]
Message-ID: <CANxNyasW_NDQT5VdvpK+tozkXjjjyx3=dnYXAjfDqyAXeeQJ-Q@mail.gmail.com> (raw)

Hi All,

In the ENA poll mode driver I see that every request in the admin queue is
associated with a completion context and this is preallocated during the
device initialisation. When the completion context is used we check for
occupied to be true in the 16.X version if the occupied flag is set to true
we assert and in the latest version I see that this is an error log. But
there is a time window where if the completion context would be available
to the other consumer but still the old consumer did not set the occupied
to false. The new consumer holds the admin queue lock to get the completion
context but the update by the old consumer to set the the occupied flag is
not done under lock. So should we make sure that the new consumer should
get the completion context only when the occupied flag is set to false. Any
thoughts on this?

If required I can try to make a patch where the completion context would be
available only after setting the occupied flag to false.

Thanks,
Param.

             reply	other threads:[~2019-10-19 18:26 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-19 18:26 kumaraparameshwaran rathinavel [this message]
2019-10-24  8:38 ` Michał Krawczyk
2019-11-08  6:02   ` kumaraparameshwaran rathinavel
2019-11-28 13:14     ` Michał Krawczyk
2019-11-29 12:01       ` kumaraparameshwaran rathinavel
2019-12-04 13:54         ` Michał Krawczyk
2019-12-08 19:03           ` kumaraparameshwaran rathinavel
2019-12-16 10:37             ` Michał Krawczyk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CANxNyasW_NDQT5VdvpK+tozkXjjjyx3=dnYXAjfDqyAXeeQJ-Q@mail.gmail.com' \
    --to=kumaraparamesh92@gmail.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).