From: Rushil Gupta <rushilg@google.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: "Guo, Junfeng" <junfeng.guo@intel.com>,
Jeroen de Borst <jeroendb@google.com>,
Joshua Washington <joshwash@google.com>,
Ferruh Yigit <ferruh.yigit@amd.com>,
dev@dpdk.org, stable@dpdk.org
Subject: Re: [PATCH] net/gve: Change ERR to DEBUG to prevent flooding of logs for Tx-Dqo.
Date: Tue, 20 Feb 2024 09:08:15 +0530 [thread overview]
Message-ID: <CANzqiF7um0ObSJXym=y2FO8dfdS4JJiLBVHXug=rVQiaaTZD1A@mail.gmail.com> (raw)
In-Reply-To: <20240219092643.4f0a0cac@hermes.local>
[-- Attachment #1: Type: text/plain, Size: 925 bytes --]
I agree.
This bug has manifested for a while before I fixed it partially in "[PATCH]
net/gve: fix dqo bug for chained descriptors"
However, for higher queue counts (> 13); we still see this behavior. I'll
add a statistic.
On Mon, Feb 19, 2024, 10:56 PM Stephen Hemminger <stephen@networkplumber.org>
wrote:
> On Mon, 19 Feb 2024 02:44:35 +0000
> Rushil Gupta <rushilg@google.com> wrote:
>
> > This was causing failure for testpmd runs (for queues >=15)
> > presumably due to flooding of logs due to descriptor ring being
> > overwritten.
> >
> > Fixes: a01854 ("net/gve: fix dqo bug for chained descriptors")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Rushil Gupta <rushilg@google.com>
> > Reviewed-by: Joshua Washington <joshwash@google.com>
>
> Isn't this still an error. What about the descriptor overwritten is there
> an mbuf leak?
> Maybe a statistic would be better than a message?
>
[-- Attachment #2: Type: text/html, Size: 1647 bytes --]
prev parent reply other threads:[~2024-02-20 3:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-19 2:44 Rushil Gupta
2024-02-19 9:33 ` Ferruh Yigit
2024-02-20 9:40 ` Rushil Gupta
2024-02-19 10:14 ` Ferruh Yigit
2024-02-19 17:26 ` Stephen Hemminger
2024-02-20 3:38 ` Rushil Gupta [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANzqiF7um0ObSJXym=y2FO8dfdS4JJiLBVHXug=rVQiaaTZD1A@mail.gmail.com' \
--to=rushilg@google.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=jeroendb@google.com \
--cc=joshwash@google.com \
--cc=junfeng.guo@intel.com \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).