From: Sunil Kumar Kori <skori@marvell.com>
To: Muhammad Bilal <m.bilal@emumba.com>
Cc: Stephen Hemminger <stephen@networkplumber.org>,
"declan.doherty@intel.com" <declan.doherty@intel.com>,
"tomasz.kantecki@intel.com" <tomasz.kantecki@intel.com>,
Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"jgrajcia@cisco.com" <jgrajcia@cisco.com>,
"vipin.varghese@intel.com" <vipin.varghese@intel.com>
Subject: RE: [dpdk-dev] [EXT] [PATCH 1/5] examples/l2fwd-event: free resources in case of error
Date: Mon, 12 Jun 2023 17:17:20 +0000 [thread overview]
Message-ID: <CO6PR18MB3860DBADEB2B1DE1AD48C69FB454A@CO6PR18MB3860.namprd18.prod.outlook.com> (raw)
In-Reply-To: <20230612095639.1f62fc15@hermes.local>
Previous mail was destined to me which I believe is not correct.
Updating "To recipient".
Regards
Sunil Kumar Kori
> -----Original Message-----
> From: Stephen Hemminger <stephen@networkplumber.org>
> Sent: Monday, June 12, 2023 10:27 PM
> To: Sunil Kumar Kori <skori@marvell.com>
> Cc: Muhammad Bilal <m.bilal@emumba.com>; declan.doherty@intel.com;
> tomasz.kantecki@intel.com; Pavan Nikhilesh Bhagavatula
> <pbhagavatula@marvell.com>; dev@dpdk.org; jgrajcia@cisco.com;
> vipin.varghese@intel.com
> Subject: Re: [dpdk-dev] [EXT] [PATCH 1/5] examples/l2fwd-event: free
> resources in case of error
>
> On Tue, 16 Jun 2020 10:38:01 +0000
> Sunil Kumar Kori <skori@marvell.com> wrote:
>
> > >> >> >>
> > >> >> >> Also I think, it is better to release the relevant resources on error.
> > >> >> >Here I'm solving the problem reported in bugzilla id 437. The
> > >> >> >bug was that if we use --vdev=net_memif with l2fwd application
> > >> >> >(and with its other variants) then a socket is created by memif
> > >> >> >PMD, after rte_eal_init function has run successfully. And if
> > >> >> >an error occurs then the application exits without freeing the
> > >> >> >resources (socket). On running the application 2nd time we get
> > >> >> >an error of "socket
> > >already exists".
>
> Bottom line: Fix memif, don't wallpaper over the bug by fixing the examples.
>
> Other user applications, can and do crash. The driver needs to be robust and
> handle that.
next prev parent reply other threads:[~2023-06-12 17:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-19 8:54 [dpdk-dev] " Muhammad Bilal
2020-05-19 8:54 ` [dpdk-dev] [PATCH 2/5] examples/l2fwd-jobstats: " Muhammad Bilal
2020-05-19 8:54 ` [dpdk-dev] [PATCH 3/5] examples/l2fwd-keepalive: " Muhammad Bilal
2020-05-19 8:54 ` [dpdk-dev] [PATCH 4/5] examples/l2fwd-cat: " Muhammad Bilal
2020-05-19 8:54 ` [dpdk-dev] [PATCH 5/5] examples/l2fwd-crypto: " Muhammad Bilal
2020-05-19 9:34 ` [dpdk-dev] [EXT] [PATCH 1/5] examples/l2fwd-event: " Sunil Kumar Kori
2020-06-02 12:27 ` Muhammad Bilal
2020-06-10 10:01 ` Sunil Kumar Kori
2020-06-15 12:00 ` Muhammad Bilal
2020-06-16 5:53 ` Sunil Kumar Kori
2020-06-16 10:14 ` Muhammad Bilal
2020-06-16 10:38 ` Sunil Kumar Kori
2023-06-12 16:56 ` Stephen Hemminger
2023-06-12 17:17 ` Sunil Kumar Kori [this message]
2020-06-16 11:47 ` Jakub Grajciar -X (jgrajcia - PANTHEON TECH SRO at Cisco)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CO6PR18MB3860DBADEB2B1DE1AD48C69FB454A@CO6PR18MB3860.namprd18.prod.outlook.com \
--to=skori@marvell.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=jgrajcia@cisco.com \
--cc=m.bilal@emumba.com \
--cc=pbhagavatula@marvell.com \
--cc=stephen@networkplumber.org \
--cc=tomasz.kantecki@intel.com \
--cc=vipin.varghese@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).