RE: [EXT] [dpdk-dev] [PATCH V4] crypto/mlx5: support BF2 and ConnectX6-DX devices

[Akhil Goyal <gakhil@marvell.com>]

> Starting from FW version xx.32.0108. version, the BlueField2 and ConnextX6-
> DX
> adapters support crypto operations.
> 
> Add them to the supported PCI devices list.
> 
> Signed-off-by: Raja Zidane <rzidane@nvidia.com>
> Acked-by: Matan Azrad <matan@nvidia.com>
> ---
> V2: fixed checkpatch warning.
> V3: fixed doc.
> V4: fixed commit log.
>  doc/guides/cryptodevs/mlx5.rst         | 11 ++++++++++-
>  doc/guides/rel_notes/release_21_11.rst |  2 +-
>  drivers/crypto/mlx5/mlx5_crypto.c      |  8 ++++++++
>  3 files changed, 19 insertions(+), 2 deletions(-)
> 
> diff --git a/doc/guides/cryptodevs/mlx5.rst
> b/doc/guides/cryptodevs/mlx5.rst
> index 9bd8c6fe85..fe18a20717 100644
> --- a/doc/guides/cryptodevs/mlx5.rst
> +++ b/doc/guides/cryptodevs/mlx5.rst
> @@ -88,6 +88,7 @@ The mlxreg dedicated tool should be used as follows:
>    should not be specified.
> 
>    All the device ports should set it in order to move to operational mode.
> +  For BlueField2, also the internal ports in the ARMs system should be set.

Rephrase it to
For BlueField2, the internal ports in the ARMs system should also be set.
> 
>  - Query CRYPTO_OPERATIONAL register to make sure the device is in
> Operational
>    mode.
> @@ -141,6 +142,8 @@ Supported NICs
>  --------------
> 
>  * Mellanox\ |reg| ConnectX\ |reg|-6 200G MCX654106A-HCAT (2x200G)
> +* Mellanox\ |reg| BlueField 2 SmartNIC
> +* Mellanox\ |reg| ConnectX\ |reg|-6DX
> 
> 
>  Limitations
> @@ -155,10 +158,16 @@ Limitations
>  Prerequisites
>  -------------
> 
> +FW Prerequisites
> +~~~~~~~~~~~~~~~~
> +
> +- xx.31.0328 for ConnectX6.
> +- xx.32.0108 for ConnectX6DX and BlueField2.
> +
>  Linux Prerequisites
>  ~~~~~~~~~~~~~~~~~~~
> 
> -- Mellanox OFED version: **5.3**
> +- Mellanox OFED version: **5.3**.
>    see :doc:`../../nics/mlx5` guide for more Mellanox OFED details.
> 
>  - Compilation can be done also with rdma-core v15+.
> diff --git a/doc/guides/rel_notes/release_21_11.rst
> b/doc/guides/rel_notes/release_21_11.rst
> index 01923e2deb..96d14e01fd 100644
> --- a/doc/guides/rel_notes/release_21_11.rst
> +++ b/doc/guides/rel_notes/release_21_11.rst
> @@ -291,6 +291,7 @@ New Features
>  * **Updated Mellanox mlx5 crypto driver.**
> 
>    * Added Windows support.
> +  * Added support for BF2 and CX6DX.
You may use Bluefield2 and ConnectX6-DX instead.

> 
>  * **Updated NXP dpaa_sec crypto PMD.**
> 
> @@ -416,7 +417,6 @@ New Features
>    overruns in C/C++ programs, and other similar errors, as well as
>    printing out detailed debug information whenever an error is detected.
> 
> -

Do not remove this line.

>  Removed Items
>  -------------
> 
> diff --git a/drivers/crypto/mlx5/mlx5_crypto.c
> b/drivers/crypto/mlx5/mlx5_crypto.c
> index 3caa22f35f..47da3d115b 100644
> --- a/drivers/crypto/mlx5/mlx5_crypto.c
> +++ b/drivers/crypto/mlx5/mlx5_crypto.c
> @@ -994,6 +994,14 @@ static const struct rte_pci_id
> mlx5_crypto_pci_id_map[] = {
>  			RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX,
> 
> 	PCI_DEVICE_ID_MELLANOX_CONNECTX6)
>  		},
> +		{
> +			RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX,
> +
> 	PCI_DEVICE_ID_MELLANOX_CONNECTX6DX)
> +		},
> +		{
> +			RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX,
> +
> 	PCI_DEVICE_ID_MELLANOX_CONNECTX6DXBF)
> +		},
>  		{
>  			.vendor_id = 0
>  		}
> --
> 2.17.1