Re: [EXT] Re: [PATCH v2 1/1] usertools/rss: add CNXK RSS key

["Robin Jarry" <rjarry@redhat.com>]

Thomas Monjalon, Oct 18, 2023 at 11:14:
> 18/10/2023 09:26, Sunil Kumar Kori:
> > From: Robin Jarry <rjarry@redhat.com>
> > > From: Sunil Kumar Kori <skori@marvell.com>
> > > >
> > > > This patch adds RSS key for CNXK platforms. CNXK platform uses
> > > > 48 bytes long key for hash calculations.
> > > >
> > > > For the same patch also updates help mesaages to provide range
> > > > information for supporting NICs/platforms.
> > > >
> > > > Also CNXK uses reta size as 64 so to get correct offset to retrieve
> > > > queue index, user must pass reta_size option as 64 i.e. -t 64.
> > > 
> > > I think we should add some driver abstraction that contains the required key
> > > length and default reta size. Instead of requiring the user to guess the correct
> > > values. Is that something you could do?
> > > 
> > Okay but in either case i.e. -t option or driver abstraction, user must know the reta size and key size before configuring.
> > So  I am not sure that how adding driver abstraction will help to solve this issue unless/until its documented somewhere.
>
> You can start with an option to get the size printed, depending on driver name.
>
> > So for current release, I am planning to go this version as it is because we are close.
> > Later on we can think of it and add required support. 
> > Please provide input on it.
>
> Please provide a more user friendly experience in this release.

I could have a shot at it since it may involve some refactoring. Also, 
existing supported drivers will benefit from it. This does not seem like 
it is directly related to CNXK.