From: "Zhang, Roy Fan" <roy.fan.zhang@intel.com>
To: Akhil Goyal <gakhil@marvell.com>,
"Luse, Paul E" <paul.e.luse@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "matan@nvidia.com" <matan@nvidia.com>,
"hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>
Subject: Re: [dpdk-dev] Recent change to make rte_cryptodev_pmd.h internal prevents some important functionality
Date: Mon, 4 Oct 2021 07:43:58 +0000 [thread overview]
Message-ID: <CY4PR11MB1718195656C300771D5C9564B8AE9@CY4PR11MB1718.namprd11.prod.outlook.com> (raw)
In-Reply-To: <CO6PR18MB44847AFFB3FE1A205581C925D8AE9@CO6PR18MB4484.namprd18.prod.outlook.com>
Hi Akhil,
This isn’t what our concern was – our concern was rte_cryptodev_close() may not remove the memory complete as rte_cryptodev_pmd_destroy() did.
Our research result towards this was if the PMD could act more throughout to make rte_cryptodev_close() working same as rte_cryptodev_pmd_destroy().
What Paul’s concern is valid: We DO NOT have a way to release a queue pair manually anymore, and releasing queue pair to me should not be blocked from public API access.
To resolve this problem we should have a public queue_pair_release() function in the cryptodev. If you are ok I can send a patch for 21.11 right away.
Regards,
Fan
From: Akhil Goyal <gakhil@marvell.com>
Sent: Monday, October 4, 2021 7:45 AM
To: Luse, Paul E <paul.e.luse@intel.com>; dev@dpdk.org; Zhang, Roy Fan <roy.fan.zhang@intel.com>
Cc: matan@nvidia.com; hemant.agrawal@nxp.com
Subject: RE: Recent change to make rte_cryptodev_pmd.h internal prevents some important functionality
Hi Paul,
Similar comment was discussed in ML for fips_validation app.
https://mails.dpdk.org/archives/dev/2021-August/217781.html
I believe Fan is working on it to fix the issue.
Fan, Could you please share the update.
Regards,
Akhil
Note: Please CC maintainers for a prompt response, or else mails can be skipped.
From: Luse, Paul E <paul.e.luse@intel.com<mailto:paul.e.luse@intel.com>>
Sent: Sunday, October 3, 2021 3:14 AM
To: dev@dpdk.org<mailto:dev@dpdk.org>
Cc: Akhil Goyal <gakhil@marvell.com<mailto:gakhil@marvell.com>>; matan@nvidia.com<mailto:matan@nvidia.com>; Zhang, Roy Fan <roy.fan.zhang@intel.com<mailto:roy.fan.zhang@intel.com>>; hemant.agrawal@nxp.com<mailto:hemant.agrawal@nxp.com>
Subject: [EXT] Recent change to make rte_cryptodev_pmd.h internal prevents some important functionality
External Email
________________________________
Hi Everyone,
I sent this last week and haven’t heard back – apologize if I missed the response but if not here it is again…
We use cryptodev in SPDK and included rte_cryptodev_pmd.h so that we may release qpair memory that was allocated when we called rte_cryptodev_queue_pair_setup(). We’d do so by calling the function pointer queue_pair_release() which I believe is the prescribed way to do this.
The DPDK change in question is here: https://github.com/DPDK/dpdk/commit/af668035f7f492424b2e199f155690815944a8ca<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_DPDK_dpdk_commit_af668035f7f492424b2e199f155690815944a8ca&d=DwMF-g&c=nKjWec2b6R0mOyPaz7xtfQ&r=DnL7Si2wl_PRwpZ9TWey3eu68gBzn7DkPwuqhd6WNyo&m=JtjV1tR2S7GKiUDbCzH0F3Eb5a0srzYbypWQ7frSYlM&s=KPcZHMXJD19T_7amxWdYShvis2l7nWAnfs-nJ85FVto&e=>
Question: Is there another way for us to release this memory? I’ve looked through the public API and nothing stands out.
Thanks
Paul
next prev parent reply other threads:[~2021-10-04 7:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-28 17:53 Luse, Paul E
2021-10-02 21:44 ` Luse, Paul E
2021-10-04 6:45 ` Akhil Goyal
2021-10-04 7:43 ` Zhang, Roy Fan [this message]
2021-10-04 8:02 ` Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CY4PR11MB1718195656C300771D5C9564B8AE9@CY4PR11MB1718.namprd11.prod.outlook.com \
--to=roy.fan.zhang@intel.com \
--cc=dev@dpdk.org \
--cc=gakhil@marvell.com \
--cc=hemant.agrawal@nxp.com \
--cc=matan@nvidia.com \
--cc=paul.e.luse@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).