Re: [dpdk-dev] [PATCH v2] test: rely on EAL detection for core list

[Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>]

<snip>

> >
> > >
> > > Cores count has a direct impact on the time needed to complete unit tests.
> > We also need to control the number of iterations with in the tests.
> >
> > We could add something like "-i low/medium/high". The test cases then can
> use this to decide on how many iterations to run.
> 
> This patch hands control of parameters that affect all tests to the CI.
> 
> But number of iterations is a per test thing.
Agree, it is a per test thing. But, multiple test files run the test case in several iterations. So, multiple test cases can make use of the same input from the user.

> What would be the definition of an "iteration"?
> Something that must be done in a maximum of cycles.. ?
You can look at test_atomic.c, we have the following #define

#define N 1000000

It is used as follows (in the simplest case) to repeat a test:

for (i = 0; i < N; i++)
                rte_atomic16_inc(&a16);

The value 1000000 defines how long this test will take.

In a CI environment, we want to reduce the time taken, whereas in a local lab machine, I might not care about the time it takes to run the test. This could be an input from the user which the test cases can make use of. For ex: for 'low', test case might set N = 10000 and so on.

> 
> This could be something to look at, but it goes beyond this patch.
Agreed, this can be a separate patch.

> 
> 
> --
> David Marchand