From: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
To: Fady Bader <fady@mellanox.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "thomas@monjalon.net" <thomas@monjalon.net>,
"talshn@mellanox.com" <talshn@mellanox.com>,
"yohadt@mellanox.com" <yohadt@mellanox.com>,
"olivier.matz@6wind.com" <olivier.matz@6wind.com>,
"harini.ramakrishnan@microsoft.com"
<harini.ramakrishnan@microsoft.com>,
"ocardona@microsoft.com" <ocardona@microsoft.com>,
"anand.rawat@intel.com" <anand.rawat@intel.com>,
"ranjit.menon@intel.com" <ranjit.menon@intel.com>,
"dmitry.kozliuk@gmail.com" <dmitry.kozliuk@gmail.com>,
Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
nd <nd@arm.com>, nd <nd@arm.com>
Subject: Re: [dpdk-dev] [PATCH v2] ring: build on Windows
Date: Thu, 21 May 2020 04:17:16 +0000 [thread overview]
Message-ID: <DBBPR08MB4646EEC7E844FE628EA8874C98B70@DBBPR08MB4646.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <20200520104445.9072-1-fady@mellanox.com>
<snip>
> Subject: [dpdk-dev] [PATCH v2] ring: build on Window
^^^^ change this to 'eal'.
Even though the compilation error points to rte_ring, this is not a issue in rte_ring library. Suggest changing the commit message to something like "eal: add per_lcore__rte_errno to export list for Windows".
>
> Exported per_lcore__rte_errno function to compile ring for windows.
>
> compilation error logs:
> librte_ring_rte_ring.c.obj : error LNK2019: unresolved external symbol
> per_lcore__rte_errno referenced in function rte_ring_lookup
>
> The cause was that per_lcore__rte_errno function wasn't included in the
> export list.
> To solve this per_lcore__rte_errno was added to the Windows export list.
>
> Signed-off-by: Fady Bader <fady@mellanox.com>
> Depends-on: series-9374 ("Windows basic memory management")
> ---
> lib/librte_eal/rte_eal_exports.def | 1 + lib/librte_eal/rte_eal_version.map | 3
> +++
> lib/meson.build | 5 ++++-
> 3 files changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/lib/librte_eal/rte_eal_exports.def
> b/lib/librte_eal/rte_eal_exports.def
> index 854b83bcd..cbb6b8cfe 100644
> --- a/lib/librte_eal/rte_eal_exports.def
> +++ b/lib/librte_eal/rte_eal_exports.def
> @@ -1,5 +1,6 @@
> EXPORTS
> __rte_panic
> + per_lcore__rte_errno
> rte_calloc
> rte_calloc_socket
> rte_eal_get_configuration
> diff --git a/lib/librte_eal/rte_eal_version.map
> b/lib/librte_eal/rte_eal_version.map
> index bdd014638..0f1b983b8 100644
> --- a/lib/librte_eal/rte_eal_version.map
> +++ b/lib/librte_eal/rte_eal_version.map
> @@ -390,4 +390,7 @@ EXPERIMENTAL {
> rte_trace_point_lookup;
> rte_trace_regexp;
> rte_trace_save;
> +
> + # added in 20.08
> + __emutls_v.per_lcore__rte_errno;
Not sure why this is required. per_lcore__rte_errno is present already in this file.
> };
> diff --git a/lib/meson.build b/lib/meson.build index d190d84ef..98ee5ec57
> 100644
> --- a/lib/meson.build
> +++ b/lib/meson.build
> @@ -36,7 +36,10 @@ libraries = [
> 'flow_classify', 'bpf', 'graph', 'node']
>
> if is_windows
> - libraries = ['kvargs','eal'] # only supported libraries for windows
> + libraries = [
> + 'kvargs',
> + 'eal',
> + 'ring'] # only supported libraries for windows
> endif
>
> default_cflags = machine_args
> --
> 2.16.1.windows.4
next prev parent reply other threads:[~2020-05-21 4:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-20 10:44 Fady Bader
2020-05-20 20:46 ` Ranjit Menon
2020-05-21 4:17 ` Honnappa Nagarahalli [this message]
2020-05-21 8:26 ` Thomas Monjalon
2020-05-21 15:02 ` Fady Bader
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DBBPR08MB4646EEC7E844FE628EA8874C98B70@DBBPR08MB4646.eurprd08.prod.outlook.com \
--to=honnappa.nagarahalli@arm.com \
--cc=anand.rawat@intel.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=fady@mellanox.com \
--cc=harini.ramakrishnan@microsoft.com \
--cc=nd@arm.com \
--cc=ocardona@microsoft.com \
--cc=olivier.matz@6wind.com \
--cc=ranjit.menon@intel.com \
--cc=talshn@mellanox.com \
--cc=thomas@monjalon.net \
--cc=yohadt@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).