* RE: [PATCH] net/cpfl: fix fail to re-configure RSS
2023-06-16 12:00 [PATCH] net/cpfl: fix fail to re-configure RSS beilei.xing
@ 2023-06-16 8:40 ` Wu, Jingjing
2023-06-19 0:44 ` Zhang, Qi Z
0 siblings, 1 reply; 3+ messages in thread
From: Wu, Jingjing @ 2023-06-16 8:40 UTC (permalink / raw)
To: Xing, Beilei, Zhang, Yuying; +Cc: dev
> -----Original Message-----
> From: Xing, Beilei <beilei.xing@intel.com>
> Sent: Friday, June 16, 2023 8:00 PM
> To: Wu, Jingjing <jingjing.wu@intel.com>; Zhang, Yuying <yuying.zhang@intel.com>
> Cc: dev@dpdk.org; Xing, Beilei <beilei.xing@intel.com>
> Subject: [PATCH] net/cpfl: fix fail to re-configure RSS
>
> From: Beilei Xing <beilei.xing@intel.com>
>
> Currently, if launch testpmd with multiple queues and re-configure
> rxq with 'port config all rxq 1', Rx queue 0 may not receive packets.
> that's because RSS lookup tale is not re-configured when Rxq number
> is 1.
> Although Rxq number is 1 and multi queue mode is RTE_ETH_MQ_RX_NONE,
> cpfl PMD should init RSS to allow RSS re-configuration.
>
> Fixes: cfbc66551a14 ("net/cpfl: support RSS")
>
> Signed-off-by: Beilei Xing <beilei.xing@intel.com>
Acked-by: Jingjing Wu <jingjing.wu@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] net/cpfl: fix fail to re-configure RSS
@ 2023-06-16 12:00 beilei.xing
2023-06-16 8:40 ` Wu, Jingjing
0 siblings, 1 reply; 3+ messages in thread
From: beilei.xing @ 2023-06-16 12:00 UTC (permalink / raw)
To: jingjing.wu, yuying.zhang; +Cc: dev, Beilei Xing
From: Beilei Xing <beilei.xing@intel.com>
Currently, if launch testpmd with multiple queues and re-configure
rxq with 'port config all rxq 1', Rx queue 0 may not receive packets.
that's because RSS lookup tale is not re-configured when Rxq number
is 1.
Although Rxq number is 1 and multi queue mode is RTE_ETH_MQ_RX_NONE,
cpfl PMD should init RSS to allow RSS re-configuration.
Fixes: cfbc66551a14 ("net/cpfl: support RSS")
Signed-off-by: Beilei Xing <beilei.xing@intel.com>
---
drivers/net/cpfl/cpfl_ethdev.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/net/cpfl/cpfl_ethdev.c b/drivers/net/cpfl/cpfl_ethdev.c
index e96bf0a82e..9755ffe508 100644
--- a/drivers/net/cpfl/cpfl_ethdev.c
+++ b/drivers/net/cpfl/cpfl_ethdev.c
@@ -712,17 +712,15 @@ cpfl_dev_configure(struct rte_eth_dev *dev)
return -EINVAL;
}
- if (base->caps.rss_caps != 0 && dev->data->nb_rx_queues != 0 &&
- conf->rxmode.mq_mode == RTE_ETH_MQ_RX_RSS) {
+ if (base->caps.rss_caps != 0 && dev->data->nb_rx_queues != 0) {
ret = cpfl_init_rss(vport);
if (ret != 0) {
PMD_INIT_LOG(ERR, "Failed to init rss");
return ret;
}
- } else {
+ } else if (conf->rxmode.mq_mode == RTE_ETH_MQ_RX_RSS) {
PMD_INIT_LOG(ERR, "RSS is not supported.");
- if (conf->rxmode.mq_mode == RTE_ETH_MQ_RX_RSS)
- return -ENOTSUP;
+ return -ENOTSUP;
}
vport->max_pkt_len =
--
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] net/cpfl: fix fail to re-configure RSS
2023-06-16 8:40 ` Wu, Jingjing
@ 2023-06-19 0:44 ` Zhang, Qi Z
0 siblings, 0 replies; 3+ messages in thread
From: Zhang, Qi Z @ 2023-06-19 0:44 UTC (permalink / raw)
To: Wu, Jingjing, Xing, Beilei, Zhang, Yuying; +Cc: dev
> -----Original Message-----
> From: Wu, Jingjing <jingjing.wu@intel.com>
> Sent: Friday, June 16, 2023 4:41 PM
> To: Xing, Beilei <beilei.xing@intel.com>; Zhang, Yuying
> <yuying.zhang@intel.com>
> Cc: dev@dpdk.org
> Subject: RE: [PATCH] net/cpfl: fix fail to re-configure RSS
>
>
>
> > -----Original Message-----
> > From: Xing, Beilei <beilei.xing@intel.com>
> > Sent: Friday, June 16, 2023 8:00 PM
> > To: Wu, Jingjing <jingjing.wu@intel.com>; Zhang, Yuying
> > <yuying.zhang@intel.com>
> > Cc: dev@dpdk.org; Xing, Beilei <beilei.xing@intel.com>
> > Subject: [PATCH] net/cpfl: fix fail to re-configure RSS
> >
> > From: Beilei Xing <beilei.xing@intel.com>
> >
> > Currently, if launch testpmd with multiple queues and re-configure rxq
> > with 'port config all rxq 1', Rx queue 0 may not receive packets.
> > that's because RSS lookup tale is not re-configured when Rxq number is
> > 1.
> > Although Rxq number is 1 and multi queue mode is
> RTE_ETH_MQ_RX_NONE,
> > cpfl PMD should init RSS to allow RSS re-configuration.
> >
> > Fixes: cfbc66551a14 ("net/cpfl: support RSS")
> >
> > Signed-off-by: Beilei Xing <beilei.xing@intel.com>
>
> Acked-by: Jingjing Wu <jingjing.wu@intel.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-06-19 0:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-16 12:00 [PATCH] net/cpfl: fix fail to re-configure RSS beilei.xing
2023-06-16 8:40 ` Wu, Jingjing
2023-06-19 0:44 ` Zhang, Qi Z
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).