* [PATCH 4/4] net/iavf: enable UDP fragmentation offload
@ 2023-04-13 5:35 Zhichao Zeng
2023-05-24 5:20 ` Xu, Ke1
0 siblings, 1 reply; 3+ messages in thread
From: Zhichao Zeng @ 2023-04-13 5:35 UTC (permalink / raw)
To: dev; +Cc: qi.z.zhang, ke1.xu, Zhichao Zeng, Jingjing Wu, Beilei Xing
This commit enables transmit segmentation offload for UDP, including both
non-tunneled and tunneled packets.
The command "tso set <tso_segsz> <port_id>" or
"tunnel_tso set <tso_segsz> <port_id>" is used to enable UFO.
Signed-off-by: Zhichao Zeng <zhichaox.zeng@intel.com>
---
drivers/net/iavf/iavf_rxtx.c | 2 +-
drivers/net/iavf/iavf_rxtx.h | 2 ++
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/iavf/iavf_rxtx.c b/drivers/net/iavf/iavf_rxtx.c
index b1d0fbceb6..8eca8aba3e 100644
--- a/drivers/net/iavf/iavf_rxtx.c
+++ b/drivers/net/iavf/iavf_rxtx.c
@@ -3622,7 +3622,7 @@ iavf_prep_pkts(__rte_unused void *tx_queue, struct rte_mbuf **tx_pkts,
ol_flags = m->ol_flags;
/* Check condition for nb_segs > IAVF_TX_MAX_MTU_SEG. */
- if (!(ol_flags & RTE_MBUF_F_TX_TCP_SEG)) {
+ if (!(ol_flags & (RTE_MBUF_F_TX_TCP_SEG | RTE_MBUF_F_TX_UDP_SEG))) {
if (m->nb_segs > IAVF_TX_MAX_MTU_SEG) {
rte_errno = EINVAL;
return i;
diff --git a/drivers/net/iavf/iavf_rxtx.h b/drivers/net/iavf/iavf_rxtx.h
index 09e2127db0..5096868d87 100644
--- a/drivers/net/iavf/iavf_rxtx.h
+++ b/drivers/net/iavf/iavf_rxtx.h
@@ -73,6 +73,7 @@
RTE_MBUF_F_TX_IP_CKSUM | \
RTE_MBUF_F_TX_L4_MASK | \
RTE_MBUF_F_TX_TCP_SEG | \
+ RTE_MBUF_F_TX_UDP_SEG | \
RTE_MBUF_F_TX_OUTER_IP_CKSUM | \
RTE_MBUF_F_TX_OUTER_UDP_CKSUM)
@@ -85,6 +86,7 @@
RTE_MBUF_F_TX_IP_CKSUM | \
RTE_MBUF_F_TX_L4_MASK | \
RTE_MBUF_F_TX_TCP_SEG | \
+ RTE_MBUF_F_TX_UDP_SEG | \
RTE_MBUF_F_TX_TUNNEL_MASK | \
RTE_MBUF_F_TX_OUTER_IP_CKSUM | \
RTE_MBUF_F_TX_OUTER_UDP_CKSUM | \
--
2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread* RE: [PATCH 4/4] net/iavf: enable UDP fragmentation offload
2023-04-13 5:35 [PATCH 4/4] net/iavf: enable UDP fragmentation offload Zhichao Zeng
@ 2023-05-24 5:20 ` Xu, Ke1
2023-06-07 1:00 ` Zhang, Qi Z
0 siblings, 1 reply; 3+ messages in thread
From: Xu, Ke1 @ 2023-05-24 5:20 UTC (permalink / raw)
To: Zeng, ZhichaoX, dev; +Cc: Zhang, Qi Z, Wu, Jingjing, Xing, Beilei, Xu, Ke1
> From: Zeng, ZhichaoX <zhichaox.zeng@intel.com>
> Sent: Thursday, April 13, 2023 1:35 PM
> To: dev@dpdk.org
> Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; Xu, Ke1 <ke1.xu@intel.com>; Zeng,
> ZhichaoX <zhichaox.zeng@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>;
> Xing, Beilei <beilei.xing@intel.com>
> Subject: [PATCH 4/4] net/iavf: enable UDP fragmentation offload
>
> This commit enables transmit segmentation offload for UDP, including both
> non-tunneled and tunneled packets.
>
> The command "tso set <tso_segsz> <port_id>" or "tunnel_tso set <tso_segsz>
> <port_id>" is used to enable UFO.
>
> Signed-off-by: Zhichao Zeng <zhichaox.zeng@intel.com>
Verified and Passed.
Two extra issues exists found blocking very limited part of validation.
1. On QEMU DCF not able to enable rx_vxlan.
2. IPv6 Tunneled UDP packets triggers MDD event.
Tested-by: Ke Xu <ke1.xu@intel.com>
> ---
> drivers/net/iavf/iavf_rxtx.c | 2 +-
> drivers/net/iavf/iavf_rxtx.h | 2 ++
> 2 files changed, 3 insertions(+), 1 deletion(-)
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH 4/4] net/iavf: enable UDP fragmentation offload
2023-05-24 5:20 ` Xu, Ke1
@ 2023-06-07 1:00 ` Zhang, Qi Z
0 siblings, 0 replies; 3+ messages in thread
From: Zhang, Qi Z @ 2023-06-07 1:00 UTC (permalink / raw)
To: Xu, Ke1, Zeng, ZhichaoX, dev; +Cc: Wu, Jingjing, Xing, Beilei
> -----Original Message-----
> From: Xu, Ke1 <ke1.xu@intel.com>
> Sent: Wednesday, May 24, 2023 1:21 PM
> To: Zeng, ZhichaoX <zhichaox.zeng@intel.com>; dev@dpdk.org
> Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; Wu, Jingjing
> <jingjing.wu@intel.com>; Xing, Beilei <beilei.xing@intel.com>; Xu, Ke1
> <ke1.xu@intel.com>
> Subject: RE: [PATCH 4/4] net/iavf: enable UDP fragmentation offload
>
> > From: Zeng, ZhichaoX <zhichaox.zeng@intel.com>
> > Sent: Thursday, April 13, 2023 1:35 PM
> > To: dev@dpdk.org
> > Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; Xu, Ke1 <ke1.xu@intel.com>;
> > Zeng, ZhichaoX <zhichaox.zeng@intel.com>; Wu, Jingjing
> > <jingjing.wu@intel.com>; Xing, Beilei <beilei.xing@intel.com>
> > Subject: [PATCH 4/4] net/iavf: enable UDP fragmentation offload
> >
> > This commit enables transmit segmentation offload for UDP, including
> > both non-tunneled and tunneled packets.
> >
> > The command "tso set <tso_segsz> <port_id>" or "tunnel_tso set
> > <tso_segsz> <port_id>" is used to enable UFO.
> >
> > Signed-off-by: Zhichao Zeng <zhichaox.zeng@intel.com>
>
> Verified and Passed.
>
> Two extra issues exists found blocking very limited part of validation.
> 1. On QEMU DCF not able to enable rx_vxlan.
> 2. IPv6 Tunneled UDP packets triggers MDD event.
>
> Tested-by: Ke Xu <ke1.xu@intel.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-06-07 1:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-13 5:35 [PATCH 4/4] net/iavf: enable UDP fragmentation offload Zhichao Zeng
2023-05-24 5:20 ` Xu, Ke1
2023-06-07 1:00 ` Zhang, Qi Z
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).