* [dpdk-dev] [PATCH] net/mlx5: update GENEVE TLV option exist bit
@ 2021-05-31 11:45 Shiri Kuzin
2021-06-06 11:32 ` Raslan Darawsheh
0 siblings, 1 reply; 5+ messages in thread
From: Shiri Kuzin @ 2021-05-31 11:45 UTC (permalink / raw)
To: dev; +Cc: matan, rasland, viacheslavo
The GENEVE TLV option matching is done using a flex parser.
Recent update in firmware, requires that in order to match on the
GENEVE TLV option the "geneve_tlv_option_0_exist" bit should be set.
Add the new "geneve_tlv_option_0_exist" setting when translating the
GENEVE TLV option item.
Signed-off-by: Shiri Kuzin <shirik@nvidia.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
---
drivers/common/mlx5/mlx5_prm.h | 3 ++-
drivers/net/mlx5/mlx5_flow_dv.c | 2 ++
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/common/mlx5/mlx5_prm.h b/drivers/common/mlx5/mlx5_prm.h
index 26761f5bd3..3e4e6fa216 100644
--- a/drivers/common/mlx5/mlx5_prm.h
+++ b/drivers/common/mlx5/mlx5_prm.h
@@ -853,7 +853,8 @@ struct mlx5_ifc_fte_match_set_misc_bits {
u8 vxlan_vni[0x18];
u8 reserved_at_b8[0x8];
u8 geneve_vni[0x18];
- u8 reserved_at_e4[0x7];
+ u8 reserved_at_e4[0x6];
+ u8 geneve_tlv_option_0_exist[0x1];
u8 geneve_oam[0x1];
u8 reserved_at_e0[0xc];
u8 outer_ipv6_flow_label[0x14];
diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c
index c50649a107..f009689cff 100644
--- a/drivers/net/mlx5/mlx5_flow_dv.c
+++ b/drivers/net/mlx5/mlx5_flow_dv.c
@@ -8939,6 +8939,8 @@ flow_dv_translate_item_geneve_opt(struct rte_eth_dev *dev, void *matcher,
MLX5_SET(fte_match_set_misc, misc_v, geneve_opt_len,
geneve_opt_v->option_len + 1);
}
+ MLX5_SET(fte_match_set_misc, misc_m, geneve_tlv_option_0_exist, 1);
+ MLX5_SET(fte_match_set_misc, misc_v, geneve_tlv_option_0_exist, 1);
/* Set the data. */
if (geneve_opt_v->data) {
memcpy(&opt_data_key, geneve_opt_v->data,
--
2.27.0
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH] net/mlx5: update GENEVE TLV option exist bit
2021-05-31 11:45 [dpdk-dev] [PATCH] net/mlx5: update GENEVE TLV option exist bit Shiri Kuzin
@ 2021-06-06 11:32 ` Raslan Darawsheh
2021-06-24 8:55 ` Shiri Kuzin
0 siblings, 1 reply; 5+ messages in thread
From: Raslan Darawsheh @ 2021-06-06 11:32 UTC (permalink / raw)
To: Shiri Kuzin, dev; +Cc: Matan Azrad, Slava Ovsiienko, stable
Hi Shiri,
> -----Original Message-----
> From: Shiri Kuzin <shirik@nvidia.com>
> Sent: Monday, May 31, 2021 2:46 PM
> To: dev@dpdk.org
> Cc: Matan Azrad <matan@nvidia.com>; Raslan Darawsheh
> <rasland@nvidia.com>; Slava Ovsiienko <viacheslavo@nvidia.com>
> Subject: [PATCH] net/mlx5: update GENEVE TLV option exist bit
>
> The GENEVE TLV option matching is done using a flex parser.
>
> Recent update in firmware, requires that in order to match on the GENEVE
> TLV option the "geneve_tlv_option_0_exist" bit should be set.
>
> Add the new "geneve_tlv_option_0_exist" setting when translating the
> GENEVE TLV option item.
>
> Signed-off-by: Shiri Kuzin <shirik@nvidia.com>
> Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
> ---
This is a valid Patch for Stable, so I'll add it during integration
Cc:stable@dpdk.org
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] net/mlx5: update GENEVE TLV option exist bit
2021-06-06 11:32 ` Raslan Darawsheh
@ 2021-06-24 8:55 ` Shiri Kuzin
2021-06-24 11:20 ` Raslan Darawsheh
0 siblings, 1 reply; 5+ messages in thread
From: Shiri Kuzin @ 2021-06-24 8:55 UTC (permalink / raw)
To: Raslan Darawsheh, dev; +Cc: stable
This patch will be removed for now until FW support is fully done and be added when the support is completed.
Regards,
Shiri
> -----Original Message-----
> From: Raslan Darawsheh <rasland@nvidia.com>
> Sent: Sunday, June 6, 2021 2:32 PM
> To: Shiri Kuzin <shirik@nvidia.com>; dev@dpdk.org
> Cc: Matan Azrad <matan@nvidia.com>; Slava Ovsiienko
> <viacheslavo@nvidia.com>; stable@dpdk.org
> Subject: RE: [PATCH] net/mlx5: update GENEVE TLV option exist bit
>
> Hi Shiri,
>
> > -----Original Message-----
> > From: Shiri Kuzin <shirik@nvidia.com>
> > Sent: Monday, May 31, 2021 2:46 PM
> > To: dev@dpdk.org
> > Cc: Matan Azrad <matan@nvidia.com>; Raslan Darawsheh
> > <rasland@nvidia.com>; Slava Ovsiienko <viacheslavo@nvidia.com>
> > Subject: [PATCH] net/mlx5: update GENEVE TLV option exist bit
> >
> > The GENEVE TLV option matching is done using a flex parser.
> >
> > Recent update in firmware, requires that in order to match on the
> > GENEVE TLV option the "geneve_tlv_option_0_exist" bit should be set.
> >
> > Add the new "geneve_tlv_option_0_exist" setting when translating the
> > GENEVE TLV option item.
> >
> > Signed-off-by: Shiri Kuzin <shirik@nvidia.com>
> > Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
> > ---
>
> This is a valid Patch for Stable, so I'll add it during integration
> Cc:stable@dpdk.org
>
> Patch applied to next-net-mlx,
>
> Kindest regards,
> Raslan Darawsheh
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] net/mlx5: update GENEVE TLV option exist bit
2021-06-24 8:55 ` Shiri Kuzin
@ 2021-06-24 11:20 ` Raslan Darawsheh
2021-08-22 10:47 ` Raslan Darawsheh
0 siblings, 1 reply; 5+ messages in thread
From: Raslan Darawsheh @ 2021-06-24 11:20 UTC (permalink / raw)
To: Shiri Kuzin, dev; +Cc: stable
Ok dropping this patch from next-net-mlx,
Kindest regards,
Raslan Darawsheh
> -----Original Message-----
> From: Shiri Kuzin <shirik@nvidia.com>
> Sent: Thursday, June 24, 2021 11:55 AM
> To: Raslan Darawsheh <rasland@nvidia.com>; dev@dpdk.org
> Cc: stable@dpdk.org
> Subject: RE: [PATCH] net/mlx5: update GENEVE TLV option exist bit
>
> This patch will be removed for now until FW support is fully done and be
> added when the support is completed.
>
> Regards,
> Shiri
>
> > -----Original Message-----
> > From: Raslan Darawsheh <rasland@nvidia.com>
> > Sent: Sunday, June 6, 2021 2:32 PM
> > To: Shiri Kuzin <shirik@nvidia.com>; dev@dpdk.org
> > Cc: Matan Azrad <matan@nvidia.com>; Slava Ovsiienko
> > <viacheslavo@nvidia.com>; stable@dpdk.org
> > Subject: RE: [PATCH] net/mlx5: update GENEVE TLV option exist bit
> >
> > Hi Shiri,
> >
> > > -----Original Message-----
> > > From: Shiri Kuzin <shirik@nvidia.com>
> > > Sent: Monday, May 31, 2021 2:46 PM
> > > To: dev@dpdk.org
> > > Cc: Matan Azrad <matan@nvidia.com>; Raslan Darawsheh
> > > <rasland@nvidia.com>; Slava Ovsiienko <viacheslavo@nvidia.com>
> > > Subject: [PATCH] net/mlx5: update GENEVE TLV option exist bit
> > >
> > > The GENEVE TLV option matching is done using a flex parser.
> > >
> > > Recent update in firmware, requires that in order to match on the
> > > GENEVE TLV option the "geneve_tlv_option_0_exist" bit should be set.
> > >
> > > Add the new "geneve_tlv_option_0_exist" setting when translating the
> > > GENEVE TLV option item.
> > >
> > > Signed-off-by: Shiri Kuzin <shirik@nvidia.com>
> > > Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
> > > ---
> >
> > This is a valid Patch for Stable, so I'll add it during integration
> > Cc:stable@dpdk.org
> >
> > Patch applied to next-net-mlx,
> >
> > Kindest regards,
> > Raslan Darawsheh
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] net/mlx5: update GENEVE TLV option exist bit
2021-06-24 11:20 ` Raslan Darawsheh
@ 2021-08-22 10:47 ` Raslan Darawsheh
0 siblings, 0 replies; 5+ messages in thread
From: Raslan Darawsheh @ 2021-08-22 10:47 UTC (permalink / raw)
To: Shiri Kuzin, dev; +Cc: stable
Hi,
> -----Original Message-----
> From: Raslan Darawsheh
> Sent: Thursday, June 24, 2021 2:20 PM
> To: Shiri Kuzin <shirik@nvidia.com>; dev@dpdk.org
> Cc: stable@dpdk.org
> Subject: RE: [PATCH] net/mlx5: update GENEVE TLV option exist bit
>
> Ok dropping this patch from next-net-mlx,
>
> Kindest regards,
> Raslan Darawsheh
>
> > -----Original Message-----
> > From: Shiri Kuzin <shirik@nvidia.com>
> > Sent: Thursday, June 24, 2021 11:55 AM
> > To: Raslan Darawsheh <rasland@nvidia.com>; dev@dpdk.org
> > Cc: stable@dpdk.org
> > Subject: RE: [PATCH] net/mlx5: update GENEVE TLV option exist bit
> >
> > This patch will be removed for now until FW support is fully done and
> > be added when the support is completed.
> >
> > Regards,
> > Shiri
> >
> > > -----Original Message-----
> > > From: Raslan Darawsheh <rasland@nvidia.com>
> > > Sent: Sunday, June 6, 2021 2:32 PM
> > > To: Shiri Kuzin <shirik@nvidia.com>; dev@dpdk.org
> > > Cc: Matan Azrad <matan@nvidia.com>; Slava Ovsiienko
> > > <viacheslavo@nvidia.com>; stable@dpdk.org
> > > Subject: RE: [PATCH] net/mlx5: update GENEVE TLV option exist bit
> > >
> > > Hi Shiri,
> > >
> > > > -----Original Message-----
> > > > From: Shiri Kuzin <shirik@nvidia.com>
> > > > Sent: Monday, May 31, 2021 2:46 PM
> > > > To: dev@dpdk.org
> > > > Cc: Matan Azrad <matan@nvidia.com>; Raslan Darawsheh
> > > > <rasland@nvidia.com>; Slava Ovsiienko <viacheslavo@nvidia.com>
> > > > Subject: [PATCH] net/mlx5: update GENEVE TLV option exist bit
> > > >
> > > > The GENEVE TLV option matching is done using a flex parser.
> > > >
> > > > Recent update in firmware, requires that in order to match on the
> > > > GENEVE TLV option the "geneve_tlv_option_0_exist" bit should be set.
> > > >
> > > > Add the new "geneve_tlv_option_0_exist" setting when translating
> > > > the GENEVE TLV option item.
> > > >
> > > > Signed-off-by: Shiri Kuzin <shirik@nvidia.com>
> > > > Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
> > > > ---
> > >
> > > This is a valid Patch for Stable, so I'll add it during integration
> > > Cc:stable@dpdk.org
> > >
> > > Patch applied to next-net-mlx,
> > >
> > > Kindest regards,
> > > Raslan Darawsheh
FW has prober fix for it,
So applying the patch again to next-net-mlx,
Kindest regards,
Raslan Darawsheh
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-08-22 10:48 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-31 11:45 [dpdk-dev] [PATCH] net/mlx5: update GENEVE TLV option exist bit Shiri Kuzin
2021-06-06 11:32 ` Raslan Darawsheh
2021-06-24 8:55 ` Shiri Kuzin
2021-06-24 11:20 ` Raslan Darawsheh
2021-08-22 10:47 ` Raslan Darawsheh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).