RE: [PATCH] net: fix return type of IPv6 L4 packet checksum

[Bing Zhao <bingz@nvidia.com>]

Hi Elena,

Maybe it is better to add a fixline here.

BR. Bing

> -----Original Message-----
> From: eagostini@nvidia.com <eagostini@nvidia.com>
> Sent: Thursday, April 6, 2023 5:21 PM
> To: dev@dpdk.org
> Cc: statble@dpdk.org; Elena Agostini <eagostini@nvidia.com>
> Subject: [PATCH] net: fix return type of IPv6 L4 packet checksum
> 
> External email: Use caution opening links or attachments
> 
> 
> From: Elena Agostini <eagostini@nvidia.com>
> 
> Function returns 0 or -1 but the return type is uint16_t.
> 
> Signed-off-by: Elena Agostini <eagostini@nvidia.com>
> ---
>  lib/net/rte_ip.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/net/rte_ip.h b/lib/net/rte_ip.h index a310e9d498..e7106256aa
> 100644
> --- a/lib/net/rte_ip.h
> +++ b/lib/net/rte_ip.h
> @@ -514,7 +514,7 @@ rte_ipv4_udptcp_cksum_verify(const struct
> rte_ipv4_hdr *ipv4_hdr,
>   *   Return 0 if the checksum is correct, else -1.
>   */
>  __rte_experimental
> -static inline uint16_t
> +static inline int
>  rte_ipv4_udptcp_cksum_mbuf_verify(const struct rte_mbuf *m,
>                                   const struct rte_ipv4_hdr *ipv4_hdr,
>                                   uint16_t l4_off)
> --
> 2.34.1