From: Raslan Darawsheh <rasland@nvidia.com>
To: Dmitry Kozlyuk <dkozlyuk@nvidia.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: Matan Azrad <matan@nvidia.com>, Ori Kam <orika@nvidia.com>,
"Xueming(Steven) Li" <xuemingl@nvidia.com>,
Slava Ovsiienko <viacheslavo@nvidia.com>
Subject: RE: [PATCH] net/mlx5: fix keeping indirect RSS non-isolated mode
Date: Tue, 16 Nov 2021 13:06:24 +0000 [thread overview]
Message-ID: <DM4PR12MB5312B6DF2DC1E73ABFEB3BDECF999@DM4PR12MB5312.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20211116073834.2413952-1-dkozlyuk@nvidia.com>
Hi,
> -----Original Message-----
> From: Dmitry Kozlyuk <dkozlyuk@nvidia.com>
> Sent: Tuesday, November 16, 2021 9:39 AM
> To: dev@dpdk.org
> Cc: Matan Azrad <matan@nvidia.com>; Ori Kam <orika@nvidia.com>; Raslan
> Darawsheh <rasland@nvidia.com>; Xueming(Steven) Li
> <xuemingl@nvidia.com>; Slava Ovsiienko <viacheslavo@nvidia.com>
> Subject: [PATCH] net/mlx5: fix keeping indirect RSS non-isolated mode
>
> When a port starts in non-isolated mode,
> an internal indirect RSS is created that includes all configured queues
> and a flow rule is created that references this indirect RSS.
> If before switching to non-isolated mode an indirect RSS was created
> that includes the same set of queues, it would be reused at this point.
> However, because the port had been stopped (or not yet started),
> the TIR for this indirect RSS had been destroyed (or not yet created).
> The flow rule could not be created and the port start failed.
>
> Creation of TIRs is moved before configuring non-isolated mode flows,
> but it is not enough because of the following issue.
>
> Commit 0cedf34da78f ("net/mlx5: move Rx queue reference count")
> changed mlx5_rxq_get() not to increment RxQ control structure
> reference count, mlx5_rxq_ref() was introduced for this purpose.
> mlx5_ind_table_obj_attach() was not updated to use the new function,
> so when the port was stopped, the control structure reference count
> of an RxQ used in RSS reached zero and the structure was destroyed.
>
> Use mlx5_rxq_ref() to keep RxQ control structure
> needed for indirect RSS persistence across port restart.
>
> Fixes: ec4e11d41d12 ("net/mlx5: preserve indirect actions on restart")
> Fixes: 0cedf34da78f ("net/mlx5: move Rx queue reference count")
> Cc: xuemingl@nvidia.com
>
> Signed-off-by: Dmitry Kozlyuk <dkozlyuk@nvidia.com>
> Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
prev parent reply other threads:[~2021-11-16 13:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-16 7:38 Dmitry Kozlyuk
2021-11-16 13:06 ` Raslan Darawsheh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM4PR12MB5312B6DF2DC1E73ABFEB3BDECF999@DM4PR12MB5312.namprd12.prod.outlook.com \
--to=rasland@nvidia.com \
--cc=dev@dpdk.org \
--cc=dkozlyuk@nvidia.com \
--cc=matan@nvidia.com \
--cc=orika@nvidia.com \
--cc=viacheslavo@nvidia.com \
--cc=xuemingl@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).