* 22.11.4 patches review and test
@ 2023-12-20 7:19 Xueming Li
2023-12-27 8:17 ` YangHang Liu
` (2 more replies)
0 siblings, 3 replies; 10+ messages in thread
From: Xueming Li @ 2023-12-20 7:19 UTC (permalink / raw)
To: stable
Cc: xuemingl, dev, Abhishek Marathe, Ali Alnubani, benjamin.walker,
David Christensen, Hemant Agrawal, Ian Stokes, Jerin Jacob,
John McNamara, Ju-Hyoung Lee, Kevin Traynor, Luca Boccassi,
Pei Zhang, qian.q.xu, Raslan Darawsheh, Thomas Monjalon,
Yanghang Liu, yuan.peng, zhaoyan.chen
Hi all,
Here is a list of patches targeted for stable release 22.11.4.
The planned date for the final release is 5th January.
Please help with testing and validation of your use cases and report
any issues/results with reply-all to this mail. For the final release
the fixes and reported validations will be added to the release notes.
A release candidate tarball can be found at:
https://dpdk.org/browse/dpdk-stable/tag/?id=v22.11.4-rc3
These patches are located at branch 22.11 of dpdk-stable repo:
https://dpdk.org/browse/dpdk-stable/
Thanks.
Xueming Li <xuemingl@nvidia.com>
---
Aakash Sasidharan (2):
event/cnxk: fix return values for capability API
test/event: fix crypto null device creation
Abdullah Sevincer (3):
bus/pci: add PASID control
event/dlb2: disable PASID
event/dlb2: fix disable PASID
Akhil Goyal (2):
common/cnxk: fix different size bit operations
net/cnxk: fix uninitialized variable
Alex Vesker (1):
net/mlx5/hws: fix field copy bind
Alexander Kozyrev (3):
net/mlx5/hws: fix integrity bits level
net/mlx5: fix MPRQ stride size check
ethdev: fix ESP packet type description
Amit Prakash Shukla (4):
common/cnxk: fix DPI memzone name
dma/cnxk: fix device state
dma/cnxk: fix device reconfigure
dma/cnxk: fix chunk buffer failure return code
Anatoly Burakov (1):
test: fix named test macro
Anoob Joseph (2):
cryptodev: add missing doc for security context
doc: replace code blocks with includes in security guide
Artemy Kovalyov (1):
mem: fix deadlock with multiprocess
Ashwin Sekhar T K (2):
mempool/cnxk: fix alloc from non-EAL threads
common/cnxk: fix aura disable handling
Beilei Xing (1):
net/i40e: fix FDIR queue receives broadcast packets
Bing Zhao (3):
net/mlx5: fix flow workspace double free in Windows
net/mlx5: fix shared Rx queue list management
net/mlx5: fix LACP redirection in Rx domain
Brian Dooley (4):
test/crypto: fix IV in some vectors
test/crypto: skip some synchronous tests with CPU crypto
doc: update kernel module entry in QAT guide
examples/ipsec-secgw: fix partial overflow
Bruce Richardson (8):
crypto/ipsec_mb: add dependency check for cross build
event/sw: remove obsolete comment
net/i40e: fix buffer leak on Rx reconfiguration
eventdev: fix device pointer for vdev-based devices
eventdev: fix missing driver names in info struct
ethdev: fix function name in comment
event/dlb2: fix name check in self-test
event/dlb2: fix missing queue ordering capability flag
Chaoyong He (5):
net/nfp: fix crash on close
net/nfp: fix reconfigure logic in PF initialization
net/nfp: fix reconfigure logic in VF initialization
net/nfp: fix link status interrupt
net/nfp: fix reconfigure logic of set MAC address
Chengwen Feng (2):
net/hns3: fix traffic management thread safety
net/hns3: fix traffic management dump text alignment
Christian Ehrhardt (1):
config: fix RISC-V native build
Ciara Power (2):
crypto/qat: fix raw API null algorithm digest
crypto/openssl: fix memory leaks in asym session
Dariusz Sosnowski (8):
net/mlx5: fix jump ipool entry size
net/mlx5: fix flow thread safety flag for HWS
common/mlx5: fix controller index parsing
net/mlx5: fix missing flow rules for external SQ
net/mlx5: fix use after free on Rx queue start
net/mlx5: fix hairpin queue unbind
net/mlx5: fix hairpin queue states
net/mlx5: fix offset size in conntrack flow action
David Christensen (1):
net/tap: use MAC address parse API instead of local parser
David Marchand (22):
ci: fix race on container image name
mempool: fix default ops for an empty mempool
crypto/dpaa2_sec: fix debug prints
crypto/dpaa_sec: fix debug prints
eventdev: fix symbol export for port maintenance
common/cnxk: remove dead Meson code
app/bbdev: fix link with NXP LA12XX
net/iavf: fix checksum offloading
net/iavf: fix Tx debug
net/iavf: remove log from Tx prepare function
net/iavf: fix TSO with big segments
net/ice: remove log from Tx prepare function
net/ice: fix TSO with big segments
net/mlx5: fix leak in sysfs port name translation
net/bonding: fix link status callback stop
bus/ifpga: fix driver header dependency
net/tap: fix L4 checksum offloading
net/tap: fix IPv4 checksum offloading
net/iavf: fix indent in Tx path
doc: remove restriction on ixgbe vector support
doc: fix some ordered lists
doc: remove number of commands in vDPA guide
Dengdui Huang (14):
net/hns3: fix VF default MAC modified when set failed
net/hns3: fix error code for multicast resource
net/hns3: fix flushing multicast MAC address
app/testpmd: fix help string
net/hns3: fix unchecked Rx free threshold
net/hns3: fix double stats for IMP and global reset
net/hns3: remove reset log in secondary
net/hns3: fix multiple reset detected log
net/hns3: fix IMP or global reset
net/hns3: refactor interrupt state query
net/hns3: fix mailbox sync
net/hns3: fix ignored reset event
net/hns3: fix reset event status
net/hns3: fix VF reset handler interruption
Ed Czeck (1):
net/ark: support single function with multiple port
Eli Britstein (1):
net/mlx5: zero UDP checksum over IPv4 in encapsulation
Feifei Wang (1):
app/pipeline: add sigint handler
Fengjiang Liu (1):
net/virtio: fix missing next flag in Tx packed ring
Ferruh Yigit (3):
net/txgbe: fix out of bound access
mempool: fix get function documentation
mempool: clarify enqueue/dequeue ops documentation
Gagandeep Singh (1):
bus/dpaa: fix build with asserts for GCC 13
Ganapati Kundapura (1):
eventdev/crypto: fix circular buffer full case
Gregory Etelson (1):
eal/windows: fix build with recent MinGW
Harman Kalra (1):
mempool/cnxk: fix free from non-EAL threads
Harry van Haaren (1):
event/sw: fix ordering corruption with op release
Hemant Agrawal (1):
test/crypto: fix return value for GMAC case
Hernan Vargas (3):
baseband/acc: fix ACC100 HARQ input alignment
test/bbdev: fix Python script subprocess
test/bbdev: assert failed test for queue configure
Huisong Li (11):
net/hns3: fix order in NEON Rx
net/hns3: fix setting DCB capability
net/hns3: fix LRO offload to report
app/testpmd: remove useless check in TSO command
app/testpmd: fix tunnel TSO capability check
app/testpmd: add explicit check for tunnel TSO
app/testpmd: fix tunnel TSO configuration
doc: fix hns3 build option about max queue number
doc: update features in hns3 guide
doc: fix RSS flow description in hns3 guide
examples/ethtool: fix pause configuration
Ivan Malov (1):
net/sfc: add missing error code indication to MAE init path
Jerin Jacob (1):
common/cnxk: replace direct API usage in REE
Jiawei Wang (3):
net/mlx5: fix decap action checking in sample flow
net/mlx5: fix E-Switch mirror flow rule validation
net/mlx5: fix validation of sample encap flow action
Jiawen Wu (12):
net/txgbe: add Tx queue maximum limit
net/txgbe: fix GRE tunnel packet checksum
net/ngbe: fix flow control
net/ngbe: prevent NIC from slowing down link speed
net/txgbe: reconfigure MAC Rx when link update
net/ngbe: reconfigure MAC Rx when link update
net/txgbe: keep link down after device close
net/ngbe: keep link down after device close
net/txgbe: check process type in close operation
net/ngbe: check process type in close operation
net/txgbe: add proper memory barriers in Rx
net/ngbe: add proper memory barriers in Rx
Jie Hai (41):
net/af_packet: fix Rx and Tx queue state
net/af_xdp: fix Rx and Tx queue state
net/avp: fix Rx and Tx queue state
net/bnx2x: fix Rx and Tx queue state
net/bnxt: fix Rx and Tx queue state
net/bonding: fix Rx and Tx queue state
net/cxgbe: fix Rx and Tx queue state
net/dpaa: fix Rx and Tx queue state
net/dpaa2: fix Rx and Tx queue state
net/e1000: fix Rx and Tx queue state
net/ena: fix Rx and Tx queue state
net/enetc: fix Rx and Tx queue state
net/enic: fix Rx and Tx queue state
net/hinic: fix Rx and Tx queue state
net/ipn3ke: fix Rx and Tx queue state
net/memif: fix Rx and Tx queue state
net/mlx4: fix Rx and Tx queue state
net/mvneta: fix Rx and Tx queue state
net/mvpp2: fix Rx and Tx queue state
net/nfp: fix Rx and Tx queue state
net/ngbe: fix Rx and Tx queue state
net/null: fix Rx and Tx queue state
net/octeon_ep: fix Rx and Tx queue state
net/octeontx: fix Rx and Tx queue state
net/pfe: fix Rx and Tx queue state
net/ring: fix Rx and Tx queue state
net/sfc: fix Rx and Tx queue state
net/softnic: fix Rx and Tx queue state
net/txgbe: fix Rx and Tx queue state
net/vhost: fix Rx and Tx queue state
net/virtio: fix Rx and Tx queue state
net/vmxnet3: fix Rx and Tx queue state
app/testpmd: fix primary process not polling all queues
net/hns3: fix typo in function name
net/hns3: fix some return values
net/hns3: fix some error logs
net/hns3: keep set/get algo key functions local
net/hns3: fix uninitialized hash algo value
app/procinfo: fix RSS info
app/procinfo: adjust format of RSS info
test/bonding: fix uninitialized RSS configuration
Jieqiang Wang (1):
hash: align SSE lookup to scalar implementation
Joshua Washington (4):
net/gve: fix max MTU limit
net/gve: update max Rx packet length to be based on MTU
ethdev: account for smaller MTU when setting default
net/gve: fix RX buffer size alignment
Juraj Linkeš (1):
config/arm: fix aarch32 build with GCC 13
Kaiwen Deng (1):
net/ice: fix TM configuration clearing
Kevin Traynor (1):
doc: update versions recommendations for i40e and ice
Kiran Kumar K (1):
common/cnxk: fix RSS key configuration
Kommula Shiva Shankar (1):
common/cnxk: fix pool buffer size in opaque mode
Levend Sayar (1):
gpu/cuda: fix build with external GDRCopy
Long Li (2):
net/netvsc: increase VSP response timeout to 60 seconds
net/mana: add missing new line to data path logs
Long Wu (4):
net/nfp: fix control message packets
test/bonding: remove unreachable statement
test/bonding: add missing check
net/bonding: fix possible overrun
Madhuker Mythri (1):
net/tap: fix RSS for fragmented packets
Martin Weiser (1):
net/ice: write timestamp to first segment in scattered Rx
Maxime Coquelin (6):
vhost: fix missing vring call check on virtqueue access
vhost: fix missing check on virtqueue access
vhost: fix check on virtqueue access in async registration
vhost: fix check on virtqueue access in in-flight getter
vhost: fix missing lock protection in power monitor API
vhost: fix checking virtqueue access in stats API
Min Zhou (1):
test/hash: fix creation error log
Mingjin Ye (1):
net/ice: fix crash on closing representor ports
Nagadheeraj Rottela (1):
crypto/nitrox: fix panic with high number of segments
Nicolas Chautru (1):
baseband/acc: fix TB mode on VRB1
Nithin Dabilpuram (1):
net/cnxk: fix data offset in vector Tx
Ori Kam (1):
net/mlx5: fix NIC flow capability query
Pavan Nikhilesh (4):
event/cnxk: fix getwork mode devargs parsing
event/cnxk: fix CASP usage for clang
event/cnxk: fix context flush in port cleanup
common/cnxk: fix incorrect aura ID
Qi Zhang (2):
net/iavf: fix Tx preparation
net/ice: fix Tx preparation
Qiming Yang (2):
bus/pci: fix device ID log
net/ice: fix initial link status
Radu Nicolau (3):
net/iavf: fix ESN session update
net/iavf: fix Tx offload mask
net/iavf: fix Tx offload flags check
Rahul Bhansali (2):
test/security: fix IPv6 next header field
eventdev/eth_rx: fix timestamp field register in mbuf
Rakesh Kudurumalla (1):
common/cnxk: fix xstats for different packet sizes
Robin Jarry (1):
usertools/pmdinfo: fix usage typos
Ruifeng Wang (1):
ethdev: fix 32-bit build with GCC 13
Satheesh Paul (2):
common/cnxk: fix default flow action setting
common/cnxk: fix SDP channel mask
Saurabh Singhal (1):
net/iavf: unregister interrupt handler before FD close
Selwin Sebastian (1):
net/axgbe: identify CPU with cpuid
Shihong Wang (1):
net/nfp: fix DMA error after abnormal exit
Sivaprasad Tummala (1):
eventdev: fix alignment padding
Sivaramakrishnan Venkat (1):
test/crypto: fix typo in asym tests
Srikanth Yalavarthi (2):
eal/unix: fix firmware reading with external xz helper
build: add libarchive to optional external dependencies
Stephen Hemminger (9):
app/test: fix reference to master in bonding test
random: initialize state for unregistered non-EAL threads
common/mlx5: replace use of PMD log type
app/procinfo: remove unnecessary rte_malloc
app/testpmd: fix early exit from signal
app/dumpcap: fix mbuf pool ring type
meter: fix RFC4115 trTCM API Doxygen
pdump: fix error number on IPC response
app/dumpcap: allow multiple invocations
Suanming Mou (3):
ethdev: add check in async flow action query
net/mlx5: fix counter query during port close
net/mlx5: fix destroying external representor flow
Tejasree Kondoj (1):
crypto/cnxk: fix IPsec CCM and GCM capabilities
Timothy Miskell (1):
net/ice: fix L1 check interval
Tomasz Duszynski (1):
rawdev: fix device class in log message
Tyler Retzlaff (2):
malloc: remove return from void functions
eal/riscv: fix vector type alignment
Viacheslav Galaktionov (2):
net/sfc: set max Rx packet length for representors
net/sfc: account for data offset on Tx
Viacheslav Ovsiienko (1):
net/mlx5: fix multi-segment Tx inline data length
Visa Hankala (1):
net/bonding: fix header for C++
Vladimir Medvedkin (2):
fib: fix adding default route overwriting entire table
fib6: fix adding default route as first route
Wei Hu (2):
net/mana: enable 32-bit build
net/mana: add 32-bit short doorbell
Weiguo Li (3):
net/enic: avoid extra unlock in MTU set
net/sfc: remove null dereference in log
net/mlx5: fix unlock mismatch
Wenjing Qiao (1):
net/iavf: fix VLAN offload strip flag
Wenwu Ma (1):
net/virtio: fix link state interrupt vector setting
Xueming Li (2):
Revert "eventdev: fix alignment padding"
app/test: disable graph auto test for windows
Yajun Wu (1):
vdpa/mlx5: fix unregister kick handler order
Yiding Zhou (1):
net/iavf: fix port stats clearing
Zerun Fu (1):
net/nfp: fix initialization of physical representors
Zhichao Zeng (1):
net/ice: fix DCF port statistics
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: 22.11.4 patches review and test
2023-12-20 7:19 22.11.4 patches review and test Xueming Li
@ 2023-12-27 8:17 ` YangHang Liu
2023-12-27 8:26 ` Xueming(Steven) Li
2024-01-03 14:41 ` Ali Alnubani
2024-01-11 1:42 ` Xu, HailinX
2 siblings, 1 reply; 10+ messages in thread
From: YangHang Liu @ 2023-12-27 8:17 UTC (permalink / raw)
To: Xueming Li
Cc: stable, dev, Abhishek Marathe, Ali Alnubani, benjamin.walker,
David Christensen, Hemant Agrawal, Ian Stokes, Jerin Jacob,
John McNamara, Ju-Hyoung Lee, Kevin Traynor, Luca Boccassi,
Pei Zhang, qian.q.xu, Raslan Darawsheh, Thomas Monjalon,
yuan.peng, zhaoyan.chen, Chao Yang
[-- Attachment #1: Type: text/plain, Size: 18044 bytes --]
I tested below 18 scenarios on RHEL9 and didn't find any new dpdk issues.
Guest with device assignment(PF) throughput testing(1G hugepage size): PASS
Guest with device assignment(PF) throughput testing(2M hugepage size) : PASS
Guest with device assignment(VF) throughput testing: PASS
PVP (host dpdk testpmd as vswitch) 1Q: throughput testing: PASS
PVP vhost-user 4Q throughput testing: PASS
PVP vhost-user 2Q throughput testing: PASS
PVP vhost-user 1Q - cross numa node throughput testing: PASS
Guest with vhost-user 2 queues throughput testing: PASS
vhost-user reconnect with dpdk-client, qemu-server qemu reconnect: PASS
vhost-user reconnect with dpdk-client, qemu-server ovs reconnect: PASS
PVP 1Q live migration testing: PASS
PVP 1Q cross numa node live migration testing: PASS
Guest with ovs+dpdk+vhost-user 1Q live migration testing: PASS
Guest with ovs+dpdk+vhost-user 1Q live migration testing (2M): PASS
Guest with ovs+dpdk+vhost-user 2Q live migration testing: PASS
Guest with ovs+dpdk+vhost-user 4Q live migration testing: PASS
Host PF + DPDK testing: PASS
Host VF + DPDK testing: PASS
Test Versions:
qemu-kvm-7.2.0
kernel 5.14
# git describe
v22.11.4-rc3
Test device : X540-AT2 NIC(ixgbe, 10G)
Best Regards,
YangHang Liu
On Wed, Dec 20, 2023 at 3:19 PM Xueming Li <xuemingl@nvidia.com> wrote:
> Hi all,
>
> Here is a list of patches targeted for stable release 22.11.4.
>
> The planned date for the final release is 5th January.
>
> Please help with testing and validation of your use cases and report
> any issues/results with reply-all to this mail. For the final release
> the fixes and reported validations will be added to the release notes.
>
> A release candidate tarball can be found at:
>
> https://dpdk.org/browse/dpdk-stable/tag/?id=v22.11.4-rc3
>
> These patches are located at branch 22.11 of dpdk-stable repo:
> https://dpdk.org/browse/dpdk-stable/
>
> Thanks.
>
> Xueming Li <xuemingl@nvidia.com>
>
> ---
> Aakash Sasidharan (2):
> event/cnxk: fix return values for capability API
> test/event: fix crypto null device creation
>
> Abdullah Sevincer (3):
> bus/pci: add PASID control
> event/dlb2: disable PASID
> event/dlb2: fix disable PASID
>
> Akhil Goyal (2):
> common/cnxk: fix different size bit operations
> net/cnxk: fix uninitialized variable
>
> Alex Vesker (1):
> net/mlx5/hws: fix field copy bind
>
> Alexander Kozyrev (3):
> net/mlx5/hws: fix integrity bits level
> net/mlx5: fix MPRQ stride size check
> ethdev: fix ESP packet type description
>
> Amit Prakash Shukla (4):
> common/cnxk: fix DPI memzone name
> dma/cnxk: fix device state
> dma/cnxk: fix device reconfigure
> dma/cnxk: fix chunk buffer failure return code
>
> Anatoly Burakov (1):
> test: fix named test macro
>
> Anoob Joseph (2):
> cryptodev: add missing doc for security context
> doc: replace code blocks with includes in security guide
>
> Artemy Kovalyov (1):
> mem: fix deadlock with multiprocess
>
> Ashwin Sekhar T K (2):
> mempool/cnxk: fix alloc from non-EAL threads
> common/cnxk: fix aura disable handling
>
> Beilei Xing (1):
> net/i40e: fix FDIR queue receives broadcast packets
>
> Bing Zhao (3):
> net/mlx5: fix flow workspace double free in Windows
> net/mlx5: fix shared Rx queue list management
> net/mlx5: fix LACP redirection in Rx domain
>
> Brian Dooley (4):
> test/crypto: fix IV in some vectors
> test/crypto: skip some synchronous tests with CPU crypto
> doc: update kernel module entry in QAT guide
> examples/ipsec-secgw: fix partial overflow
>
> Bruce Richardson (8):
> crypto/ipsec_mb: add dependency check for cross build
> event/sw: remove obsolete comment
> net/i40e: fix buffer leak on Rx reconfiguration
> eventdev: fix device pointer for vdev-based devices
> eventdev: fix missing driver names in info struct
> ethdev: fix function name in comment
> event/dlb2: fix name check in self-test
> event/dlb2: fix missing queue ordering capability flag
>
> Chaoyong He (5):
> net/nfp: fix crash on close
> net/nfp: fix reconfigure logic in PF initialization
> net/nfp: fix reconfigure logic in VF initialization
> net/nfp: fix link status interrupt
> net/nfp: fix reconfigure logic of set MAC address
>
> Chengwen Feng (2):
> net/hns3: fix traffic management thread safety
> net/hns3: fix traffic management dump text alignment
>
> Christian Ehrhardt (1):
> config: fix RISC-V native build
>
> Ciara Power (2):
> crypto/qat: fix raw API null algorithm digest
> crypto/openssl: fix memory leaks in asym session
>
> Dariusz Sosnowski (8):
> net/mlx5: fix jump ipool entry size
> net/mlx5: fix flow thread safety flag for HWS
> common/mlx5: fix controller index parsing
> net/mlx5: fix missing flow rules for external SQ
> net/mlx5: fix use after free on Rx queue start
> net/mlx5: fix hairpin queue unbind
> net/mlx5: fix hairpin queue states
> net/mlx5: fix offset size in conntrack flow action
>
> David Christensen (1):
> net/tap: use MAC address parse API instead of local parser
>
> David Marchand (22):
> ci: fix race on container image name
> mempool: fix default ops for an empty mempool
> crypto/dpaa2_sec: fix debug prints
> crypto/dpaa_sec: fix debug prints
> eventdev: fix symbol export for port maintenance
> common/cnxk: remove dead Meson code
> app/bbdev: fix link with NXP LA12XX
> net/iavf: fix checksum offloading
> net/iavf: fix Tx debug
> net/iavf: remove log from Tx prepare function
> net/iavf: fix TSO with big segments
> net/ice: remove log from Tx prepare function
> net/ice: fix TSO with big segments
> net/mlx5: fix leak in sysfs port name translation
> net/bonding: fix link status callback stop
> bus/ifpga: fix driver header dependency
> net/tap: fix L4 checksum offloading
> net/tap: fix IPv4 checksum offloading
> net/iavf: fix indent in Tx path
> doc: remove restriction on ixgbe vector support
> doc: fix some ordered lists
> doc: remove number of commands in vDPA guide
>
> Dengdui Huang (14):
> net/hns3: fix VF default MAC modified when set failed
> net/hns3: fix error code for multicast resource
> net/hns3: fix flushing multicast MAC address
> app/testpmd: fix help string
> net/hns3: fix unchecked Rx free threshold
> net/hns3: fix double stats for IMP and global reset
> net/hns3: remove reset log in secondary
> net/hns3: fix multiple reset detected log
> net/hns3: fix IMP or global reset
> net/hns3: refactor interrupt state query
> net/hns3: fix mailbox sync
> net/hns3: fix ignored reset event
> net/hns3: fix reset event status
> net/hns3: fix VF reset handler interruption
>
> Ed Czeck (1):
> net/ark: support single function with multiple port
>
> Eli Britstein (1):
> net/mlx5: zero UDP checksum over IPv4 in encapsulation
>
> Feifei Wang (1):
> app/pipeline: add sigint handler
>
> Fengjiang Liu (1):
> net/virtio: fix missing next flag in Tx packed ring
>
> Ferruh Yigit (3):
> net/txgbe: fix out of bound access
> mempool: fix get function documentation
> mempool: clarify enqueue/dequeue ops documentation
>
> Gagandeep Singh (1):
> bus/dpaa: fix build with asserts for GCC 13
>
> Ganapati Kundapura (1):
> eventdev/crypto: fix circular buffer full case
>
> Gregory Etelson (1):
> eal/windows: fix build with recent MinGW
>
> Harman Kalra (1):
> mempool/cnxk: fix free from non-EAL threads
>
> Harry van Haaren (1):
> event/sw: fix ordering corruption with op release
>
> Hemant Agrawal (1):
> test/crypto: fix return value for GMAC case
>
> Hernan Vargas (3):
> baseband/acc: fix ACC100 HARQ input alignment
> test/bbdev: fix Python script subprocess
> test/bbdev: assert failed test for queue configure
>
> Huisong Li (11):
> net/hns3: fix order in NEON Rx
> net/hns3: fix setting DCB capability
> net/hns3: fix LRO offload to report
> app/testpmd: remove useless check in TSO command
> app/testpmd: fix tunnel TSO capability check
> app/testpmd: add explicit check for tunnel TSO
> app/testpmd: fix tunnel TSO configuration
> doc: fix hns3 build option about max queue number
> doc: update features in hns3 guide
> doc: fix RSS flow description in hns3 guide
> examples/ethtool: fix pause configuration
>
> Ivan Malov (1):
> net/sfc: add missing error code indication to MAE init path
>
> Jerin Jacob (1):
> common/cnxk: replace direct API usage in REE
>
> Jiawei Wang (3):
> net/mlx5: fix decap action checking in sample flow
> net/mlx5: fix E-Switch mirror flow rule validation
> net/mlx5: fix validation of sample encap flow action
>
> Jiawen Wu (12):
> net/txgbe: add Tx queue maximum limit
> net/txgbe: fix GRE tunnel packet checksum
> net/ngbe: fix flow control
> net/ngbe: prevent NIC from slowing down link speed
> net/txgbe: reconfigure MAC Rx when link update
> net/ngbe: reconfigure MAC Rx when link update
> net/txgbe: keep link down after device close
> net/ngbe: keep link down after device close
> net/txgbe: check process type in close operation
> net/ngbe: check process type in close operation
> net/txgbe: add proper memory barriers in Rx
> net/ngbe: add proper memory barriers in Rx
>
> Jie Hai (41):
> net/af_packet: fix Rx and Tx queue state
> net/af_xdp: fix Rx and Tx queue state
> net/avp: fix Rx and Tx queue state
> net/bnx2x: fix Rx and Tx queue state
> net/bnxt: fix Rx and Tx queue state
> net/bonding: fix Rx and Tx queue state
> net/cxgbe: fix Rx and Tx queue state
> net/dpaa: fix Rx and Tx queue state
> net/dpaa2: fix Rx and Tx queue state
> net/e1000: fix Rx and Tx queue state
> net/ena: fix Rx and Tx queue state
> net/enetc: fix Rx and Tx queue state
> net/enic: fix Rx and Tx queue state
> net/hinic: fix Rx and Tx queue state
> net/ipn3ke: fix Rx and Tx queue state
> net/memif: fix Rx and Tx queue state
> net/mlx4: fix Rx and Tx queue state
> net/mvneta: fix Rx and Tx queue state
> net/mvpp2: fix Rx and Tx queue state
> net/nfp: fix Rx and Tx queue state
> net/ngbe: fix Rx and Tx queue state
> net/null: fix Rx and Tx queue state
> net/octeon_ep: fix Rx and Tx queue state
> net/octeontx: fix Rx and Tx queue state
> net/pfe: fix Rx and Tx queue state
> net/ring: fix Rx and Tx queue state
> net/sfc: fix Rx and Tx queue state
> net/softnic: fix Rx and Tx queue state
> net/txgbe: fix Rx and Tx queue state
> net/vhost: fix Rx and Tx queue state
> net/virtio: fix Rx and Tx queue state
> net/vmxnet3: fix Rx and Tx queue state
> app/testpmd: fix primary process not polling all queues
> net/hns3: fix typo in function name
> net/hns3: fix some return values
> net/hns3: fix some error logs
> net/hns3: keep set/get algo key functions local
> net/hns3: fix uninitialized hash algo value
> app/procinfo: fix RSS info
> app/procinfo: adjust format of RSS info
> test/bonding: fix uninitialized RSS configuration
>
> Jieqiang Wang (1):
> hash: align SSE lookup to scalar implementation
>
> Joshua Washington (4):
> net/gve: fix max MTU limit
> net/gve: update max Rx packet length to be based on MTU
> ethdev: account for smaller MTU when setting default
> net/gve: fix RX buffer size alignment
>
> Juraj Linkeš (1):
> config/arm: fix aarch32 build with GCC 13
>
> Kaiwen Deng (1):
> net/ice: fix TM configuration clearing
>
> Kevin Traynor (1):
> doc: update versions recommendations for i40e and ice
>
> Kiran Kumar K (1):
> common/cnxk: fix RSS key configuration
>
> Kommula Shiva Shankar (1):
> common/cnxk: fix pool buffer size in opaque mode
>
> Levend Sayar (1):
> gpu/cuda: fix build with external GDRCopy
>
> Long Li (2):
> net/netvsc: increase VSP response timeout to 60 seconds
> net/mana: add missing new line to data path logs
>
> Long Wu (4):
> net/nfp: fix control message packets
> test/bonding: remove unreachable statement
> test/bonding: add missing check
> net/bonding: fix possible overrun
>
> Madhuker Mythri (1):
> net/tap: fix RSS for fragmented packets
>
> Martin Weiser (1):
> net/ice: write timestamp to first segment in scattered Rx
>
> Maxime Coquelin (6):
> vhost: fix missing vring call check on virtqueue access
> vhost: fix missing check on virtqueue access
> vhost: fix check on virtqueue access in async registration
> vhost: fix check on virtqueue access in in-flight getter
> vhost: fix missing lock protection in power monitor API
> vhost: fix checking virtqueue access in stats API
>
> Min Zhou (1):
> test/hash: fix creation error log
>
> Mingjin Ye (1):
> net/ice: fix crash on closing representor ports
>
> Nagadheeraj Rottela (1):
> crypto/nitrox: fix panic with high number of segments
>
> Nicolas Chautru (1):
> baseband/acc: fix TB mode on VRB1
>
> Nithin Dabilpuram (1):
> net/cnxk: fix data offset in vector Tx
>
> Ori Kam (1):
> net/mlx5: fix NIC flow capability query
>
> Pavan Nikhilesh (4):
> event/cnxk: fix getwork mode devargs parsing
> event/cnxk: fix CASP usage for clang
> event/cnxk: fix context flush in port cleanup
> common/cnxk: fix incorrect aura ID
>
> Qi Zhang (2):
> net/iavf: fix Tx preparation
> net/ice: fix Tx preparation
>
> Qiming Yang (2):
> bus/pci: fix device ID log
> net/ice: fix initial link status
>
> Radu Nicolau (3):
> net/iavf: fix ESN session update
> net/iavf: fix Tx offload mask
> net/iavf: fix Tx offload flags check
>
> Rahul Bhansali (2):
> test/security: fix IPv6 next header field
> eventdev/eth_rx: fix timestamp field register in mbuf
>
> Rakesh Kudurumalla (1):
> common/cnxk: fix xstats for different packet sizes
>
> Robin Jarry (1):
> usertools/pmdinfo: fix usage typos
>
> Ruifeng Wang (1):
> ethdev: fix 32-bit build with GCC 13
>
> Satheesh Paul (2):
> common/cnxk: fix default flow action setting
> common/cnxk: fix SDP channel mask
>
> Saurabh Singhal (1):
> net/iavf: unregister interrupt handler before FD close
>
> Selwin Sebastian (1):
> net/axgbe: identify CPU with cpuid
>
> Shihong Wang (1):
> net/nfp: fix DMA error after abnormal exit
>
> Sivaprasad Tummala (1):
> eventdev: fix alignment padding
>
> Sivaramakrishnan Venkat (1):
> test/crypto: fix typo in asym tests
>
> Srikanth Yalavarthi (2):
> eal/unix: fix firmware reading with external xz helper
> build: add libarchive to optional external dependencies
>
> Stephen Hemminger (9):
> app/test: fix reference to master in bonding test
> random: initialize state for unregistered non-EAL threads
> common/mlx5: replace use of PMD log type
> app/procinfo: remove unnecessary rte_malloc
> app/testpmd: fix early exit from signal
> app/dumpcap: fix mbuf pool ring type
> meter: fix RFC4115 trTCM API Doxygen
> pdump: fix error number on IPC response
> app/dumpcap: allow multiple invocations
>
> Suanming Mou (3):
> ethdev: add check in async flow action query
> net/mlx5: fix counter query during port close
> net/mlx5: fix destroying external representor flow
>
> Tejasree Kondoj (1):
> crypto/cnxk: fix IPsec CCM and GCM capabilities
>
> Timothy Miskell (1):
> net/ice: fix L1 check interval
>
> Tomasz Duszynski (1):
> rawdev: fix device class in log message
>
> Tyler Retzlaff (2):
> malloc: remove return from void functions
> eal/riscv: fix vector type alignment
>
> Viacheslav Galaktionov (2):
> net/sfc: set max Rx packet length for representors
> net/sfc: account for data offset on Tx
>
> Viacheslav Ovsiienko (1):
> net/mlx5: fix multi-segment Tx inline data length
>
> Visa Hankala (1):
> net/bonding: fix header for C++
>
> Vladimir Medvedkin (2):
> fib: fix adding default route overwriting entire table
> fib6: fix adding default route as first route
>
> Wei Hu (2):
> net/mana: enable 32-bit build
> net/mana: add 32-bit short doorbell
>
> Weiguo Li (3):
> net/enic: avoid extra unlock in MTU set
> net/sfc: remove null dereference in log
> net/mlx5: fix unlock mismatch
>
> Wenjing Qiao (1):
> net/iavf: fix VLAN offload strip flag
>
> Wenwu Ma (1):
> net/virtio: fix link state interrupt vector setting
>
> Xueming Li (2):
> Revert "eventdev: fix alignment padding"
> app/test: disable graph auto test for windows
>
> Yajun Wu (1):
> vdpa/mlx5: fix unregister kick handler order
>
> Yiding Zhou (1):
> net/iavf: fix port stats clearing
>
> Zerun Fu (1):
> net/nfp: fix initialization of physical representors
>
> Zhichao Zeng (1):
> net/ice: fix DCF port statistics
>
>
[-- Attachment #2: Type: text/html, Size: 20659 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* RE: 22.11.4 patches review and test
2023-12-27 8:17 ` YangHang Liu
@ 2023-12-27 8:26 ` Xueming(Steven) Li
0 siblings, 0 replies; 10+ messages in thread
From: Xueming(Steven) Li @ 2023-12-27 8:26 UTC (permalink / raw)
To: YangHang Liu
Cc: stable, dev, Abhishek Marathe, Ali Alnubani, benjamin.walker,
David Christensen, Hemant Agrawal, Ian Stokes, Jerin Jacob,
John McNamara, Ju-Hyoung Lee, Kevin Traynor, Luca Boccassi,
Pei Zhang, qian.q.xu, Raslan Darawsheh,
NBU-Contact-Thomas Monjalon (EXTERNAL),
yuan.peng, zhaoyan.chen, Chao Yang
Hi Yanghang,
Thanks for the test and confirmation!
Best Regards,
Xueming Li
From: YangHang Liu <yanghliu@redhat.com>
Sent: 12/27/2023 16:17
To: Xueming(Steven) Li <xuemingl@nvidia.com>
Cc: stable@dpdk.org; dev@dpdk.org; Abhishek Marathe <Abhishek.Marathe@microsoft.com>; Ali Alnubani <alialnu@nvidia.com>; benjamin.walker@intel.com; David Christensen <drc@linux.vnet.ibm.com>; Hemant Agrawal <hemant.agrawal@nxp.com>; Ian Stokes <ian.stokes@intel.com>; Jerin Jacob <jerinj@marvell.com>; John McNamara <john.mcnamara@intel.com>; Ju-Hyoung Lee <juhlee@microsoft.com>; Kevin Traynor <ktraynor@redhat.com>; Luca Boccassi <bluca@debian.org>; Pei Zhang <pezhang@redhat.com>; qian.q.xu@intel.com; Raslan Darawsheh <rasland@nvidia.com>; NBU-Contact-Thomas Monjalon (EXTERNAL) <thomas@monjalon.net>; yuan.peng@intel.com; zhaoyan.chen@intel.com; Chao Yang <chayang@redhat.com>
Subject: Re: 22.11.4 patches review and test
I tested below 18 scenarios on RHEL9 and didn't find any new dpdk issues.
Guest with device assignment(PF) throughput testing(1G hugepage size): PASS
Guest with device assignment(PF) throughput testing(2M hugepage size) : PASS
Guest with device assignment(VF) throughput testing: PASS
PVP (host dpdk testpmd as vswitch) 1Q: throughput testing: PASS
PVP vhost-user 4Q throughput testing: PASS
PVP vhost-user 2Q throughput testing: PASS
PVP vhost-user 1Q - cross numa node throughput testing: PASS
Guest with vhost-user 2 queues throughput testing: PASS
vhost-user reconnect with dpdk-client, qemu-server qemu reconnect: PASS
vhost-user reconnect with dpdk-client, qemu-server ovs reconnect: PASS
PVP 1Q live migration testing: PASS
PVP 1Q cross numa node live migration testing: PASS
Guest with ovs+dpdk+vhost-user 1Q live migration testing: PASS
Guest with ovs+dpdk+vhost-user 1Q live migration testing (2M): PASS
Guest with ovs+dpdk+vhost-user 2Q live migration testing: PASS
Guest with ovs+dpdk+vhost-user 4Q live migration testing: PASS
Host PF + DPDK testing: PASS
Host VF + DPDK testing: PASS
Test Versions:
qemu-kvm-7.2.0
kernel 5.14
# git describe
v22.11.4-rc3
Test device : X540-AT2 NIC(ixgbe, 10G)
Best Regards,
YangHang Liu
On Wed, Dec 20, 2023 at 3:19 PM Xueming Li <mailto:xuemingl@nvidia.com> wrote:
Hi all,
Here is a list of patches targeted for stable release 22.11.4.
The planned date for the final release is 5th January.
Please help with testing and validation of your use cases and report
any issues/results with reply-all to this mail. For the final release
the fixes and reported validations will be added to the release notes.
A release candidate tarball can be found at:
https://dpdk.org/browse/dpdk-stable/tag/?id=v22.11.4-rc3
These patches are located at branch 22.11 of dpdk-stable repo:
https://dpdk.org/browse/dpdk-stable/
Thanks.
Xueming Li <mailto:xuemingl@nvidia.com>
---
Aakash Sasidharan (2):
event/cnxk: fix return values for capability API
test/event: fix crypto null device creation
Abdullah Sevincer (3):
bus/pci: add PASID control
event/dlb2: disable PASID
event/dlb2: fix disable PASID
Akhil Goyal (2):
common/cnxk: fix different size bit operations
net/cnxk: fix uninitialized variable
Alex Vesker (1):
net/mlx5/hws: fix field copy bind
Alexander Kozyrev (3):
net/mlx5/hws: fix integrity bits level
net/mlx5: fix MPRQ stride size check
ethdev: fix ESP packet type description
Amit Prakash Shukla (4):
common/cnxk: fix DPI memzone name
dma/cnxk: fix device state
dma/cnxk: fix device reconfigure
dma/cnxk: fix chunk buffer failure return code
Anatoly Burakov (1):
test: fix named test macro
Anoob Joseph (2):
cryptodev: add missing doc for security context
doc: replace code blocks with includes in security guide
Artemy Kovalyov (1):
mem: fix deadlock with multiprocess
Ashwin Sekhar T K (2):
mempool/cnxk: fix alloc from non-EAL threads
common/cnxk: fix aura disable handling
Beilei Xing (1):
net/i40e: fix FDIR queue receives broadcast packets
Bing Zhao (3):
net/mlx5: fix flow workspace double free in Windows
net/mlx5: fix shared Rx queue list management
net/mlx5: fix LACP redirection in Rx domain
Brian Dooley (4):
test/crypto: fix IV in some vectors
test/crypto: skip some synchronous tests with CPU crypto
doc: update kernel module entry in QAT guide
examples/ipsec-secgw: fix partial overflow
Bruce Richardson (8):
crypto/ipsec_mb: add dependency check for cross build
event/sw: remove obsolete comment
net/i40e: fix buffer leak on Rx reconfiguration
eventdev: fix device pointer for vdev-based devices
eventdev: fix missing driver names in info struct
ethdev: fix function name in comment
event/dlb2: fix name check in self-test
event/dlb2: fix missing queue ordering capability flag
Chaoyong He (5):
net/nfp: fix crash on close
net/nfp: fix reconfigure logic in PF initialization
net/nfp: fix reconfigure logic in VF initialization
net/nfp: fix link status interrupt
net/nfp: fix reconfigure logic of set MAC address
Chengwen Feng (2):
net/hns3: fix traffic management thread safety
net/hns3: fix traffic management dump text alignment
Christian Ehrhardt (1):
config: fix RISC-V native build
Ciara Power (2):
crypto/qat: fix raw API null algorithm digest
crypto/openssl: fix memory leaks in asym session
Dariusz Sosnowski (8):
net/mlx5: fix jump ipool entry size
net/mlx5: fix flow thread safety flag for HWS
common/mlx5: fix controller index parsing
net/mlx5: fix missing flow rules for external SQ
net/mlx5: fix use after free on Rx queue start
net/mlx5: fix hairpin queue unbind
net/mlx5: fix hairpin queue states
net/mlx5: fix offset size in conntrack flow action
David Christensen (1):
net/tap: use MAC address parse API instead of local parser
David Marchand (22):
ci: fix race on container image name
mempool: fix default ops for an empty mempool
crypto/dpaa2_sec: fix debug prints
crypto/dpaa_sec: fix debug prints
eventdev: fix symbol export for port maintenance
common/cnxk: remove dead Meson code
app/bbdev: fix link with NXP LA12XX
net/iavf: fix checksum offloading
net/iavf: fix Tx debug
net/iavf: remove log from Tx prepare function
net/iavf: fix TSO with big segments
net/ice: remove log from Tx prepare function
net/ice: fix TSO with big segments
net/mlx5: fix leak in sysfs port name translation
net/bonding: fix link status callback stop
bus/ifpga: fix driver header dependency
net/tap: fix L4 checksum offloading
net/tap: fix IPv4 checksum offloading
net/iavf: fix indent in Tx path
doc: remove restriction on ixgbe vector support
doc: fix some ordered lists
doc: remove number of commands in vDPA guide
Dengdui Huang (14):
net/hns3: fix VF default MAC modified when set failed
net/hns3: fix error code for multicast resource
net/hns3: fix flushing multicast MAC address
app/testpmd: fix help string
net/hns3: fix unchecked Rx free threshold
net/hns3: fix double stats for IMP and global reset
net/hns3: remove reset log in secondary
net/hns3: fix multiple reset detected log
net/hns3: fix IMP or global reset
net/hns3: refactor interrupt state query
net/hns3: fix mailbox sync
net/hns3: fix ignored reset event
net/hns3: fix reset event status
net/hns3: fix VF reset handler interruption
Ed Czeck (1):
net/ark: support single function with multiple port
Eli Britstein (1):
net/mlx5: zero UDP checksum over IPv4 in encapsulation
Feifei Wang (1):
app/pipeline: add sigint handler
Fengjiang Liu (1):
net/virtio: fix missing next flag in Tx packed ring
Ferruh Yigit (3):
net/txgbe: fix out of bound access
mempool: fix get function documentation
mempool: clarify enqueue/dequeue ops documentation
Gagandeep Singh (1):
bus/dpaa: fix build with asserts for GCC 13
Ganapati Kundapura (1):
eventdev/crypto: fix circular buffer full case
Gregory Etelson (1):
eal/windows: fix build with recent MinGW
Harman Kalra (1):
mempool/cnxk: fix free from non-EAL threads
Harry van Haaren (1):
event/sw: fix ordering corruption with op release
Hemant Agrawal (1):
test/crypto: fix return value for GMAC case
Hernan Vargas (3):
baseband/acc: fix ACC100 HARQ input alignment
test/bbdev: fix Python script subprocess
test/bbdev: assert failed test for queue configure
Huisong Li (11):
net/hns3: fix order in NEON Rx
net/hns3: fix setting DCB capability
net/hns3: fix LRO offload to report
app/testpmd: remove useless check in TSO command
app/testpmd: fix tunnel TSO capability check
app/testpmd: add explicit check for tunnel TSO
app/testpmd: fix tunnel TSO configuration
doc: fix hns3 build option about max queue number
doc: update features in hns3 guide
doc: fix RSS flow description in hns3 guide
examples/ethtool: fix pause configuration
Ivan Malov (1):
net/sfc: add missing error code indication to MAE init path
Jerin Jacob (1):
common/cnxk: replace direct API usage in REE
Jiawei Wang (3):
net/mlx5: fix decap action checking in sample flow
net/mlx5: fix E-Switch mirror flow rule validation
net/mlx5: fix validation of sample encap flow action
Jiawen Wu (12):
net/txgbe: add Tx queue maximum limit
net/txgbe: fix GRE tunnel packet checksum
net/ngbe: fix flow control
net/ngbe: prevent NIC from slowing down link speed
net/txgbe: reconfigure MAC Rx when link update
net/ngbe: reconfigure MAC Rx when link update
net/txgbe: keep link down after device close
net/ngbe: keep link down after device close
net/txgbe: check process type in close operation
net/ngbe: check process type in close operation
net/txgbe: add proper memory barriers in Rx
net/ngbe: add proper memory barriers in Rx
Jie Hai (41):
net/af_packet: fix Rx and Tx queue state
net/af_xdp: fix Rx and Tx queue state
net/avp: fix Rx and Tx queue state
net/bnx2x: fix Rx and Tx queue state
net/bnxt: fix Rx and Tx queue state
net/bonding: fix Rx and Tx queue state
net/cxgbe: fix Rx and Tx queue state
net/dpaa: fix Rx and Tx queue state
net/dpaa2: fix Rx and Tx queue state
net/e1000: fix Rx and Tx queue state
net/ena: fix Rx and Tx queue state
net/enetc: fix Rx and Tx queue state
net/enic: fix Rx and Tx queue state
net/hinic: fix Rx and Tx queue state
net/ipn3ke: fix Rx and Tx queue state
net/memif: fix Rx and Tx queue state
net/mlx4: fix Rx and Tx queue state
net/mvneta: fix Rx and Tx queue state
net/mvpp2: fix Rx and Tx queue state
net/nfp: fix Rx and Tx queue state
net/ngbe: fix Rx and Tx queue state
net/null: fix Rx and Tx queue state
net/octeon_ep: fix Rx and Tx queue state
net/octeontx: fix Rx and Tx queue state
net/pfe: fix Rx and Tx queue state
net/ring: fix Rx and Tx queue state
net/sfc: fix Rx and Tx queue state
net/softnic: fix Rx and Tx queue state
net/txgbe: fix Rx and Tx queue state
net/vhost: fix Rx and Tx queue state
net/virtio: fix Rx and Tx queue state
net/vmxnet3: fix Rx and Tx queue state
app/testpmd: fix primary process not polling all queues
net/hns3: fix typo in function name
net/hns3: fix some return values
net/hns3: fix some error logs
net/hns3: keep set/get algo key functions local
net/hns3: fix uninitialized hash algo value
app/procinfo: fix RSS info
app/procinfo: adjust format of RSS info
test/bonding: fix uninitialized RSS configuration
Jieqiang Wang (1):
hash: align SSE lookup to scalar implementation
Joshua Washington (4):
net/gve: fix max MTU limit
net/gve: update max Rx packet length to be based on MTU
ethdev: account for smaller MTU when setting default
net/gve: fix RX buffer size alignment
Juraj Linkeš (1):
config/arm: fix aarch32 build with GCC 13
Kaiwen Deng (1):
net/ice: fix TM configuration clearing
Kevin Traynor (1):
doc: update versions recommendations for i40e and ice
Kiran Kumar K (1):
common/cnxk: fix RSS key configuration
Kommula Shiva Shankar (1):
common/cnxk: fix pool buffer size in opaque mode
Levend Sayar (1):
gpu/cuda: fix build with external GDRCopy
Long Li (2):
net/netvsc: increase VSP response timeout to 60 seconds
net/mana: add missing new line to data path logs
Long Wu (4):
net/nfp: fix control message packets
test/bonding: remove unreachable statement
test/bonding: add missing check
net/bonding: fix possible overrun
Madhuker Mythri (1):
net/tap: fix RSS for fragmented packets
Martin Weiser (1):
net/ice: write timestamp to first segment in scattered Rx
Maxime Coquelin (6):
vhost: fix missing vring call check on virtqueue access
vhost: fix missing check on virtqueue access
vhost: fix check on virtqueue access in async registration
vhost: fix check on virtqueue access in in-flight getter
vhost: fix missing lock protection in power monitor API
vhost: fix checking virtqueue access in stats API
Min Zhou (1):
test/hash: fix creation error log
Mingjin Ye (1):
net/ice: fix crash on closing representor ports
Nagadheeraj Rottela (1):
crypto/nitrox: fix panic with high number of segments
Nicolas Chautru (1):
baseband/acc: fix TB mode on VRB1
Nithin Dabilpuram (1):
net/cnxk: fix data offset in vector Tx
Ori Kam (1):
net/mlx5: fix NIC flow capability query
Pavan Nikhilesh (4):
event/cnxk: fix getwork mode devargs parsing
event/cnxk: fix CASP usage for clang
event/cnxk: fix context flush in port cleanup
common/cnxk: fix incorrect aura ID
Qi Zhang (2):
net/iavf: fix Tx preparation
net/ice: fix Tx preparation
Qiming Yang (2):
bus/pci: fix device ID log
net/ice: fix initial link status
Radu Nicolau (3):
net/iavf: fix ESN session update
net/iavf: fix Tx offload mask
net/iavf: fix Tx offload flags check
Rahul Bhansali (2):
test/security: fix IPv6 next header field
eventdev/eth_rx: fix timestamp field register in mbuf
Rakesh Kudurumalla (1):
common/cnxk: fix xstats for different packet sizes
Robin Jarry (1):
usertools/pmdinfo: fix usage typos
Ruifeng Wang (1):
ethdev: fix 32-bit build with GCC 13
Satheesh Paul (2):
common/cnxk: fix default flow action setting
common/cnxk: fix SDP channel mask
Saurabh Singhal (1):
net/iavf: unregister interrupt handler before FD close
Selwin Sebastian (1):
net/axgbe: identify CPU with cpuid
Shihong Wang (1):
net/nfp: fix DMA error after abnormal exit
Sivaprasad Tummala (1):
eventdev: fix alignment padding
Sivaramakrishnan Venkat (1):
test/crypto: fix typo in asym tests
Srikanth Yalavarthi (2):
eal/unix: fix firmware reading with external xz helper
build: add libarchive to optional external dependencies
Stephen Hemminger (9):
app/test: fix reference to master in bonding test
random: initialize state for unregistered non-EAL threads
common/mlx5: replace use of PMD log type
app/procinfo: remove unnecessary rte_malloc
app/testpmd: fix early exit from signal
app/dumpcap: fix mbuf pool ring type
meter: fix RFC4115 trTCM API Doxygen
pdump: fix error number on IPC response
app/dumpcap: allow multiple invocations
Suanming Mou (3):
ethdev: add check in async flow action query
net/mlx5: fix counter query during port close
net/mlx5: fix destroying external representor flow
Tejasree Kondoj (1):
crypto/cnxk: fix IPsec CCM and GCM capabilities
Timothy Miskell (1):
net/ice: fix L1 check interval
Tomasz Duszynski (1):
rawdev: fix device class in log message
Tyler Retzlaff (2):
malloc: remove return from void functions
eal/riscv: fix vector type alignment
Viacheslav Galaktionov (2):
net/sfc: set max Rx packet length for representors
net/sfc: account for data offset on Tx
Viacheslav Ovsiienko (1):
net/mlx5: fix multi-segment Tx inline data length
Visa Hankala (1):
net/bonding: fix header for C++
Vladimir Medvedkin (2):
fib: fix adding default route overwriting entire table
fib6: fix adding default route as first route
Wei Hu (2):
net/mana: enable 32-bit build
net/mana: add 32-bit short doorbell
Weiguo Li (3):
net/enic: avoid extra unlock in MTU set
net/sfc: remove null dereference in log
net/mlx5: fix unlock mismatch
Wenjing Qiao (1):
net/iavf: fix VLAN offload strip flag
Wenwu Ma (1):
net/virtio: fix link state interrupt vector setting
Xueming Li (2):
Revert "eventdev: fix alignment padding"
app/test: disable graph auto test for windows
Yajun Wu (1):
vdpa/mlx5: fix unregister kick handler order
Yiding Zhou (1):
net/iavf: fix port stats clearing
Zerun Fu (1):
net/nfp: fix initialization of physical representors
Zhichao Zeng (1):
net/ice: fix DCF port statistics
^ permalink raw reply [flat|nested] 10+ messages in thread
* RE: 22.11.4 patches review and test
2023-12-20 7:19 22.11.4 patches review and test Xueming Li
2023-12-27 8:17 ` YangHang Liu
@ 2024-01-03 14:41 ` Ali Alnubani
2024-01-04 6:16 ` Xueming(Steven) Li
2024-01-11 1:42 ` Xu, HailinX
2 siblings, 1 reply; 10+ messages in thread
From: Ali Alnubani @ 2024-01-03 14:41 UTC (permalink / raw)
To: Xueming(Steven) Li, stable
Cc: dev, Abhishek Marathe, benjamin.walker, David Christensen,
Hemant Agrawal, Ian Stokes, Jerin Jacob, John McNamara,
Ju-Hyoung Lee, Kevin Traynor, Luca Boccassi, Pei Zhang,
qian.q.xu, Raslan Darawsheh,
NBU-Contact-Thomas Monjalon (EXTERNAL),
Yanghang Liu, yuan.peng, zhaoyan.chen
> -----Original Message-----
> From: Xueming(Steven) Li <xuemingl@nvidia.com>
> Sent: Wednesday, December 20, 2023 9:19 AM
> To: stable@dpdk.org
> Cc: Xueming(Steven) Li <xuemingl@nvidia.com>; dev@dpdk.org; Abhishek
> Marathe <Abhishek.Marathe@microsoft.com>; Ali Alnubani
> <alialnu@nvidia.com>; benjamin.walker@intel.com; David Christensen
> <drc@linux.vnet.ibm.com>; Hemant Agrawal <hemant.agrawal@nxp.com>;
> Ian Stokes <ian.stokes@intel.com>; Jerin Jacob <jerinj@marvell.com>; John
> McNamara <john.mcnamara@intel.com>; Ju-Hyoung Lee
> <juhlee@microsoft.com>; Kevin Traynor <ktraynor@redhat.com>; Luca
> Boccassi <bluca@debian.org>; Pei Zhang <pezhang@redhat.com>;
> qian.q.xu@intel.com; Raslan Darawsheh <rasland@nvidia.com>; NBU-
> Contact-Thomas Monjalon (EXTERNAL) <thomas@monjalon.net>; Yanghang
> Liu <yanghliu@redhat.com>; yuan.peng@intel.com; zhaoyan.chen@intel.com
> Subject: 22.11.4 patches review and test
>
> Hi all,
>
> Here is a list of patches targeted for stable release 22.11.4.
>
> The planned date for the final release is 5th January.
>
> Please help with testing and validation of your use cases and report
> any issues/results with reply-all to this mail. For the final release
> the fixes and reported validations will be added to the release notes.
>
> A release candidate tarball can be found at:
>
> https://dpdk.org/browse/dpdk-stable/tag/?id=v22.11.4-rc3
>
> These patches are located at branch 22.11 of dpdk-stable repo:
> https://dpdk.org/browse/dpdk-stable/
>
> Thanks.
Hello,
We ran the following functional tests with Nvidia hardware on v22.11.4-rc3:
- Basic functionality:
Send and receive multiple types of traffic.
- testpmd xstats counter test.
- testpmd timestamp test.
- Changing/checking link status through testpmd.
- rte_flow tests (https://doc.dpdk.org/guides/nics/mlx5.html#supported-hardware-offloads)
- RSS tests.
- VLAN filtering, stripping, and insertion tests.
- Checksum and TSO tests.
- ptype tests.
- link_status_interrupt example application tests.
- l3fwd-power example application tests.
- Multi-process example applications tests.
- Hardware LRO tests.
- Regex application tests.
- Buffer Split tests.
- Tx scheduling tests.
Functional tests ran on:
- NIC: ConnectX-6 Dx / OS: Ubuntu 20.04 / Driver: MLNX_OFED_LINUX-23.10-1.1.9.0 / Firmware: 22.39.2048
- NIC: ConnectX-7 / OS: Ubuntu 20.04 / Driver: MLNX_OFED_LINUX-23.10-1.1.9.0 / Firmware: 28.39.2048
- DPU: BlueField-2 / DOCA SW version: 2.5.0 / Firmware: 24.39.2048
Additionally, we ran build tests with multiple configurations on the following OS/driver combinations (all passed):
- Ubuntu 20.04.6 with MLNX_OFED_LINUX-23.10-1.1.9.0.
- Ubuntu 20.04.6 with rdma-core master (9016f34).
- Ubuntu 20.04.6 with rdma-core v28.0.
- Fedora 38 with rdma-core v44.0.
- Fedora 40 (Rawhide) with rdma-core v48.0.
- OpenSUSE Leap 15.5 with rdma-core v42.0.
- Windows Server 2019 with Clang 16.0.6.
We don't see new issues caused by the changes in this release.
Thanks,
Ali
^ permalink raw reply [flat|nested] 10+ messages in thread
* RE: 22.11.4 patches review and test
2024-01-03 14:41 ` Ali Alnubani
@ 2024-01-04 6:16 ` Xueming(Steven) Li
0 siblings, 0 replies; 10+ messages in thread
From: Xueming(Steven) Li @ 2024-01-04 6:16 UTC (permalink / raw)
To: Ali Alnubani, stable
Cc: dev, Abhishek Marathe, benjamin.walker, David Christensen,
Hemant Agrawal, Ian Stokes, Jerin Jacob, John McNamara,
Ju-Hyoung Lee, Kevin Traynor, Luca Boccassi, Pei Zhang,
qian.q.xu, Raslan Darawsheh,
NBU-Contact-Thomas Monjalon (EXTERNAL),
Yanghang Liu, yuan.peng, zhaoyan.chen
Hi Ali,
Thanks for the testing and report!
Regards,
Xueming
> -----Original Message-----
> From: Ali Alnubani <alialnu@nvidia.com>
> Sent: 1/3/2024 22:41
> To: Xueming(Steven) Li <xuemingl@nvidia.com>; stable@dpdk.org
> Cc: dev@dpdk.org; Abhishek Marathe <Abhishek.Marathe@microsoft.com>;
> benjamin.walker@intel.com; David Christensen <drc@linux.vnet.ibm.com>;
> Hemant Agrawal <hemant.agrawal@nxp.com>; Ian Stokes
> <ian.stokes@intel.com>; Jerin Jacob <jerinj@marvell.com>; John McNamara
> <john.mcnamara@intel.com>; Ju-Hyoung Lee <juhlee@microsoft.com>; Kevin
> Traynor <ktraynor@redhat.com>; Luca Boccassi <bluca@debian.org>; Pei Zhang
> <pezhang@redhat.com>; qian.q.xu@intel.com; Raslan Darawsheh
> <rasland@nvidia.com>; NBU-Contact-Thomas Monjalon (EXTERNAL)
> <thomas@monjalon.net>; Yanghang Liu <yanghliu@redhat.com>;
> yuan.peng@intel.com; zhaoyan.chen@intel.com
> Subject: RE: 22.11.4 patches review and test
>
> > -----Original Message-----
> > From: Xueming(Steven) Li <xuemingl@nvidia.com>
> > Sent: Wednesday, December 20, 2023 9:19 AM
> > To: stable@dpdk.org
> > Cc: Xueming(Steven) Li <xuemingl@nvidia.com>; dev@dpdk.org; Abhishek
> > Marathe <Abhishek.Marathe@microsoft.com>; Ali Alnubani
> > <alialnu@nvidia.com>; benjamin.walker@intel.com; David Christensen
> > <drc@linux.vnet.ibm.com>; Hemant Agrawal <hemant.agrawal@nxp.com>; Ian
> > Stokes <ian.stokes@intel.com>; Jerin Jacob <jerinj@marvell.com>; John
> > McNamara <john.mcnamara@intel.com>; Ju-Hyoung Lee
> > <juhlee@microsoft.com>; Kevin Traynor <ktraynor@redhat.com>; Luca
> > Boccassi <bluca@debian.org>; Pei Zhang <pezhang@redhat.com>;
> > qian.q.xu@intel.com; Raslan Darawsheh <rasland@nvidia.com>; NBU-
> > Contact-Thomas Monjalon (EXTERNAL) <thomas@monjalon.net>; Yanghang Liu
> > <yanghliu@redhat.com>; yuan.peng@intel.com; zhaoyan.chen@intel.com
> > Subject: 22.11.4 patches review and test
> >
> > Hi all,
> >
> > Here is a list of patches targeted for stable release 22.11.4.
> >
> > The planned date for the final release is 5th January.
> >
> > Please help with testing and validation of your use cases and report
> > any issues/results with reply-all to this mail. For the final release
> > the fixes and reported validations will be added to the release notes.
> >
> > A release candidate tarball can be found at:
> >
> > https://dpdk.org/browse/dpdk-stable/tag/?id=v22.11.4-rc3
> >
> > These patches are located at branch 22.11 of dpdk-stable repo:
> > https://dpdk.org/browse/dpdk-stable/
> >
> > Thanks.
>
> Hello,
>
> We ran the following functional tests with Nvidia hardware on v22.11.4-rc3:
> - Basic functionality:
> Send and receive multiple types of traffic.
> - testpmd xstats counter test.
> - testpmd timestamp test.
> - Changing/checking link status through testpmd.
> - rte_flow tests (https://doc.dpdk.org/guides/nics/mlx5.html#supported-
> hardware-offloads)
> - RSS tests.
> - VLAN filtering, stripping, and insertion tests.
> - Checksum and TSO tests.
> - ptype tests.
> - link_status_interrupt example application tests.
> - l3fwd-power example application tests.
> - Multi-process example applications tests.
> - Hardware LRO tests.
> - Regex application tests.
> - Buffer Split tests.
> - Tx scheduling tests.
>
> Functional tests ran on:
> - NIC: ConnectX-6 Dx / OS: Ubuntu 20.04 / Driver: MLNX_OFED_LINUX-23.10-
> 1.1.9.0 / Firmware: 22.39.2048
> - NIC: ConnectX-7 / OS: Ubuntu 20.04 / Driver: MLNX_OFED_LINUX-23.10-
> 1.1.9.0 / Firmware: 28.39.2048
> - DPU: BlueField-2 / DOCA SW version: 2.5.0 / Firmware: 24.39.2048
>
> Additionally, we ran build tests with multiple configurations on the following
> OS/driver combinations (all passed):
> - Ubuntu 20.04.6 with MLNX_OFED_LINUX-23.10-1.1.9.0.
> - Ubuntu 20.04.6 with rdma-core master (9016f34).
> - Ubuntu 20.04.6 with rdma-core v28.0.
> - Fedora 38 with rdma-core v44.0.
> - Fedora 40 (Rawhide) with rdma-core v48.0.
> - OpenSUSE Leap 15.5 with rdma-core v42.0.
> - Windows Server 2019 with Clang 16.0.6.
>
> We don't see new issues caused by the changes in this release.
>
> Thanks,
> Ali
^ permalink raw reply [flat|nested] 10+ messages in thread
* RE: 22.11.4 patches review and test
2023-12-20 7:19 22.11.4 patches review and test Xueming Li
2023-12-27 8:17 ` YangHang Liu
2024-01-03 14:41 ` Ali Alnubani
@ 2024-01-11 1:42 ` Xu, HailinX
2024-01-11 6:32 ` Xueming(Steven) Li
2 siblings, 1 reply; 10+ messages in thread
From: Xu, HailinX @ 2024-01-11 1:42 UTC (permalink / raw)
To: Xueming Li, stable
Cc: dev, Abhishek Marathe, Ali Alnubani, benjamin.walker,
David Christensen, Hemant Agrawal, Stokes, Ian, Jerin Jacob,
Mcnamara, John, Ju-Hyoung Lee, Kevin Traynor, Luca Boccassi,
Pei Zhang, qian.q.xu, Raslan Darawsheh, Thomas Monjalon,
Yanghang Liu, yuan.peng, zhaoyan.chen
> -----Original Message-----
> From: Xueming Li <xuemingl@nvidia.com>
> Sent: Wednesday, December 20, 2023 3:19 PM
> To: stable@dpdk.org
> Cc: xuemingl@nvidia.com; dev@dpdk.org; Abhishek Marathe
> <Abhishek.Marathe@microsoft.com>; Ali Alnubani <alialnu@nvidia.com>;
> benjamin.walker@intel.com; David Christensen <drc@linux.vnet.ibm.com>;
> Hemant Agrawal <hemant.agrawal@nxp.com>; Stokes, Ian
> <ian.stokes@intel.com>; Jerin Jacob <jerinj@marvell.com>; Mcnamara, John
> <john.mcnamara@intel.com>; Ju-Hyoung Lee <juhlee@microsoft.com>;
> Kevin Traynor <ktraynor@redhat.com>; Luca Boccassi <bluca@debian.org>;
> Pei Zhang <pezhang@redhat.com>; qian.q.xu@intel.com; Raslan Darawsheh
> <rasland@nvidia.com>; Thomas Monjalon <thomas@monjalon.net>;
> Yanghang Liu <yanghliu@redhat.com>; yuan.peng@intel.com;
> zhaoyan.chen@intel.com
> Subject: 22.11.4 patches review and test
>
> Hi all,
>
> Here is a list of patches targeted for stable release 22.11.4.
>
> The planned date for the final release is 5th January.
>
> Please help with testing and validation of your use cases and report any
> issues/results with reply-all to this mail. For the final release the fixes and
> reported validations will be added to the release notes.
>
> A release candidate tarball can be found at:
>
> https://dpdk.org/browse/dpdk-stable/tag/?id=v22.11.4-rc3
>
> These patches are located at branch 22.11 of dpdk-stable repo:
> https://dpdk.org/browse/dpdk-stable/
>
> Thanks.
>
> Xueming Li <xuemingl@nvidia.com>
Update the test status for Intel part. dpdk22.11.4-rc3 all validation test done. Found 1 virtio bug.
new issue:
https://bugs.dpdk.org/show_bug.cgi?id=1338: virtio-user can't receive packet: this test only on SPR -Intel(R) Xeon(R) Platinum 8490H --Intel development is investigating
# Basic Intel(R) NIC testing
* Build & CFLAG compile: cover the build test combination with latest GCC/Clang version and the popular OS revision such as
Ubuntu20.04, Ubuntu22.04, Fedora38, RHEL8.7, RHEL9.2, FreeBSD13.2, SUSE15, CentOS7.9, openEuler22.03-SP1，OpenAnolis8.8 etc.
- All test done. No new dpdk issue is found.
* PF(i40e, ixgbe): test scenarios including RTE_FLOW/TSO/Jumboframe/checksum offload/VLAN/VXLAN, etc.
- All test done. No new dpdk issue is found.
* VF(i40e, ixgbe): test scenarios including VF-RTE_FLOW/TSO/Jumboframe/checksum offload/VLAN/VXLAN, etc.
- All test done. No new dpdk issue is found.
* PF/VF(ice): test scenarios including Switch features/Package Management/Flow Director/Advanced Tx/Advanced RSS/ACL/DCF/Flexible Descriptor, etc.
- All test done. No new dpdk issue is found.
* Intel NIC single core/NIC performance: test scenarios including PF/VF single core performance test, etc.
- All test done. No new dpdk issue is found.
* IPsec: test scenarios including ipsec/ipsec-gw/ipsec library basic test - QAT&SW/FIB library, etc.
- All test done. No new dpdk issue is found.
# Basic cryptodev and virtio testing
* Virtio: both function and performance test are covered. Such as PVP/Virtio_loopback/virtio-user loopback/virtio-net VM2VM perf testing/VMAWARE ESXI 8.0, etc.
- All test done. found 1 new issue.
* Cryptodev:
*Function test: test scenarios including Cryptodev API testing/CompressDev ISA-L/QAT/ZLIB PMD Testing/FIPS, etc.
- All test done. No new dpdk issue is found.
*Performance test: test scenarios including Thoughput Performance/Cryptodev Latency, etc.
- All test done. No new dpdk issue is found.
Regards,
Xu, Hailin
^ permalink raw reply [flat|nested] 10+ messages in thread
* RE: 22.11.4 patches review and test
2024-01-11 1:42 ` Xu, HailinX
@ 2024-01-11 6:32 ` Xueming(Steven) Li
2024-01-11 8:26 ` Maxime Coquelin
0 siblings, 1 reply; 10+ messages in thread
From: Xueming(Steven) Li @ 2024-01-11 6:32 UTC (permalink / raw)
To: Xu, HailinX, Maxime Coquelin
Cc: dev, Abhishek Marathe, Ali Alnubani, benjamin.walker, stable,
David Christensen, Hemant Agrawal, Stokes, Ian, Jerin Jacob,
Mcnamara, John, Ju-Hyoung Lee, Kevin Traynor, Luca Boccassi,
Pei Zhang, qian.q.xu, Raslan Darawsheh,
NBU-Contact-Thomas Monjalon (EXTERNAL),
Yanghang Liu, yuan.peng, zhaoyan.chen
Hi Hainlin,
Thanks very much for test test and report!
Let me know once any progress with the known issue.
Thanks,
Xueming.
> -----Original Message-----
> From: Xu, HailinX <hailinx.xu@intel.com>
> Sent: 1/11/2024 9:42
> To: Xueming(Steven) Li <xuemingl@nvidia.com>; stable@dpdk.org
> Cc: dev@dpdk.org; Abhishek Marathe <Abhishek.Marathe@microsoft.com>; Ali
> Alnubani <alialnu@nvidia.com>; benjamin.walker@intel.com; David Christensen
> <drc@linux.vnet.ibm.com>; Hemant Agrawal <hemant.agrawal@nxp.com>;
> Stokes, Ian <ian.stokes@intel.com>; Jerin Jacob <jerinj@marvell.com>;
> Mcnamara, John <john.mcnamara@intel.com>; Ju-Hyoung Lee
> <juhlee@microsoft.com>; Kevin Traynor <ktraynor@redhat.com>; Luca Boccassi
> <bluca@debian.org>; Pei Zhang <pezhang@redhat.com>; qian.q.xu@intel.com;
> Raslan Darawsheh <rasland@nvidia.com>; NBU-Contact-Thomas Monjalon
> (EXTERNAL) <thomas@monjalon.net>; Yanghang Liu <yanghliu@redhat.com>;
> yuan.peng@intel.com; zhaoyan.chen@intel.com
> Subject: RE: 22.11.4 patches review and test
>
> > -----Original Message-----
> > From: Xueming Li <xuemingl@nvidia.com>
> > Sent: Wednesday, December 20, 2023 3:19 PM
> > To: stable@dpdk.org
> > Cc: xuemingl@nvidia.com; dev@dpdk.org; Abhishek Marathe
> > <Abhishek.Marathe@microsoft.com>; Ali Alnubani <alialnu@nvidia.com>;
> > benjamin.walker@intel.com; David Christensen <drc@linux.vnet.ibm.com>;
> > Hemant Agrawal <hemant.agrawal@nxp.com>; Stokes, Ian
> > <ian.stokes@intel.com>; Jerin Jacob <jerinj@marvell.com>; Mcnamara,
> > John <john.mcnamara@intel.com>; Ju-Hyoung Lee <juhlee@microsoft.com>;
> > Kevin Traynor <ktraynor@redhat.com>; Luca Boccassi <bluca@debian.org>;
> > Pei Zhang <pezhang@redhat.com>; qian.q.xu@intel.com; Raslan Darawsheh
> > <rasland@nvidia.com>; Thomas Monjalon <thomas@monjalon.net>; Yanghang
> > Liu <yanghliu@redhat.com>; yuan.peng@intel.com; zhaoyan.chen@intel.com
> > Subject: 22.11.4 patches review and test
> >
> > Hi all,
> >
> > Here is a list of patches targeted for stable release 22.11.4.
> >
> > The planned date for the final release is 5th January.
> >
> > Please help with testing and validation of your use cases and report
> > any issues/results with reply-all to this mail. For the final release
> > the fixes and reported validations will be added to the release notes.
> >
> > A release candidate tarball can be found at:
> >
> > https://dpdk.org/browse/dpdk-stable/tag/?id=v22.11.4-rc3
> >
> > These patches are located at branch 22.11 of dpdk-stable repo:
> > https://dpdk.org/browse/dpdk-stable/
> >
> > Thanks.
> >
> > Xueming Li <xuemingl@nvidia.com>
>
> Update the test status for Intel part. dpdk22.11.4-rc3 all validation test done.
> Found 1 virtio bug.
>
> new issue:
> https://bugs.dpdk.org/show_bug.cgi?id=1338: virtio-user can't receive packet:
> this test only on SPR -Intel(R) Xeon(R) Platinum 8490H --Intel development is
> investigating
Maxime, seems the issue related to patch "vhost: fix checking virtqueue access in stats API",
Could you please take a look?
>
> # Basic Intel(R) NIC testing
> * Build & CFLAG compile: cover the build test combination with latest GCC/Clang
> version and the popular OS revision such as
> Ubuntu20.04, Ubuntu22.04, Fedora38, RHEL8.7, RHEL9.2, FreeBSD13.2, SUSE15,
> CentOS7.9, openEuler22.03-SP1，OpenAnolis8.8 etc.
> - All test done. No new dpdk issue is found.
> * PF(i40e, ixgbe): test scenarios including
> RTE_FLOW/TSO/Jumboframe/checksum offload/VLAN/VXLAN, etc.
> - All test done. No new dpdk issue is found.
> * VF(i40e, ixgbe): test scenarios including VF-
> RTE_FLOW/TSO/Jumboframe/checksum offload/VLAN/VXLAN, etc.
>
> - All test done. No new dpdk issue is found.
> * PF/VF(ice): test scenarios including Switch features/Package Management/Flow
> Director/Advanced Tx/Advanced RSS/ACL/DCF/Flexible Descriptor, etc.
> - All test done. No new dpdk issue is found.
> * Intel NIC single core/NIC performance: test scenarios including PF/VF single
> core performance test, etc.
> - All test done. No new dpdk issue is found.
> * IPsec: test scenarios including ipsec/ipsec-gw/ipsec library basic test -
> QAT&SW/FIB library, etc.
> - All test done. No new dpdk issue is found.
>
> # Basic cryptodev and virtio testing
> * Virtio: both function and performance test are covered. Such as
> PVP/Virtio_loopback/virtio-user loopback/virtio-net VM2VM perf
> testing/VMAWARE ESXI 8.0, etc.
> - All test done. found 1 new issue.
> * Cryptodev:
> *Function test: test scenarios including Cryptodev API testing/CompressDev ISA-
> L/QAT/ZLIB PMD Testing/FIPS, etc.
> - All test done. No new dpdk issue is found.
> *Performance test: test scenarios including Thoughput Performance/Cryptodev
> Latency, etc.
> - All test done. No new dpdk issue is found.
>
>
> Regards,
> Xu, Hailin
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: 22.11.4 patches review and test
2024-01-11 6:32 ` Xueming(Steven) Li
@ 2024-01-11 8:26 ` Maxime Coquelin
2024-01-11 8:44 ` Xueming(Steven) Li
0 siblings, 1 reply; 10+ messages in thread
From: Maxime Coquelin @ 2024-01-11 8:26 UTC (permalink / raw)
To: Xueming(Steven) Li, Xu, HailinX
Cc: dev, Abhishek Marathe, Ali Alnubani, benjamin.walker, stable,
David Christensen, Hemant Agrawal, Stokes, Ian, Jerin Jacob,
Mcnamara, John, Ju-Hyoung Lee, Kevin Traynor, Luca Boccassi,
Pei Zhang, qian.q.xu, Raslan Darawsheh,
NBU-Contact-Thomas Monjalon (EXTERNAL),
Yanghang Liu, yuan.peng, zhaoyan.chen
Hi,
On 1/11/24 07:32, Xueming(Steven) Li wrote:
> Hi Hainlin,
>
> Thanks very much for test test and report!
> Let me know once any progress with the known issue.
>
> Thanks,
> Xueming.
>
>> -----Original Message-----
>> From: Xu, HailinX <hailinx.xu@intel.com>
>> Sent: 1/11/2024 9:42
>> To: Xueming(Steven) Li <xuemingl@nvidia.com>; stable@dpdk.org
>> Cc: dev@dpdk.org; Abhishek Marathe <Abhishek.Marathe@microsoft.com>; Ali
>> Alnubani <alialnu@nvidia.com>; benjamin.walker@intel.com; David Christensen
>> <drc@linux.vnet.ibm.com>; Hemant Agrawal <hemant.agrawal@nxp.com>;
>> Stokes, Ian <ian.stokes@intel.com>; Jerin Jacob <jerinj@marvell.com>;
>> Mcnamara, John <john.mcnamara@intel.com>; Ju-Hyoung Lee
>> <juhlee@microsoft.com>; Kevin Traynor <ktraynor@redhat.com>; Luca Boccassi
>> <bluca@debian.org>; Pei Zhang <pezhang@redhat.com>; qian.q.xu@intel.com;
>> Raslan Darawsheh <rasland@nvidia.com>; NBU-Contact-Thomas Monjalon
>> (EXTERNAL) <thomas@monjalon.net>; Yanghang Liu <yanghliu@redhat.com>;
>> yuan.peng@intel.com; zhaoyan.chen@intel.com
>> Subject: RE: 22.11.4 patches review and test
>>
>>> -----Original Message-----
>>> From: Xueming Li <xuemingl@nvidia.com>
>>> Sent: Wednesday, December 20, 2023 3:19 PM
>>> To: stable@dpdk.org
>>> Cc: xuemingl@nvidia.com; dev@dpdk.org; Abhishek Marathe
>>> <Abhishek.Marathe@microsoft.com>; Ali Alnubani <alialnu@nvidia.com>;
>>> benjamin.walker@intel.com; David Christensen <drc@linux.vnet.ibm.com>;
>>> Hemant Agrawal <hemant.agrawal@nxp.com>; Stokes, Ian
>>> <ian.stokes@intel.com>; Jerin Jacob <jerinj@marvell.com>; Mcnamara,
>>> John <john.mcnamara@intel.com>; Ju-Hyoung Lee <juhlee@microsoft.com>;
>>> Kevin Traynor <ktraynor@redhat.com>; Luca Boccassi <bluca@debian.org>;
>>> Pei Zhang <pezhang@redhat.com>; qian.q.xu@intel.com; Raslan Darawsheh
>>> <rasland@nvidia.com>; Thomas Monjalon <thomas@monjalon.net>; Yanghang
>>> Liu <yanghliu@redhat.com>; yuan.peng@intel.com; zhaoyan.chen@intel.com
>>> Subject: 22.11.4 patches review and test
>>>
>>> Hi all,
>>>
>>> Here is a list of patches targeted for stable release 22.11.4.
>>>
>>> The planned date for the final release is 5th January.
>>>
>>> Please help with testing and validation of your use cases and report
>>> any issues/results with reply-all to this mail. For the final release
>>> the fixes and reported validations will be added to the release notes.
>>>
>>> A release candidate tarball can be found at:
>>>
>>> https://dpdk.org/browse/dpdk-stable/tag/?id=v22.11.4-rc3
>>>
>>> These patches are located at branch 22.11 of dpdk-stable repo:
>>> https://dpdk.org/browse/dpdk-stable/
>>>
>>> Thanks.
>>>
>>> Xueming Li <xuemingl@nvidia.com>
>>
>> Update the test status for Intel part. dpdk22.11.4-rc3 all validation test done.
>> Found 1 virtio bug.
>>
>> new issue:
>> https://bugs.dpdk.org/show_bug.cgi?id=1338: virtio-user can't receive packet:
>> this test only on SPR -Intel(R) Xeon(R) Platinum 8490H --Intel development is
>> investigating
>
> Maxime, seems the issue related to patch "vhost: fix checking virtqueue access in stats API",
> Could you please take a look?
I will reply in the Bz, but there seems to be 2 backporting issues:
1. We miss the unlock on return 0:
diff --git a/lib/vhost/vhost.c b/lib/vhost/vhost.c
index 4edb76d0dd..6e1bba4391 100644
--- a/lib/vhost/vhost.c
+++ b/lib/vhost/vhost.c
@@ -2070,6 +2070,12 @@ rte_vhost_get_monitor_addr(int vid, uint16_t
queue_id,
if (vq == NULL)
return -1;
+ if (!rte_spinlock_trylock(&vq->access_lock))
+ return -1;
+
+ if (unlikely(!vq->access_ok))
+ goto out_unlock;
+
if (vq_is_packed(dev)) {
struct vring_packed_desc *desc;
desc = vq->desc_packed;
@@ -2090,6 +2096,11 @@ rte_vhost_get_monitor_addr(int vid, uint16_t
queue_id,
}
return 0; <== We miss an unlock here
+
+out_unlock:
+ rte_spinlock_unlock(&vq->access_lock);
+
+ return -1;
}
The original patch does it like this:
}
- return 0;
+out_unlock:
+ rte_rwlock_read_unlock(&vq->access_lock);
+
+ return ret;
}
2. Some unrelated change is introduced:
@@ -2157,6 +2168,7 @@ int rte_vhost_vring_stats_reset(int vid, uint16_t
queue_id)
{
struct virtio_net *dev = get_device(vid);
struct vhost_virtqueue *vq;
+ int ret = 0;
if (dev == NULL)
return -1;
Above change fixes a build issue introduce in an earlier patch.
How do you want to proceed? Do you want a patch on top of 22.11.4?
Regards,
Maxime
>>
>> # Basic Intel(R) NIC testing
>> * Build & CFLAG compile: cover the build test combination with latest GCC/Clang
>> version and the popular OS revision such as
>> Ubuntu20.04, Ubuntu22.04, Fedora38, RHEL8.7, RHEL9.2, FreeBSD13.2, SUSE15,
>> CentOS7.9, openEuler22.03-SP1，OpenAnolis8.8 etc.
>> - All test done. No new dpdk issue is found.
>> * PF(i40e, ixgbe): test scenarios including
>> RTE_FLOW/TSO/Jumboframe/checksum offload/VLAN/VXLAN, etc.
>> - All test done. No new dpdk issue is found.
>> * VF(i40e, ixgbe): test scenarios including VF-
>> RTE_FLOW/TSO/Jumboframe/checksum offload/VLAN/VXLAN, etc.
>>
>> - All test done. No new dpdk issue is found.
>> * PF/VF(ice): test scenarios including Switch features/Package Management/Flow
>> Director/Advanced Tx/Advanced RSS/ACL/DCF/Flexible Descriptor, etc.
>> - All test done. No new dpdk issue is found.
>> * Intel NIC single core/NIC performance: test scenarios including PF/VF single
>> core performance test, etc.
>> - All test done. No new dpdk issue is found.
>> * IPsec: test scenarios including ipsec/ipsec-gw/ipsec library basic test -
>> QAT&SW/FIB library, etc.
>> - All test done. No new dpdk issue is found.
>>
>> # Basic cryptodev and virtio testing
>> * Virtio: both function and performance test are covered. Such as
>> PVP/Virtio_loopback/virtio-user loopback/virtio-net VM2VM perf
>> testing/VMAWARE ESXI 8.0, etc.
>> - All test done. found 1 new issue.
>> * Cryptodev:
>> *Function test: test scenarios including Cryptodev API testing/CompressDev ISA-
>> L/QAT/ZLIB PMD Testing/FIPS, etc.
>> - All test done. No new dpdk issue is found.
>> *Performance test: test scenarios including Thoughput Performance/Cryptodev
>> Latency, etc.
>> - All test done. No new dpdk issue is found.
>>
>>
>> Regards,
>> Xu, Hailin
>>
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* RE: 22.11.4 patches review and test
2024-01-11 8:26 ` Maxime Coquelin
@ 2024-01-11 8:44 ` Xueming(Steven) Li
2024-01-11 8:52 ` Maxime Coquelin
0 siblings, 1 reply; 10+ messages in thread
From: Xueming(Steven) Li @ 2024-01-11 8:44 UTC (permalink / raw)
To: Maxime Coquelin, Xu, HailinX
Cc: dev, Abhishek Marathe, Ali Alnubani, benjamin.walker, stable,
David Christensen, Hemant Agrawal, Stokes, Ian, Jerin Jacob,
Mcnamara, John, Ju-Hyoung Lee, Kevin Traynor, Luca Boccassi,
Pei Zhang, qian.q.xu, Raslan Darawsheh,
NBU-Contact-Thomas Monjalon (EXTERNAL),
Yanghang Liu, yuan.peng, zhaoyan.chen
> -----Original Message-----
> From: Maxime Coquelin <maxime.coquelin@redhat.com>
> Sent: 1/11/2024 16:27
> To: Xueming(Steven) Li <xuemingl@nvidia.com>; Xu, HailinX
> <hailinx.xu@intel.com>
> Cc: dev@dpdk.org; Abhishek Marathe <Abhishek.Marathe@microsoft.com>; Ali
> Alnubani <alialnu@nvidia.com>; benjamin.walker@intel.com; stable@dpdk.org;
> David Christensen <drc@linux.vnet.ibm.com>; Hemant Agrawal
> <hemant.agrawal@nxp.com>; Stokes, Ian <ian.stokes@intel.com>; Jerin Jacob
> <jerinj@marvell.com>; Mcnamara, John <john.mcnamara@intel.com>; Ju-
> Hyoung Lee <juhlee@microsoft.com>; Kevin Traynor <ktraynor@redhat.com>;
> Luca Boccassi <bluca@debian.org>; Pei Zhang <pezhang@redhat.com>;
> qian.q.xu@intel.com; Raslan Darawsheh <rasland@nvidia.com>; NBU-Contact-
> Thomas Monjalon (EXTERNAL) <thomas@monjalon.net>; Yanghang Liu
> <yanghliu@redhat.com>; yuan.peng@intel.com; zhaoyan.chen@intel.com
> Subject: Re: 22.11.4 patches review and test
>
> Hi,
>
> On 1/11/24 07:32, Xueming(Steven) Li wrote:
> > Hi Hainlin,
> >
> > Thanks very much for test test and report!
> > Let me know once any progress with the known issue.
> >
> > Thanks,
> > Xueming.
> >
> >> -----Original Message-----
> >> From: Xu, HailinX <hailinx.xu@intel.com>
> >> Sent: 1/11/2024 9:42
> >> To: Xueming(Steven) Li <xuemingl@nvidia.com>; stable@dpdk.org
> >> Cc: dev@dpdk.org; Abhishek Marathe <Abhishek.Marathe@microsoft.com>;
> >> Ali Alnubani <alialnu@nvidia.com>; benjamin.walker@intel.com; David
> >> Christensen <drc@linux.vnet.ibm.com>; Hemant Agrawal
> >> <hemant.agrawal@nxp.com>; Stokes, Ian <ian.stokes@intel.com>; Jerin
> >> Jacob <jerinj@marvell.com>; Mcnamara, John <john.mcnamara@intel.com>;
> >> Ju-Hyoung Lee <juhlee@microsoft.com>; Kevin Traynor
> >> <ktraynor@redhat.com>; Luca Boccassi <bluca@debian.org>; Pei Zhang
> >> <pezhang@redhat.com>; qian.q.xu@intel.com; Raslan Darawsheh
> >> <rasland@nvidia.com>; NBU-Contact-Thomas Monjalon
> >> (EXTERNAL) <thomas@monjalon.net>; Yanghang Liu <yanghliu@redhat.com>;
> >> yuan.peng@intel.com; zhaoyan.chen@intel.com
> >> Subject: RE: 22.11.4 patches review and test
> >>
> >>> -----Original Message-----
> >>> From: Xueming Li <xuemingl@nvidia.com>
> >>> Sent: Wednesday, December 20, 2023 3:19 PM
> >>> To: stable@dpdk.org
> >>> Cc: xuemingl@nvidia.com; dev@dpdk.org; Abhishek Marathe
> >>> <Abhishek.Marathe@microsoft.com>; Ali Alnubani <alialnu@nvidia.com>;
> >>> benjamin.walker@intel.com; David Christensen
> >>> <drc@linux.vnet.ibm.com>; Hemant Agrawal <hemant.agrawal@nxp.com>;
> >>> Stokes, Ian <ian.stokes@intel.com>; Jerin Jacob
> >>> <jerinj@marvell.com>; Mcnamara, John <john.mcnamara@intel.com>;
> >>> Ju-Hyoung Lee <juhlee@microsoft.com>; Kevin Traynor
> >>> <ktraynor@redhat.com>; Luca Boccassi <bluca@debian.org>; Pei Zhang
> >>> <pezhang@redhat.com>; qian.q.xu@intel.com; Raslan Darawsheh
> >>> <rasland@nvidia.com>; Thomas Monjalon <thomas@monjalon.net>;
> >>> Yanghang Liu <yanghliu@redhat.com>; yuan.peng@intel.com;
> >>> zhaoyan.chen@intel.com
> >>> Subject: 22.11.4 patches review and test
> >>>
> >>> Hi all,
> >>>
> >>> Here is a list of patches targeted for stable release 22.11.4.
> >>>
> >>> The planned date for the final release is 5th January.
> >>>
> >>> Please help with testing and validation of your use cases and report
> >>> any issues/results with reply-all to this mail. For the final
> >>> release the fixes and reported validations will be added to the release notes.
> >>>
> >>> A release candidate tarball can be found at:
> >>>
> >>> https://dpdk.org/browse/dpdk-stable/tag/?id=v22.11.4-rc3
> >>>
> >>> These patches are located at branch 22.11 of dpdk-stable repo:
> >>> https://dpdk.org/browse/dpdk-stable/
> >>>
> >>> Thanks.
> >>>
> >>> Xueming Li <xuemingl@nvidia.com>
> >>
> >> Update the test status for Intel part. dpdk22.11.4-rc3 all validation test done.
> >> Found 1 virtio bug.
> >>
> >> new issue:
> >> https://bugs.dpdk.org/show_bug.cgi?id=1338: virtio-user can't receive packet:
> >> this test only on SPR -Intel(R) Xeon(R) Platinum 8490H --Intel
> >> development is investigating
> >
> > Maxime, seems the issue related to patch "vhost: fix checking
> > virtqueue access in stats API", Could you please take a look?
>
> I will reply in the Bz, but there seems to be 2 backporting issues:
>
> 1. We miss the unlock on return 0:
>
> diff --git a/lib/vhost/vhost.c b/lib/vhost/vhost.c index 4edb76d0dd..6e1bba4391
> 100644
> --- a/lib/vhost/vhost.c
> +++ b/lib/vhost/vhost.c
> @@ -2070,6 +2070,12 @@ rte_vhost_get_monitor_addr(int vid, uint16_t
> queue_id,
> if (vq == NULL)
> return -1;
>
> + if (!rte_spinlock_trylock(&vq->access_lock))
> + return -1;
> +
> + if (unlikely(!vq->access_ok))
> + goto out_unlock;
> +
> if (vq_is_packed(dev)) {
> struct vring_packed_desc *desc;
> desc = vq->desc_packed;
> @@ -2090,6 +2096,11 @@ rte_vhost_get_monitor_addr(int vid, uint16_t
> queue_id,
> }
>
> return 0; <== We miss an unlock here
> +
> +out_unlock:
> + rte_spinlock_unlock(&vq->access_lock);
> +
> + return -1;
> }
>
> The original patch does it like this:
>
> }
>
> - return 0;
> +out_unlock:
> + rte_rwlock_read_unlock(&vq->access_lock);
> +
> + return ret;
> }
>
>
> 2. Some unrelated change is introduced:
>
> @@ -2157,6 +2168,7 @@ int rte_vhost_vring_stats_reset(int vid, uint16_t
> queue_id)
> {
> struct virtio_net *dev = get_device(vid);
> struct vhost_virtqueue *vq;
> + int ret = 0;
>
> if (dev == NULL)
> return -1;
>
> Above change fixes a build issue introduce in an earlier patch.
>
> How do you want to proceed? Do you want a patch on top of 22.11.4?
Thanks for the prompt response, let's have a patch on top of 22.11.4.
>
> Regards,
> Maxime
>
> >>
> >> # Basic Intel(R) NIC testing
> >> * Build & CFLAG compile: cover the build test combination with latest
> GCC/Clang
> >> version and the popular OS revision such as
> >> Ubuntu20.04, Ubuntu22.04, Fedora38, RHEL8.7, RHEL9.2, FreeBSD13.2,
> SUSE15,
> >> CentOS7.9, openEuler22.03-SP1，OpenAnolis8.8 etc.
> >> - All test done. No new dpdk issue is found.
> >> * PF(i40e, ixgbe): test scenarios including
> >> RTE_FLOW/TSO/Jumboframe/checksum offload/VLAN/VXLAN, etc.
> >> - All test done. No new dpdk issue is found.
> >> * VF(i40e, ixgbe): test scenarios including VF-
> >> RTE_FLOW/TSO/Jumboframe/checksum offload/VLAN/VXLAN, etc.
> >>
> >> - All test done. No new dpdk issue is found.
> >> * PF/VF(ice): test scenarios including Switch features/Package
> Management/Flow
> >> Director/Advanced Tx/Advanced RSS/ACL/DCF/Flexible Descriptor, etc.
> >> - All test done. No new dpdk issue is found.
> >> * Intel NIC single core/NIC performance: test scenarios including PF/VF single
> >> core performance test, etc.
> >> - All test done. No new dpdk issue is found.
> >> * IPsec: test scenarios including ipsec/ipsec-gw/ipsec library basic test -
> >> QAT&SW/FIB library, etc.
> >> - All test done. No new dpdk issue is found.
> >>
> >> # Basic cryptodev and virtio testing
> >> * Virtio: both function and performance test are covered. Such as
> >> PVP/Virtio_loopback/virtio-user loopback/virtio-net VM2VM perf
> >> testing/VMAWARE ESXI 8.0, etc.
> >> - All test done. found 1 new issue.
> >> * Cryptodev:
> >> *Function test: test scenarios including Cryptodev API testing/CompressDev
> ISA-
> >> L/QAT/ZLIB PMD Testing/FIPS, etc.
> >> - All test done. No new dpdk issue is found.
> >> *Performance test: test scenarios including Thoughput
> Performance/Cryptodev
> >> Latency, etc.
> >> - All test done. No new dpdk issue is found.
> >>
> >>
> >> Regards,
> >> Xu, Hailin
> >>
> >
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: 22.11.4 patches review and test
2024-01-11 8:44 ` Xueming(Steven) Li
@ 2024-01-11 8:52 ` Maxime Coquelin
0 siblings, 0 replies; 10+ messages in thread
From: Maxime Coquelin @ 2024-01-11 8:52 UTC (permalink / raw)
To: Xueming(Steven) Li, Xu, HailinX
Cc: dev, Abhishek Marathe, Ali Alnubani, benjamin.walker, stable,
David Christensen, Hemant Agrawal, Stokes, Ian, Jerin Jacob,
Mcnamara, John, Ju-Hyoung Lee, Kevin Traynor, Luca Boccassi,
Pei Zhang, qian.q.xu, Raslan Darawsheh,
NBU-Contact-Thomas Monjalon (EXTERNAL),
Yanghang Liu, yuan.peng, zhaoyan.chen
On 1/11/24 09:44, Xueming(Steven) Li wrote:
>
>
>> -----Original Message-----
>> From: Maxime Coquelin <maxime.coquelin@redhat.com>
>> Sent: 1/11/2024 16:27
>> To: Xueming(Steven) Li <xuemingl@nvidia.com>; Xu, HailinX
>> <hailinx.xu@intel.com>
>> Cc: dev@dpdk.org; Abhishek Marathe <Abhishek.Marathe@microsoft.com>; Ali
>> Alnubani <alialnu@nvidia.com>; benjamin.walker@intel.com; stable@dpdk.org;
>> David Christensen <drc@linux.vnet.ibm.com>; Hemant Agrawal
>> <hemant.agrawal@nxp.com>; Stokes, Ian <ian.stokes@intel.com>; Jerin Jacob
>> <jerinj@marvell.com>; Mcnamara, John <john.mcnamara@intel.com>; Ju-
>> Hyoung Lee <juhlee@microsoft.com>; Kevin Traynor <ktraynor@redhat.com>;
>> Luca Boccassi <bluca@debian.org>; Pei Zhang <pezhang@redhat.com>;
>> qian.q.xu@intel.com; Raslan Darawsheh <rasland@nvidia.com>; NBU-Contact-
>> Thomas Monjalon (EXTERNAL) <thomas@monjalon.net>; Yanghang Liu
>> <yanghliu@redhat.com>; yuan.peng@intel.com; zhaoyan.chen@intel.com
>> Subject: Re: 22.11.4 patches review and test
>>
>> Hi,
>>
>> On 1/11/24 07:32, Xueming(Steven) Li wrote:
>>> Hi Hainlin,
>>>
>>> Thanks very much for test test and report!
>>> Let me know once any progress with the known issue.
>>>
>>> Thanks,
>>> Xueming.
>>>
>>>> -----Original Message-----
>>>> From: Xu, HailinX <hailinx.xu@intel.com>
>>>> Sent: 1/11/2024 9:42
>>>> To: Xueming(Steven) Li <xuemingl@nvidia.com>; stable@dpdk.org
>>>> Cc: dev@dpdk.org; Abhishek Marathe <Abhishek.Marathe@microsoft.com>;
>>>> Ali Alnubani <alialnu@nvidia.com>; benjamin.walker@intel.com; David
>>>> Christensen <drc@linux.vnet.ibm.com>; Hemant Agrawal
>>>> <hemant.agrawal@nxp.com>; Stokes, Ian <ian.stokes@intel.com>; Jerin
>>>> Jacob <jerinj@marvell.com>; Mcnamara, John <john.mcnamara@intel.com>;
>>>> Ju-Hyoung Lee <juhlee@microsoft.com>; Kevin Traynor
>>>> <ktraynor@redhat.com>; Luca Boccassi <bluca@debian.org>; Pei Zhang
>>>> <pezhang@redhat.com>; qian.q.xu@intel.com; Raslan Darawsheh
>>>> <rasland@nvidia.com>; NBU-Contact-Thomas Monjalon
>>>> (EXTERNAL) <thomas@monjalon.net>; Yanghang Liu <yanghliu@redhat.com>;
>>>> yuan.peng@intel.com; zhaoyan.chen@intel.com
>>>> Subject: RE: 22.11.4 patches review and test
>>>>
>>>>> -----Original Message-----
>>>>> From: Xueming Li <xuemingl@nvidia.com>
>>>>> Sent: Wednesday, December 20, 2023 3:19 PM
>>>>> To: stable@dpdk.org
>>>>> Cc: xuemingl@nvidia.com; dev@dpdk.org; Abhishek Marathe
>>>>> <Abhishek.Marathe@microsoft.com>; Ali Alnubani <alialnu@nvidia.com>;
>>>>> benjamin.walker@intel.com; David Christensen
>>>>> <drc@linux.vnet.ibm.com>; Hemant Agrawal <hemant.agrawal@nxp.com>;
>>>>> Stokes, Ian <ian.stokes@intel.com>; Jerin Jacob
>>>>> <jerinj@marvell.com>; Mcnamara, John <john.mcnamara@intel.com>;
>>>>> Ju-Hyoung Lee <juhlee@microsoft.com>; Kevin Traynor
>>>>> <ktraynor@redhat.com>; Luca Boccassi <bluca@debian.org>; Pei Zhang
>>>>> <pezhang@redhat.com>; qian.q.xu@intel.com; Raslan Darawsheh
>>>>> <rasland@nvidia.com>; Thomas Monjalon <thomas@monjalon.net>;
>>>>> Yanghang Liu <yanghliu@redhat.com>; yuan.peng@intel.com;
>>>>> zhaoyan.chen@intel.com
>>>>> Subject: 22.11.4 patches review and test
>>>>>
>>>>> Hi all,
>>>>>
>>>>> Here is a list of patches targeted for stable release 22.11.4.
>>>>>
>>>>> The planned date for the final release is 5th January.
>>>>>
>>>>> Please help with testing and validation of your use cases and report
>>>>> any issues/results with reply-all to this mail. For the final
>>>>> release the fixes and reported validations will be added to the release notes.
>>>>>
>>>>> A release candidate tarball can be found at:
>>>>>
>>>>> https://dpdk.org/browse/dpdk-stable/tag/?id=v22.11.4-rc3
>>>>>
>>>>> These patches are located at branch 22.11 of dpdk-stable repo:
>>>>> https://dpdk.org/browse/dpdk-stable/
>>>>>
>>>>> Thanks.
>>>>>
>>>>> Xueming Li <xuemingl@nvidia.com>
>>>>
>>>> Update the test status for Intel part. dpdk22.11.4-rc3 all validation test done.
>>>> Found 1 virtio bug.
>>>>
>>>> new issue:
>>>> https://bugs.dpdk.org/show_bug.cgi?id=1338: virtio-user can't receive packet:
>>>> this test only on SPR -Intel(R) Xeon(R) Platinum 8490H --Intel
>>>> development is investigating
>>>
>>> Maxime, seems the issue related to patch "vhost: fix checking
>>> virtqueue access in stats API", Could you please take a look?
>>
>> I will reply in the Bz, but there seems to be 2 backporting issues:
>>
>> 1. We miss the unlock on return 0:
>>
>> diff --git a/lib/vhost/vhost.c b/lib/vhost/vhost.c index 4edb76d0dd..6e1bba4391
>> 100644
>> --- a/lib/vhost/vhost.c
>> +++ b/lib/vhost/vhost.c
>> @@ -2070,6 +2070,12 @@ rte_vhost_get_monitor_addr(int vid, uint16_t
>> queue_id,
>> if (vq == NULL)
>> return -1;
>>
>> + if (!rte_spinlock_trylock(&vq->access_lock))
>> + return -1;
>> +
>> + if (unlikely(!vq->access_ok))
>> + goto out_unlock;
>> +
>> if (vq_is_packed(dev)) {
>> struct vring_packed_desc *desc;
>> desc = vq->desc_packed;
>> @@ -2090,6 +2096,11 @@ rte_vhost_get_monitor_addr(int vid, uint16_t
>> queue_id,
>> }
>>
>> return 0; <== We miss an unlock here
>> +
>> +out_unlock:
>> + rte_spinlock_unlock(&vq->access_lock);
>> +
>> + return -1;
>> }
>>
>> The original patch does it like this:
>>
>> }
>>
>> - return 0;
>> +out_unlock:
>> + rte_rwlock_read_unlock(&vq->access_lock);
>> +
>> + return ret;
>> }
>>
>>
>> 2. Some unrelated change is introduced:
>>
>> @@ -2157,6 +2168,7 @@ int rte_vhost_vring_stats_reset(int vid, uint16_t
>> queue_id)
>> {
>> struct virtio_net *dev = get_device(vid);
>> struct vhost_virtqueue *vq;
>> + int ret = 0;
>>
>> if (dev == NULL)
>> return -1;
>>
>> Above change fixes a build issue introduce in an earlier patch.
>>
>> How do you want to proceed? Do you want a patch on top of 22.11.4?
>
> Thanks for the prompt response, let's have a patch on top of 22.11.4.
I see it has also been changed from rte_rwlock_read_lock() to
rte_spinlock_trylock(), will fix it also.
>
>>
>> Regards,
>> Maxime
>>
>>>>
>>>> # Basic Intel(R) NIC testing
>>>> * Build & CFLAG compile: cover the build test combination with latest
>> GCC/Clang
>>>> version and the popular OS revision such as
>>>> Ubuntu20.04, Ubuntu22.04, Fedora38, RHEL8.7, RHEL9.2, FreeBSD13.2,
>> SUSE15,
>>>> CentOS7.9, openEuler22.03-SP1，OpenAnolis8.8 etc.
>>>> - All test done. No new dpdk issue is found.
>>>> * PF(i40e, ixgbe): test scenarios including
>>>> RTE_FLOW/TSO/Jumboframe/checksum offload/VLAN/VXLAN, etc.
>>>> - All test done. No new dpdk issue is found.
>>>> * VF(i40e, ixgbe): test scenarios including VF-
>>>> RTE_FLOW/TSO/Jumboframe/checksum offload/VLAN/VXLAN, etc.
>>>>
>>>> - All test done. No new dpdk issue is found.
>>>> * PF/VF(ice): test scenarios including Switch features/Package
>> Management/Flow
>>>> Director/Advanced Tx/Advanced RSS/ACL/DCF/Flexible Descriptor, etc.
>>>> - All test done. No new dpdk issue is found.
>>>> * Intel NIC single core/NIC performance: test scenarios including PF/VF single
>>>> core performance test, etc.
>>>> - All test done. No new dpdk issue is found.
>>>> * IPsec: test scenarios including ipsec/ipsec-gw/ipsec library basic test -
>>>> QAT&SW/FIB library, etc.
>>>> - All test done. No new dpdk issue is found.
>>>>
>>>> # Basic cryptodev and virtio testing
>>>> * Virtio: both function and performance test are covered. Such as
>>>> PVP/Virtio_loopback/virtio-user loopback/virtio-net VM2VM perf
>>>> testing/VMAWARE ESXI 8.0, etc.
>>>> - All test done. found 1 new issue.
>>>> * Cryptodev:
>>>> *Function test: test scenarios including Cryptodev API testing/CompressDev
>> ISA-
>>>> L/QAT/ZLIB PMD Testing/FIPS, etc.
>>>> - All test done. No new dpdk issue is found.
>>>> *Performance test: test scenarios including Thoughput
>> Performance/Cryptodev
>>>> Latency, etc.
>>>> - All test done. No new dpdk issue is found.
>>>>
>>>>
>>>> Regards,
>>>> Xu, Hailin
>>>>
>>>
>
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2024-01-11 8:52 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-20 7:19 22.11.4 patches review and test Xueming Li
2023-12-27 8:17 ` YangHang Liu
2023-12-27 8:26 ` Xueming(Steven) Li
2024-01-03 14:41 ` Ali Alnubani
2024-01-04 6:16 ` Xueming(Steven) Li
2024-01-11 1:42 ` Xu, HailinX
2024-01-11 6:32 ` Xueming(Steven) Li
2024-01-11 8:26 ` Maxime Coquelin
2024-01-11 8:44 ` Xueming(Steven) Li
2024-01-11 8:52 ` Maxime Coquelin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).