DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] mlx5: add ConnectX-7 and Bluefield-3 device IDs
@ 2020-10-26 11:41 Raslan Darawsheh
  2020-10-26 13:39 ` Slava Ovsiienko
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Raslan Darawsheh @ 2020-10-26 11:41 UTC (permalink / raw)
  To: dev; +Cc: matan, viacheslavo, shys

This adds the ConnectX-7 and Bluefield-3 device ids to the list of
supported Mellanox devices that run the MLX5 PMDs.
The devices is still in development stage.

Signed-off-by: Raslan Darawsheh <rasland@nvidia.com>
---
 drivers/common/mlx5/mlx5_common.h | 2 ++
 drivers/net/mlx5/mlx5.c           | 8 ++++++++
 drivers/regex/mlx5/mlx5_regex.c   | 4 ++++
 drivers/vdpa/mlx5/mlx5_vdpa.c     | 8 ++++++++
 4 files changed, 22 insertions(+)

diff --git a/drivers/common/mlx5/mlx5_common.h b/drivers/common/mlx5/mlx5_common.h
index ed44a45a81..93985bf2c9 100644
--- a/drivers/common/mlx5/mlx5_common.h
+++ b/drivers/common/mlx5/mlx5_common.h
@@ -132,6 +132,8 @@ enum {
 	PCI_DEVICE_ID_MELLANOX_CONNECTX6DXVF = 0x101e,
 	PCI_DEVICE_ID_MELLANOX_CONNECTX6DXBF = 0xa2d6,
 	PCI_DEVICE_ID_MELLANOX_CONNECTX6LX = 0x101f,
+	PCI_DEVICE_ID_MELLANOX_CONNECTX7 = 0x1021,
+	PCI_DEVICE_ID_MELLANOX_CONNECTX7BF = 0Xa2dc,
 };
 
 /* Maximum number of simultaneous unicast MAC addresses. */
diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c
index 77aeac85c5..0316253ca8 100644
--- a/drivers/net/mlx5/mlx5.c
+++ b/drivers/net/mlx5/mlx5.c
@@ -2122,6 +2122,14 @@ static const struct rte_pci_id mlx5_pci_id_map[] = {
 		RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX,
 				PCI_DEVICE_ID_MELLANOX_CONNECTX6LX)
 	},
+	{
+		RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX,
+				PCI_DEVICE_ID_MELLANOX_CONNECTX7)
+	},
+	{
+		RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX,
+				PCI_DEVICE_ID_MELLANOX_CONNECTX7BF)
+	},
 	{
 		.vendor_id = 0
 	}
diff --git a/drivers/regex/mlx5/mlx5_regex.c b/drivers/regex/mlx5/mlx5_regex.c
index 35e8ea0a9a..17590b937c 100644
--- a/drivers/regex/mlx5/mlx5_regex.c
+++ b/drivers/regex/mlx5/mlx5_regex.c
@@ -254,6 +254,10 @@ static const struct rte_pci_id mlx5_regex_pci_id_map[] = {
 		RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX,
 				PCI_DEVICE_ID_MELLANOX_CONNECTX6DXBF)
 	},
+	{
+		RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX,
+				PCI_DEVICE_ID_MELLANOX_CONNECTX7BF)
+	},
 	{
 		.vendor_id = 0
 	}
diff --git a/drivers/vdpa/mlx5/mlx5_vdpa.c b/drivers/vdpa/mlx5/mlx5_vdpa.c
index a8f3e4b1de..2d88633bfd 100644
--- a/drivers/vdpa/mlx5/mlx5_vdpa.c
+++ b/drivers/vdpa/mlx5/mlx5_vdpa.c
@@ -825,6 +825,14 @@ static const struct rte_pci_id mlx5_vdpa_pci_id_map[] = {
 		RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX,
 				PCI_DEVICE_ID_MELLANOX_CONNECTX6DXBF)
 	},
+	{
+		RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX,
+				PCI_DEVICE_ID_MELLANOX_CONNECTX7)
+	},
+	{
+		RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX,
+				PCI_DEVICE_ID_MELLANOX_CONNECTX7BF)
+	},
 	{
 		.vendor_id = 0
 	}
-- 
2.17.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [PATCH] mlx5: add ConnectX-7 and Bluefield-3 device IDs
  2020-10-26 11:41 [dpdk-dev] [PATCH] mlx5: add ConnectX-7 and Bluefield-3 device IDs Raslan Darawsheh
@ 2020-10-26 13:39 ` Slava Ovsiienko
  2020-10-27  7:25 ` Raslan Darawsheh
  2020-10-29 15:26 ` Ferruh Yigit
  2 siblings, 0 replies; 6+ messages in thread
From: Slava Ovsiienko @ 2020-10-26 13:39 UTC (permalink / raw)
  To: Raslan Darawsheh, dev; +Cc: Matan Azrad, Shy Shyman

> -----Original Message-----
> From: Raslan Darawsheh <rasland@nvidia.com>
> Sent: Monday, October 26, 2020 13:42
> To: dev@dpdk.org
> Cc: Matan Azrad <matan@nvidia.com>; Slava Ovsiienko
> <viacheslavo@nvidia.com>; Shy Shyman <shys@nvidia.com>
> Subject: [PATCH] mlx5: add ConnectX-7 and Bluefield-3 device IDs
> 
> This adds the ConnectX-7 and Bluefield-3 device ids to the list of supported
> Mellanox devices that run the MLX5 PMDs.
> The devices is still in development stage.
> 
> Signed-off-by: Raslan Darawsheh <rasland@nvidia.com>
> ---
Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [PATCH] mlx5: add ConnectX-7 and Bluefield-3 device IDs
  2020-10-26 11:41 [dpdk-dev] [PATCH] mlx5: add ConnectX-7 and Bluefield-3 device IDs Raslan Darawsheh
  2020-10-26 13:39 ` Slava Ovsiienko
@ 2020-10-27  7:25 ` Raslan Darawsheh
  2020-10-29 15:26 ` Ferruh Yigit
  2 siblings, 0 replies; 6+ messages in thread
From: Raslan Darawsheh @ 2020-10-27  7:25 UTC (permalink / raw)
  To: Raslan Darawsheh, dev; +Cc: Matan Azrad, Slava Ovsiienko, Shy Shyman

Hi,

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Raslan Darawsheh
> Sent: Monday, October 26, 2020 1:42 PM
> To: dev@dpdk.org
> Cc: Matan Azrad <matan@nvidia.com>; Slava Ovsiienko
> <viacheslavo@nvidia.com>; Shy Shyman <shys@nvidia.com>
> Subject: [dpdk-dev] [PATCH] mlx5: add ConnectX-7 and Bluefield-3 device
> IDs
> 
> This adds the ConnectX-7 and Bluefield-3 device ids to the list of
> supported Mellanox devices that run the MLX5 PMDs.
> The devices is still in development stage.
> 
> Signed-off-by: Raslan Darawsheh <rasland@nvidia.com>
> ---
>  drivers/common/mlx5/mlx5_common.h | 2 ++
>  drivers/net/mlx5/mlx5.c           | 8 ++++++++
>  drivers/regex/mlx5/mlx5_regex.c   | 4 ++++
>  drivers/vdpa/mlx5/mlx5_vdpa.c     | 8 ++++++++
>  4 files changed, 22 insertions(+)
> 
> diff --git a/drivers/common/mlx5/mlx5_common.h
> b/drivers/common/mlx5/mlx5_common.h
> index ed44a45a81..93985bf2c9 100644
> --- a/drivers/common/mlx5/mlx5_common.h
> +++ b/drivers/common/mlx5/mlx5_common.h
> @@ -132,6 +132,8 @@ enum {
>  	PCI_DEVICE_ID_MELLANOX_CONNECTX6DXVF = 0x101e,
>  	PCI_DEVICE_ID_MELLANOX_CONNECTX6DXBF = 0xa2d6,
>  	PCI_DEVICE_ID_MELLANOX_CONNECTX6LX = 0x101f,
> +	PCI_DEVICE_ID_MELLANOX_CONNECTX7 = 0x1021,
> +	PCI_DEVICE_ID_MELLANOX_CONNECTX7BF = 0Xa2dc,
>  };
> 
>  /* Maximum number of simultaneous unicast MAC addresses. */
> diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c
> index 77aeac85c5..0316253ca8 100644
> --- a/drivers/net/mlx5/mlx5.c
> +++ b/drivers/net/mlx5/mlx5.c
> @@ -2122,6 +2122,14 @@ static const struct rte_pci_id mlx5_pci_id_map[] =
> {
>  		RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX,
>  				PCI_DEVICE_ID_MELLANOX_CONNECTX6LX)
>  	},
> +	{
> +		RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX,
> +				PCI_DEVICE_ID_MELLANOX_CONNECTX7)
> +	},
> +	{
> +		RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX,
> +				PCI_DEVICE_ID_MELLANOX_CONNECTX7BF)
> +	},
>  	{
>  		.vendor_id = 0
>  	}
> diff --git a/drivers/regex/mlx5/mlx5_regex.c
> b/drivers/regex/mlx5/mlx5_regex.c
> index 35e8ea0a9a..17590b937c 100644
> --- a/drivers/regex/mlx5/mlx5_regex.c
> +++ b/drivers/regex/mlx5/mlx5_regex.c
> @@ -254,6 +254,10 @@ static const struct rte_pci_id
> mlx5_regex_pci_id_map[] = {
>  		RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX,
> 
> 	PCI_DEVICE_ID_MELLANOX_CONNECTX6DXBF)
>  	},
> +	{
> +		RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX,
> +				PCI_DEVICE_ID_MELLANOX_CONNECTX7BF)
> +	},
>  	{
>  		.vendor_id = 0
>  	}
> diff --git a/drivers/vdpa/mlx5/mlx5_vdpa.c
> b/drivers/vdpa/mlx5/mlx5_vdpa.c
> index a8f3e4b1de..2d88633bfd 100644
> --- a/drivers/vdpa/mlx5/mlx5_vdpa.c
> +++ b/drivers/vdpa/mlx5/mlx5_vdpa.c
> @@ -825,6 +825,14 @@ static const struct rte_pci_id
> mlx5_vdpa_pci_id_map[] = {
>  		RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX,
> 
> 	PCI_DEVICE_ID_MELLANOX_CONNECTX6DXBF)
>  	},
> +	{
> +		RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX,
> +				PCI_DEVICE_ID_MELLANOX_CONNECTX7)
> +	},
> +	{
> +		RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX,
> +				PCI_DEVICE_ID_MELLANOX_CONNECTX7BF)
> +	},
>  	{
>  		.vendor_id = 0
>  	}
> --
> 2.17.1

Patch applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [PATCH] mlx5: add ConnectX-7 and Bluefield-3 device IDs
  2020-10-26 11:41 [dpdk-dev] [PATCH] mlx5: add ConnectX-7 and Bluefield-3 device IDs Raslan Darawsheh
  2020-10-26 13:39 ` Slava Ovsiienko
  2020-10-27  7:25 ` Raslan Darawsheh
@ 2020-10-29 15:26 ` Ferruh Yigit
  2020-11-01  9:08   ` Raslan Darawsheh
  2 siblings, 1 reply; 6+ messages in thread
From: Ferruh Yigit @ 2020-10-29 15:26 UTC (permalink / raw)
  To: Raslan Darawsheh, dev; +Cc: matan, viacheslavo, shys

On 10/26/2020 11:41 AM, Raslan Darawsheh wrote:
> This adds the ConnectX-7 and Bluefield-3 device ids to the list of
> supported Mellanox devices that run the MLX5 PMDs.
> The devices is still in development stage.
> 

I assume you don't want to add these new device support to the documentation or 
to the web page, but what do you think adding it to the driver documentation 
with this device under development note, or experimental support etc?

> Signed-off-by: Raslan Darawsheh <rasland@nvidia.com>

<...>


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [PATCH] mlx5: add ConnectX-7 and Bluefield-3 device IDs
  2020-10-29 15:26 ` Ferruh Yigit
@ 2020-11-01  9:08   ` Raslan Darawsheh
  2020-11-02 10:52     ` Ferruh Yigit
  0 siblings, 1 reply; 6+ messages in thread
From: Raslan Darawsheh @ 2020-11-01  9:08 UTC (permalink / raw)
  To: Ferruh Yigit, dev; +Cc: Matan Azrad, Slava Ovsiienko, Shy Shyman

Hi Ferruh,

> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit@intel.com>
> Sent: Thursday, October 29, 2020 5:26 PM
> To: Raslan Darawsheh <rasland@nvidia.com>; dev@dpdk.org
> Cc: Matan Azrad <matan@nvidia.com>; Slava Ovsiienko
> <viacheslavo@nvidia.com>; Shy Shyman <shys@nvidia.com>
> Subject: Re: [dpdk-dev] [PATCH] mlx5: add ConnectX-7 and Bluefield-3
> device IDs
> 
> On 10/26/2020 11:41 AM, Raslan Darawsheh wrote:
> > This adds the ConnectX-7 and Bluefield-3 device ids to the list of
> > supported Mellanox devices that run the MLX5 PMDs.
> > The devices is still in development stage.
> >
> 
> I assume you don't want to add these new device support to the
> documentation or
> to the web page, but what do you think adding it to the driver
> documentation
> with this device under development note, or experimental support etc?
> 
It's about that we haven't tried the PMD with these NIC's yet, so announcing that it has support for them
without knowing that we don't really have any issues (even 0 level issue) I don't think its OK to add such documentation.

I think once we'll have the proper testing done for them, we can add them to all necessary documentations

> > Signed-off-by: Raslan Darawsheh <rasland@nvidia.com>
> 
> <...>


Kindest regards,
Raslan Darawsheh

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [PATCH] mlx5: add ConnectX-7 and Bluefield-3 device IDs
  2020-11-01  9:08   ` Raslan Darawsheh
@ 2020-11-02 10:52     ` Ferruh Yigit
  0 siblings, 0 replies; 6+ messages in thread
From: Ferruh Yigit @ 2020-11-02 10:52 UTC (permalink / raw)
  To: Raslan Darawsheh, dev; +Cc: Matan Azrad, Slava Ovsiienko, Shy Shyman

On 11/1/2020 9:08 AM, Raslan Darawsheh wrote:
> Hi Ferruh,
> 
>> -----Original Message-----
>> From: Ferruh Yigit <ferruh.yigit@intel.com>
>> Sent: Thursday, October 29, 2020 5:26 PM
>> To: Raslan Darawsheh <rasland@nvidia.com>; dev@dpdk.org
>> Cc: Matan Azrad <matan@nvidia.com>; Slava Ovsiienko
>> <viacheslavo@nvidia.com>; Shy Shyman <shys@nvidia.com>
>> Subject: Re: [dpdk-dev] [PATCH] mlx5: add ConnectX-7 and Bluefield-3
>> device IDs
>>
>> On 10/26/2020 11:41 AM, Raslan Darawsheh wrote:
>>> This adds the ConnectX-7 and Bluefield-3 device ids to the list of
>>> supported Mellanox devices that run the MLX5 PMDs.
>>> The devices is still in development stage.
>>>
>>
>> I assume you don't want to add these new device support to the
>> documentation or
>> to the web page, but what do you think adding it to the driver
>> documentation
>> with this device under development note, or experimental support etc?
>>
> It's about that we haven't tried the PMD with these NIC's yet, so announcing that it has support for them
> without knowing that we don't really have any issues (even 0 level issue) I don't think its OK to add such documentation.
> 
> I think once we'll have the proper testing done for them, we can add them to all necessary documentations
> 

OK


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2020-11-02 10:52 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-26 11:41 [dpdk-dev] [PATCH] mlx5: add ConnectX-7 and Bluefield-3 device IDs Raslan Darawsheh
2020-10-26 13:39 ` Slava Ovsiienko
2020-10-27  7:25 ` Raslan Darawsheh
2020-10-29 15:26 ` Ferruh Yigit
2020-11-01  9:08   ` Raslan Darawsheh
2020-11-02 10:52     ` Ferruh Yigit

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).