From: Slava Ovsiienko <viacheslavo@nvidia.com>
To: "jiangheng (G)" <jiangheng14@huawei.com>,
"dev@dpdk.org" <dev@dpdk.org>, Matan Azrad <matan@nvidia.com>
Subject: RE: [PATCH] net/mlx5: fix lro update tcp header cksum error
Date: Wed, 12 Apr 2023 14:06:42 +0000 [thread overview]
Message-ID: <DM6PR12MB3753B438B4194BD9873A29A1DF9B9@DM6PR12MB3753.namprd12.prod.outlook.com> (raw)
In-Reply-To: <dec71b8b053a4c39b84154db5d2d9e50@huawei.com>
Hi, Jiangheng
You are right, the corner case of sum of 3 is 0x1FFFF gives the wrong result.
Could you, please, format the patch according to the rules and send v2 ?
- add Fixes: tag with reference to appropriate commit
- add Cc: stable@dpdk.org
- fix typos in commit message - capitalize sentences, add trailing points, etc.
With best regards,
Slava
> -----Original Message-----
> From: jiangheng (G) <jiangheng14@huawei.com>
> Sent: среда, 12 апреля 2023 г. 14:39
> To: dev@dpdk.org; Matan Azrad <matan@nvidia.com>; Slava Ovsiienko
> <viacheslavo@nvidia.com>
> Subject: [PATCH] net/mlx5: fix lro update tcp header cksum error
>
> csum is the sum of three 16 bits value
> it must be folded twice to ensure that the upper 16 bits are 0
> ---
> drivers/net/mlx5/mlx5_rx.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/mlx5/mlx5_rx.c b/drivers/net/mlx5/mlx5_rx.c index
> a2be523e9e..ae537dfffa 100644
> --- a/drivers/net/mlx5/mlx5_rx.c
> +++ b/drivers/net/mlx5/mlx5_rx.c
> @@ -1090,6 +1090,7 @@ mlx5_lro_update_tcp_hdr(struct rte_tcp_hdr
> *__rte_restrict tcp,
> tcp->cksum = 0;
> csum += rte_raw_cksum(tcp, (tcp->data_off >> 4) * 4);
> csum = ((csum & 0xffff0000) >> 16) + (csum & 0xffff);
> + csum = ((csum & 0xffff0000) >> 16) + (csum & 0xffff);
> csum = (~csum) & 0xffff;
> if (csum == 0)
> csum = 0xffff;
> --
> 2.27.0
prev parent reply other threads:[~2023-04-12 14:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-12 11:38 jiangheng (G)
2023-04-12 14:06 ` Slava Ovsiienko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR12MB3753B438B4194BD9873A29A1DF9B9@DM6PR12MB3753.namprd12.prod.outlook.com \
--to=viacheslavo@nvidia.com \
--cc=dev@dpdk.org \
--cc=jiangheng14@huawei.com \
--cc=matan@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).