From: Ori Kam <orika@nvidia.com> To: Alexander Kozyrev <akozyrev@nvidia.com>, "dev@dpdk.org" <dev@dpdk.org> Cc: Slava Ovsiienko <viacheslavo@nvidia.com>, NBU-Contact-Thomas Monjalon <thomas@monjalon.net>, "ferruh.yigit@intel.com" <ferruh.yigit@intel.com>, "andrew.rybchenko@oktetlabs.ru" <andrew.rybchenko@oktetlabs.ru>, "jerinjacobk@gmail.com" <jerinjacobk@gmail.com> Subject: Re: [dpdk-dev] [PATCH v5 1/2] ethdev: introduce generic modify rte flow action Date: Fri, 15 Jan 2021 18:03:34 +0000 Message-ID: <DM6PR12MB49879D93B04F2C3E6E7E4EA7D6A70@DM6PR12MB4987.namprd12.prod.outlook.com> (raw) In-Reply-To: <20210115154246.8770-2-akozyrev@nvidia.com> Hi Alexander, Small inline, but I leave it to you if you want to change it. > -----Original Message----- > From: Alexander Kozyrev <akozyrev@nvidia.com> > Sent: Friday, January 15, 2021 5:43 PM > Subject: [PATCH v5 1/2] ethdev: introduce generic modify rte flow action > > Implement the generic modify flow API to allow manipulations on > an arbitrary header field (as well as mark, metadata or tag) using > data from another field or a user-specified value. > > This generic modify mechanism removes the necessity to implement > a separate RTE Flow action every time we need to modify a new packet > field in the future. A user-provided value can be used from a > specified packet field/tag/metadata/mark/memory location or directly > provided by a user. > [Snip] > + > +enum rte_flow_modify_op { > + RTE_FLOW_MODIFY_MOV = 0, > + RTE_FLOW_MODIFY_ADD, > + RTE_FLOW_MODIFY_SUB, > +}; > + I think mov is not the best option, since we the value in src stays I think copy or set will be better. If you change it feel free to add my ack. > +/** > + * @warning > + * @b EXPERIMENTAL: this structure may change without prior notice > + * > + * RTE_FLOW_ACTION_TYPE_MODIFY_FIELD > + * > + * Modifies a destination header field according to the specified > + * operation. Another packet field can be used as a source as well > + * as tag, mark, metadata or an immediate value or a pointer to it. > + * Width is the number of bits used from the source item. > + */ > +struct rte_flow_action_modify_field { > + enum rte_flow_modify_op operation; > + struct rte_flow_action_modify_data dst; > + struct rte_flow_action_modify_data src; > + uint32_t width; > +}; > + > /* Mbuf dynamic field offset for metadata. */ > extern int32_t rte_flow_dynf_metadata_offs; > > -- > 2.24.1 Acked-by: Ori Kam <orika@nvidia.com> Best, Ori
next prev parent reply other threads:[~2021-01-15 18:03 UTC|newest] Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-01-08 6:32 [dpdk-dev] [PATCH] ethdev: introduce generic copy " Alexander Kozyrev 2021-01-10 8:00 ` Ori Kam 2021-01-10 9:36 ` Asaf Penso 2021-01-12 14:15 ` Alexander Kozyrev 2021-01-12 14:52 ` Ori Kam 2021-01-12 15:13 ` Ori Kam 2021-01-12 17:19 ` Alexander Kozyrev 2021-01-12 5:01 ` [dpdk-dev] [PATCH v2 0/2] generic copy rte flow action support Alexander Kozyrev 2021-01-12 5:01 ` [dpdk-dev] [PATCH v2 1/2] ethdev: introduce generic copy rte flow action Alexander Kozyrev 2021-01-12 5:01 ` [dpdk-dev] [PATCH v2 2/2] app/testpmd: add support for " Alexander Kozyrev 2021-01-12 14:58 ` Ori Kam 2021-01-13 3:38 ` [dpdk-dev] [PATCH v3 0/2] generic copy rte flow action support Alexander Kozyrev 2021-01-13 3:38 ` [dpdk-dev] [PATCH v3 1/2] ethdev: introduce generic copy rte flow action Alexander Kozyrev 2021-01-13 11:12 ` Ori Kam 2021-01-13 3:38 ` [dpdk-dev] [PATCH v3 2/2] app/testpmd: add support for " Alexander Kozyrev 2021-01-13 17:07 ` [dpdk-dev] [PATCH v4 0/2] generic copy rte flow action support Alexander Kozyrev 2021-01-13 17:07 ` [dpdk-dev] [PATCH v4 1/2] ethdev: introduce generic copy rte flow action Alexander Kozyrev 2021-01-14 12:22 ` Ori Kam 2021-01-13 17:07 ` [dpdk-dev] [PATCH v4 2/2] app/testpmd: add support for " Alexander Kozyrev 2021-01-14 15:18 ` Ori Kam 2021-01-15 15:37 ` Alexander Kozyrev 2021-01-15 15:42 ` [dpdk-dev] [PATCH v5 0/2] generic modify rte flow action support Alexander Kozyrev 2021-01-15 15:42 ` [dpdk-dev] [PATCH v5 1/2] ethdev: introduce generic modify rte flow action Alexander Kozyrev 2021-01-15 18:03 ` Ori Kam [this message] 2021-01-17 9:23 ` Slava Ovsiienko 2021-01-15 15:42 ` [dpdk-dev] [PATCH v5 2/2] app/testpmd: add support for modify field " Alexander Kozyrev 2021-01-15 18:04 ` Ori Kam 2021-01-16 4:44 ` [dpdk-dev] [PATCH v6 0/2] generic modify rte flow action support Alexander Kozyrev 2021-01-16 4:44 ` [dpdk-dev] [PATCH v6 1/2] ethdev: introduce generic modify rte flow action Alexander Kozyrev 2021-01-16 4:44 ` [dpdk-dev] [PATCH v6 2/2] app/testpmd: add support for modify field " Alexander Kozyrev 2021-01-16 4:50 ` [dpdk-dev] [PATCH v7 0/2] generic modify rte flow action support Alexander Kozyrev 2021-01-16 4:50 ` [dpdk-dev] [PATCH v7 1/2] ethdev: introduce generic modify rte flow action Alexander Kozyrev 2021-01-17 23:15 ` Thomas Monjalon 2021-01-18 16:03 ` Alexander Kozyrev 2021-01-16 4:50 ` [dpdk-dev] [PATCH v7 2/2] app/testpmd: add support for modify field " Alexander Kozyrev 2021-01-18 16:18 ` [dpdk-dev] [PATCH v8 0/2] generic modify rte flow action support Alexander Kozyrev 2021-01-18 16:18 ` [dpdk-dev] [PATCH v8 1/2] ethdev: introduce generic modify rte flow action Alexander Kozyrev 2021-01-18 17:51 ` Thomas Monjalon 2021-01-18 16:18 ` [dpdk-dev] [PATCH v8 2/2] app/testpmd: add support for modify field " Alexander Kozyrev 2021-01-18 20:05 ` [dpdk-dev] [PATCH v8 0/2] generic modify rte flow action support Ajit Khaparde 2021-01-18 21:40 ` [dpdk-dev] [PATCH v9 " Alexander Kozyrev 2021-01-18 21:40 ` [dpdk-dev] [PATCH v9 1/2] ethdev: introduce generic modify rte flow action Alexander Kozyrev 2021-01-18 21:40 ` [dpdk-dev] [PATCH v9 2/2] app/testpmd: add support for modify field " Alexander Kozyrev 2021-01-19 1:21 ` [dpdk-dev] [PATCH v9 0/2] generic modify rte flow action support Ferruh Yigit 2021-01-14 13:59 ` [dpdk-dev] [PATCH] ethdev: introduce generic copy rte flow action Jerin Jacob 2021-01-14 15:02 ` Ori Kam 2021-01-15 14:00 ` Jerin Jacob 2021-01-15 15:33 ` Alexander Kozyrev
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=DM6PR12MB49879D93B04F2C3E6E7E4EA7D6A70@DM6PR12MB4987.namprd12.prod.outlook.com \ --to=orika@nvidia.com \ --cc=akozyrev@nvidia.com \ --cc=andrew.rybchenko@oktetlabs.ru \ --cc=dev@dpdk.org \ --cc=ferruh.yigit@intel.com \ --cc=jerinjacobk@gmail.com \ --cc=thomas@monjalon.net \ --cc=viacheslavo@nvidia.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git