From: "Peng, ZhihongX" <zhihongx.peng@intel.com> To: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>, "david.marchand@redhat.com" <david.marchand@redhat.com>, "Burakov, Anatoly" <anatoly.burakov@intel.com>, "Ananyev, Konstantin" <konstantin.ananyev@intel.com>, "stephen@networkplumber.org" <stephen@networkplumber.org>, "Mcnamara, John" <john.mcnamara@intel.com> Cc: "dev@dpdk.org" <dev@dpdk.org>, "Lin, Xueqin" <xueqin.lin@intel.com>, "stable@dpdk.org" <stable@dpdk.org> Subject: Re: [dpdk-dev] [PATCH v10 3/4] pipeline: Fix compilation error with gcc ASan Date: Tue, 19 Oct 2021 12:11:41 +0000 Message-ID: <DM8PR11MB559166DF836A45201518CDD9F0BD9@DM8PR11MB5591.namprd11.prod.outlook.com> (raw) In-Reply-To: <DM8PR11MB567042FB2F83ED2A78989F58EBBD9@DM8PR11MB5670.namprd11.prod.outlook.com> > -----Original Message----- > From: Dumitrescu, Cristian <cristian.dumitrescu@intel.com> > Sent: Tuesday, October 19, 2021 7:26 PM > To: Peng, ZhihongX <zhihongx.peng@intel.com>; > david.marchand@redhat.com; Burakov, Anatoly > <anatoly.burakov@intel.com>; Ananyev, Konstantin > <konstantin.ananyev@intel.com>; stephen@networkplumber.org; > Mcnamara, John <john.mcnamara@intel.com> > Cc: dev@dpdk.org; Lin, Xueqin <xueqin.lin@intel.com>; stable@dpdk.org > Subject: RE: [PATCH v10 3/4] pipeline: Fix compilation error with gcc ASan > > > > > -----Original Message----- > > From: Peng, ZhihongX <zhihongx.peng@intel.com> > > Sent: Monday, October 18, 2021 1:55 PM > > To: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>; > > david.marchand@redhat.com; Burakov, Anatoly > > <anatoly.burakov@intel.com>; Ananyev, Konstantin > > <konstantin.ananyev@intel.com>; stephen@networkplumber.org; > Mcnamara, > > John <john.mcnamara@intel.com> > > Cc: dev@dpdk.org; Lin, Xueqin <xueqin.lin@intel.com>; stable@dpdk.org > > Subject: RE: [PATCH v10 3/4] pipeline: Fix compilation error with gcc > > ASan > > > > > -----Original Message----- > > > From: Dumitrescu, Cristian <cristian.dumitrescu@intel.com> > > > Sent: Monday, October 18, 2021 8:22 PM > > > To: Peng, ZhihongX <zhihongx.peng@intel.com>; > > > david.marchand@redhat.com; Burakov, Anatoly > > > <anatoly.burakov@intel.com>; Ananyev, Konstantin > > > <konstantin.ananyev@intel.com>; stephen@networkplumber.org; > > > Mcnamara, John <john.mcnamara@intel.com> > > > Cc: dev@dpdk.org; Lin, Xueqin <xueqin.lin@intel.com>; > > > stable@dpdk.org > > > Subject: RE: [PATCH v10 3/4] pipeline: Fix compilation error with > > > gcc ASan > > > > > > > > > > > > > -----Original Message----- > > > > From: Peng, ZhihongX <zhihongx.peng@intel.com> > > > > Sent: Friday, October 15, 2021 4:11 PM > > > > To: david.marchand@redhat.com; Burakov, Anatoly > > > > <anatoly.burakov@intel.com>; Ananyev, Konstantin > > > > <konstantin.ananyev@intel.com>; stephen@networkplumber.org; > > > > Dumitrescu, Cristian <cristian.dumitrescu@intel.com>; Mcnamara, > > > > John <john.mcnamara@intel.com> > > > > Cc: dev@dpdk.org; Lin, Xueqin <xueqin.lin@intel.com>; Peng, > > > > ZhihongX <zhihongx.peng@intel.com>; stable@dpdk.org > > > > Subject: [PATCH v10 3/4] pipeline: Fix compilation error with gcc > > > > ASan > > > > > > > > From: Zhihong Peng <zhihongx.peng@intel.com> > > > > > > > > The gcc will check code more stricter when ASan enabled. > > > > "Control reaches end of non-void function" error occurs here. > > > > > > > > Fixes: f38913b7fb8e ("pipeline: add meter array to SWX") > > > > Cc: stable@dpdk.org > > > > > > > > Signed-off-by: Xueqin Lin <xueqin.lin@intel.com> > > > > Signed-off-by: Zhihong Peng <zhihongx.peng@intel.com> > > > > --- > > > > v7: no change > > > > v8: no change > > > > v9: Modify the submit log > > > > v10:no change > > > > --- > > > > lib/pipeline/rte_swx_pipeline.c | 4 ++-- > > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > > > diff --git a/lib/pipeline/rte_swx_pipeline.c > > > > b/lib/pipeline/rte_swx_pipeline.c index 1cd09a4b44..0acd6c6752 > > > > 100644 > > > > --- a/lib/pipeline/rte_swx_pipeline.c > > > > +++ b/lib/pipeline/rte_swx_pipeline.c > > > > @@ -4642,7 +4642,7 @@ instr_meter_translate(struct > > > > rte_swx_pipeline > > *p, > > > > return 0; > > > > } > > > > > > > > - CHECK(0, EINVAL); > > > > + return -EINVAL; > > > > } > > > > > > > > static inline void > > > > @@ -5937,7 +5937,7 @@ instr_translate(struct rte_swx_pipeline *p, > > > > instr, > > > > data); > > > > > > > > - CHECK(0, EINVAL); > > > > + return -EINVAL; > > > > } > > > > > > > > static struct instruction_data * > > > > -- > > > > 2.25.1 > > > > > > NACK. > > > > > > This is a false issue, no bug is here. CHECK(0, EINVAL) translates > > > to an unconditional return -EINVAL. > > > Does this tool work correctly when macros are present? Maybe the > > > tool should parse the preprocessed C code as opposed to initial C code? > > > > Yes, this is not a bug, it just solves the problem that cannot be > > passed after adding the asan compiler option. > > Only part of the macro reports errors, which may be caused by the tool > > itself, but this tool is part of gcc and clang, so we still have to > > make the code not report errors. > > > Regards, > > > Cristian > > Hi Zhihong, > > If this is not a bug in the pipeline library, why then does your patch has fix in > the tile, has the Fixes label and CC-es stable@dpdk.org? Please remove and > rephrase accordingly. > > I agree this is not a bug, and based on your statements I understand this is a > sort of issue or limitation with the tool . I would prefer we fix the tool rather > than fixing correct code in order to please the tool. This is likely not going to > be an isolated case, but a recurring issue. > > Hence, I am reluctantly OK to ack this patch in order to allow the tool in (after > the "fix" claim is removed), hopefully the tool will prove its benefit to DPDK. ok, I will delete it. > Regards, > Cristian
next prev parent reply other threads:[~2021-10-19 12:11 UTC|newest] Thread overview: 117+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-09-10 2:01 [dpdk-dev] [PATCH] Enable AddressSanitizer feature on DPDK zhihongx.peng 2021-09-10 2:47 ` Stephen Hemminger 2021-09-13 5:27 ` Peng, ZhihongX 2021-09-13 15:05 ` Stephen Hemminger 2021-09-13 15:22 ` Bruce Richardson 2021-09-13 15:45 ` Stephen Hemminger 2021-09-14 3:17 ` Lin, Xueqin 2021-09-14 3:11 ` Lin, Xueqin 2021-09-10 17:58 ` David Christensen 2021-09-13 5:35 ` Peng, ZhihongX 2021-09-17 20:50 ` David Christensen 2021-09-18 7:21 ` Peng, ZhihongX 2021-09-20 19:41 ` David Christensen 2021-09-21 8:29 ` David Marchand 2021-09-21 10:15 ` Jerin Jacob 2021-09-22 7:32 ` Peng, ZhihongX 2021-09-16 1:38 ` [dpdk-dev] [PATCH v2] " zhihongx.peng 2021-09-17 8:23 ` David Marchand 2021-09-17 9:12 ` Peng, ZhihongX 2021-09-17 14:58 ` Stephen Hemminger 2021-09-18 6:36 ` Peng, ZhihongX 2021-09-18 7:41 ` [dpdk-dev] [PATCH v3] " zhihongx.peng 2021-09-20 10:03 ` David Marchand 2021-09-22 7:26 ` Peng, ZhihongX 2021-09-24 2:20 ` [dpdk-dev] [PATCH v4 1/2] Enable ASan for memory detector " zhihongx.peng 2021-09-24 2:20 ` [dpdk-dev] [PATCH v4 2/2] lib/pipeline: Fix gcc compilation error using ASan zhihongx.peng 2021-09-24 9:33 ` [dpdk-dev] [PATCH v5 1/2] Enable ASan for memory detector on DPDK zhihongx.peng 2021-09-24 9:33 ` [dpdk-dev] [PATCH v5 2/2] Fix gcc compilation error using ASan zhihongx.peng 2021-09-24 10:03 ` [dpdk-dev] [PATCH v5 1/2] Enable ASan for memory detector on DPDK zhihongx.peng 2021-09-24 10:03 ` [dpdk-dev] [PATCH v5 2/2] lib/pipeline: Fix gcc compilation error using ASan zhihongx.peng 2021-09-30 5:27 ` [dpdk-dev] [PATCH v6 1/2] Enable ASan for memory detector on DPDK zhihongx.peng 2021-09-30 5:27 ` [dpdk-dev] [PATCH v6 2/2] lib/pipeline: Fix gcc compilation error using ASan zhihongx.peng 2021-09-30 8:29 ` [dpdk-dev] [dpdk-stable] " David Marchand 2021-10-12 2:41 ` Peng, ZhihongX 2021-09-30 8:20 ` [dpdk-dev] [PATCH v6 1/2] Enable ASan for memory detector on DPDK David Marchand 2021-10-08 8:07 ` Peng, ZhihongX 2021-10-08 8:30 ` David Marchand 2021-10-12 5:41 ` Peng, ZhihongX 2021-10-12 7:17 ` Peng, ZhihongX 2021-10-13 7:59 ` Bruce Richardson 2021-10-14 6:33 ` Peng, ZhihongX 2021-10-14 6:53 ` Peng, ZhihongX 2021-09-30 12:59 ` zhihongx.peng 2021-09-30 12:59 ` [dpdk-dev] [PATCH v6 2/2] lib/pipeline: Fix compilation error with gcc ASan zhihongx.peng 2021-09-30 13:59 ` [dpdk-dev] [PATCH v6 1/2] Enable ASan for memory detector on DPDK Burakov, Anatoly 2021-09-30 18:49 ` David Marchand 2021-10-08 9:17 ` [dpdk-dev] [PATCH v7 1/3] " zhihongx.peng 2021-10-08 9:17 ` [dpdk-dev] [PATCH v7 2/3] DPDK code adapts to ASan zhihongx.peng 2021-10-08 9:17 ` [dpdk-dev] [PATCH v7 3/3] lib/pipeline: Fix compilation error with gcc ASan zhihongx.peng 2021-10-11 6:28 ` [dpdk-dev] [PATCH v8 1/3] Enable ASan for memory detector on DPDK zhihongx.peng 2021-10-11 6:28 ` [dpdk-dev] [PATCH v8 2/3] DPDK code adapts to ASan zhihongx.peng 2021-10-11 6:28 ` [dpdk-dev] [PATCH v8 3/3] lib/pipeline: Fix compilation error with gcc ASan zhihongx.peng 2021-10-12 9:43 ` [dpdk-dev] [PATCH v9 1/3] Enable ASan for memory detector on DPDK zhihongx.peng 2021-10-12 9:43 ` [dpdk-dev] [PATCH v9 2/3] DPDK code adapts to ASan zhihongx.peng 2021-10-13 16:45 ` David Marchand 2021-10-14 11:45 ` Peng, ZhihongX 2021-10-12 9:43 ` [dpdk-dev] [PATCH v9 3/3] pipeline: Fix compilation error with gcc ASan zhihongx.peng 2021-10-15 14:27 ` [dpdk-dev] [PATCH v10 1/4] Enable ASan for memory detector on DPDK zhihongx.peng 2021-10-15 14:27 ` [dpdk-dev] [PATCH v10 2/4] DPDK code adapts to ASan zhihongx.peng 2021-10-15 14:27 ` [dpdk-dev] [PATCH v10 3/4] pipeline: Fix compilation error with gcc ASan zhihongx.peng 2021-10-15 14:27 ` [dpdk-dev] [PATCH v10 4/4] performance-thread: Fix cross compilation failed zhihongx.peng 2021-10-19 9:02 ` [dpdk-dev] [PATCH v10 1/4] Enable ASan for memory detector on DPDK Mcnamara, John 2021-10-19 9:28 ` Peng, ZhihongX 2021-10-15 15:11 ` zhihongx.peng 2021-10-15 15:11 ` [dpdk-dev] [PATCH v10 2/4] DPDK code adapts to ASan zhihongx.peng 2021-10-15 15:11 ` [dpdk-dev] [PATCH v10 3/4] pipeline: Fix compilation error with gcc ASan zhihongx.peng 2021-10-18 12:21 ` Dumitrescu, Cristian 2021-10-18 12:54 ` Peng, ZhihongX 2021-10-19 11:26 ` Dumitrescu, Cristian 2021-10-19 12:11 ` Peng, ZhihongX [this message] 2021-10-15 15:11 ` [dpdk-dev] [PATCH v10 4/4] performance-thread: Fix cross compilation failed zhihongx.peng 2021-10-19 6:02 ` Peng, ZhihongX 2021-10-19 10:12 ` [dpdk-dev] [PATCH v11 1/4] Enable ASan for memory detector on DPDK zhihongx.peng 2021-10-19 10:12 ` [dpdk-dev] [PATCH v11 2/4] DPDK code adapts to ASan zhihongx.peng 2021-10-19 10:12 ` [dpdk-dev] [PATCH v11 3/4] pipeline: Fix compilation error with gcc ASan zhihongx.peng 2021-10-19 10:12 ` [dpdk-dev] [PATCH v11 4/4] performance-thread: Fix cross compilation failed zhihongx.peng 2021-10-19 10:37 ` Bruce Richardson 2021-10-19 13:04 ` [dpdk-dev] [PATCH v12 1/4] Enable ASan for memory detector on DPDK zhihongx.peng 2021-10-19 13:04 ` [dpdk-dev] [PATCH v12 2/4] DPDK code adapts to ASan zhihongx.peng 2021-10-19 13:04 ` [dpdk-dev] [PATCH v12 3/4] pipeline: Fix compilation error with gcc ASan zhihongx.peng 2021-10-19 13:04 ` [dpdk-dev] [PATCH v12 4/4] performance-thread: Fix cross compilation failed zhihongx.peng 2021-10-19 13:58 ` [dpdk-dev] [PATCH v12 1/4] Enable ASan Address Sanitization zhihongx.peng 2021-10-19 13:58 ` [dpdk-dev] [PATCH v12 2/4] DPDK code adapts to ASan zhihongx.peng 2021-10-19 13:58 ` [dpdk-dev] [PATCH v12 3/4] Code changes to avoid the ASan error zhihongx.peng 2021-10-19 14:05 ` Dumitrescu, Cristian 2021-10-19 13:58 ` [dpdk-dev] [PATCH v12 4/4] performance-thread: Fix cross compilation failed zhihongx.peng 2021-10-19 14:47 ` [dpdk-dev] [PATCH v12 1/4] Enable ASan Address Sanitization Peng, ZhihongX 2021-10-19 15:17 ` Mcnamara, John 2021-10-20 1:55 ` Peng, ZhihongX 2021-10-19 15:20 ` David Marchand 2021-10-20 2:41 ` Lin, Xueqin 2021-10-19 15:15 ` [dpdk-dev] [PATCH v12 1/4] Enable ASan AddressSanitizer zhihongx.peng 2021-10-19 15:15 ` [dpdk-dev] [PATCH v12 2/4] DPDK code adapts to ASan zhihongx.peng 2021-10-19 15:15 ` [dpdk-dev] [PATCH v12 3/4] Code changes to avoid the ASan error zhihongx.peng 2021-10-19 15:15 ` [dpdk-dev] [PATCH v12 4/4] performance-thread: Fix cross compilation failed zhihongx.peng 2021-10-20 7:46 ` [dpdk-dev] [PATCH v13 1/4] enable ASan AddressSanitizer zhihongx.peng 2021-10-20 7:46 ` [dpdk-dev] [PATCH v13 2/4] DPDK code adapts to ASan zhihongx.peng 2021-10-29 9:23 ` David Marchand 2021-10-29 12:54 ` Peng, ZhihongX 2021-10-20 7:46 ` [dpdk-dev] [PATCH v13 3/4] code changes to avoid the ASan error zhihongx.peng 2021-10-20 7:46 ` [dpdk-dev] [PATCH v13 4/4] performance-thread: avoid cross compilation fail zhihongx.peng 2021-10-25 1:58 ` [dpdk-dev] [PATCH v13 1/4] enable ASan AddressSanitizer Peng, ZhihongX 2021-10-29 9:21 ` David Marchand 2021-10-29 12:48 ` Peng, ZhihongX 2021-10-29 14:50 ` David Marchand 2021-11-01 3:37 ` Lin, Xueqin 2021-11-02 17:29 ` David Marchand 2021-11-03 9:36 ` Lin, Xueqin 2021-11-03 9:44 ` David Marchand 2021-10-19 10:24 ` [dpdk-dev] [PATCH v11 1/4] Enable ASan for memory detector on DPDK Peng, ZhihongX 2021-10-19 5:52 ` [dpdk-dev] [PATCH v10 " Peng, ZhihongX 2021-10-13 16:44 ` [dpdk-dev] [PATCH v9 1/3] " David Marchand 2021-10-14 6:46 ` Peng, ZhihongX 2021-10-14 7:04 ` Thomas Monjalon 2021-10-14 11:42 ` Peng, ZhihongX 2021-09-27 12:02 ` [dpdk-dev] [PATCH v3] Enable AddressSanitizer feature " Burakov, Anatoly 2021-09-30 5:18 ` Peng, ZhihongX
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=DM8PR11MB559166DF836A45201518CDD9F0BD9@DM8PR11MB5591.namprd11.prod.outlook.com \ --to=zhihongx.peng@intel.com \ --cc=anatoly.burakov@intel.com \ --cc=cristian.dumitrescu@intel.com \ --cc=david.marchand@redhat.com \ --cc=dev@dpdk.org \ --cc=john.mcnamara@intel.com \ --cc=konstantin.ananyev@intel.com \ --cc=stable@dpdk.org \ --cc=stephen@networkplumber.org \ --cc=xueqin.lin@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git