From: "Peng, ZhihongX" <zhihongx.peng@intel.com> To: "Peng, ZhihongX" <zhihongx.peng@intel.com>, "Richardson, Bruce" <bruce.richardson@intel.com>, David Marchand <david.marchand@redhat.com> Cc: "Burakov, Anatoly" <anatoly.burakov@intel.com>, "Ananyev, Konstantin" <konstantin.ananyev@intel.com>, Stephen Hemminger <stephen@networkplumber.org>, dev <dev@dpdk.org>, "Lin, Xueqin" <xueqin.lin@intel.com>, Thomas Monjalon <thomas@monjalon.net> Subject: Re: [dpdk-dev] [PATCH v6 1/2] Enable ASan for memory detector on DPDK Date: Thu, 14 Oct 2021 06:53:10 +0000 Message-ID: <DM8PR11MB55917DB099FFB84B021CBADEF0B89@DM8PR11MB5591.namprd11.prod.outlook.com> (raw) In-Reply-To: <DM8PR11MB5591935DFD1FA42D3A012783F0B89@DM8PR11MB5591.namprd11.prod.outlook.com> > -----Original Message----- > From: dev <dev-bounces@dpdk.org> On Behalf Of Peng, ZhihongX > Sent: Thursday, October 14, 2021 2:34 PM > To: Richardson, Bruce <bruce.richardson@intel.com>; David Marchand > <david.marchand@redhat.com> > Cc: Burakov, Anatoly <anatoly.burakov@intel.com>; Ananyev, Konstantin > <konstantin.ananyev@intel.com>; Stephen Hemminger > <stephen@networkplumber.org>; dev <dev@dpdk.org>; Lin, Xueqin > <xueqin.lin@intel.com>; Thomas Monjalon <thomas@monjalon.net> > Subject: Re: [dpdk-dev] [PATCH v6 1/2] Enable ASan for memory detector on > DPDK > > > -----Original Message----- > > From: Richardson, Bruce <bruce.richardson@intel.com> > > Sent: Wednesday, October 13, 2021 4:00 PM > > To: David Marchand <david.marchand@redhat.com> > > Cc: Peng, ZhihongX <zhihongx.peng@intel.com>; Burakov, Anatoly > > <anatoly.burakov@intel.com>; Ananyev, Konstantin > > <konstantin.ananyev@intel.com>; Stephen Hemminger > > <stephen@networkplumber.org>; dev <dev@dpdk.org>; Lin, Xueqin > > <xueqin.lin@intel.com>; Thomas Monjalon <thomas@monjalon.net> > > Subject: Re: [dpdk-dev] [PATCH v6 1/2] Enable ASan for memory detector > > on DPDK > > > > On Thu, Sep 30, 2021 at 10:20:00AM +0200, David Marchand wrote: > > > Hello, > > > > > > I see v6 is superseded in pw, I have been cleaning my queue... maybe > > > my > > fault. > > > > > > > > > On Thu, Sep 30, 2021 at 7:37 AM <zhihongx.peng@intel.com> wrote: > > > > > > > > From: Zhihong Peng <zhihongx.peng@intel.com> > > > > > > > > AddressSanitizer (ASan) is a google memory error detect standard > > > > tool. It could help to detect use-after-free and > > > > {heap,stack,global}-buffer overflow bugs in C/C++ programs, print > > > > detailed error information when error happens, large improve debug > > > > efficiency. > > > > > > > > `AddressSanitizer > > > > <https://github.com/google/sanitizers/wiki/AddressSanitizer>` > > > > (ASan) is a widely-used debugging tool to detect memory access errors. > > > > It helps detect issues like use-after-free, various kinds of > > > > buffer overruns in C/C++ programs, and other similar errors, as > > > > well as printing out detailed debug information whenever an error is > detected. > > > > > > This patch mixes how to use ASan and instrumenting the DPDK mem > > allocator. > > > > > > I would split this patch in two. > > > > > > The first patch can add the documentation on enabling/using ASan and > > > describe the known issues on enabling it. > > > I'd find it better (from a user pov) if we hide all those details > > > about b_lundef and installation of libasan on Centos. > > > > > > Something like (only quickly tested): > > > > > > diff --git a/config/meson.build b/config/meson.build index > > > 4cdf589e20..7d8b71da79 100644 > > > --- a/config/meson.build > > > +++ b/config/meson.build > > > @@ -411,6 +411,33 @@ if get_option('b_lto') > > > endif > > > endif > > > > > > +if get_option('b_sanitize') == 'address' > > > + asan_dep = cc.find_library('asan', required: true) > > > + if (not cc.links('int main(int argc, char *argv[]) { return 0; }', > > > + dependencies: asan_dep)) > > > + error('broken dependency, "libasan"') > > > + endif > > > + add_project_link_arguments('-lasan', language: 'c') > > > + dpdk_extra_ldflags += '-lasan' > > > +endif > > > + > > > if get_option('default_library') == 'both' > > > error( ''' > > > Unsupported value "both" for "default_library" option. > > > > > > > > > Bruce, do you see an issue with this approach? > > > > > > > Apologies for delayed reply on this. > > > > No issue with this approach on my end, seems reasonable. Just watch > > out that b_sanitize can have "address,undefined" as a possible value, > > so if we want to support that, we can't just check directly for the > > literal string "address" > > > > > > > > Then a second patch adds the rte_malloc instrumentation, with a > > > check at configuration time. > > > > > > endif > > > add_project_link_arguments('-lasan', language: 'c') > > > dpdk_extra_ldflags += '-lasan' > > > + if arch_subdir == 'x86' > > > + asan_check_code = ''' > > > +#ifdef __SANITIZE_ADDRESS__ > > > +#define RTE_MALLOC_ASAN > > > +#elif defined(__has_feature) > > > +# if __has_feature(address_sanitizer) #define RTE_MALLOC_ASAN # > > endif > > > +#endif > > > + > > > +#ifndef RTE_MALLOC_ASAN > > > +#error ASan not available. > > > +#endif > > > +''' > > > + if cc.compiles(asan_check_code) > > > + dpdk_conf.set10('RTE_MALLOC_ASAN', true) > > > + endif > > > + endif > > > endif > > > > > > > Apologies, but I haven't been tracking this set in much detail. > > Do we really need this second configuration check? Should it, or could > > it, be merged into the check above for the asan library presence? > > > > All code: > if get_option('b_sanitize') == 'address' or get_option('b_sanitize') == > 'undefined' > if cc.get_id() == 'gcc' > asan_dep = cc.find_library('asan', required: true) > if (not cc.links('int main(int argc, char *argv[]) { return 0; }', > dependencies: asan_dep)) > error('broken dependency, "libasan"') > endif > endif > > if exec_env == 'linux' and arch_subdir == 'x86' > dpdk_conf.set10('RTE_MALLOC_ASAN', true) > endif > endif > Modify: if get_option('b_sanitize') == 'address' or get_option('b_sanitize') == 'undefined' if cc.get_id() == 'gcc' asan_dep = cc.find_library('asan', required: true) if (not cc.links('int main(int argc, char *argv[]) { return 0; }', dependencies: asan_dep)) error('broken dependency, "libasan"') endif endif if get_option('b_sanitize') == 'address' if exec_env == 'linux' and arch_subdir == 'x86' dpdk_conf.set10('RTE_MALLOC_ASAN', true) endif endif endif > Bruce, is this code correct? > Thanks! > > /Bruce
next prev parent reply other threads:[~2021-10-14 6:53 UTC|newest] Thread overview: 117+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-09-10 2:01 [dpdk-dev] [PATCH] Enable AddressSanitizer feature " zhihongx.peng 2021-09-10 2:47 ` Stephen Hemminger 2021-09-13 5:27 ` Peng, ZhihongX 2021-09-13 15:05 ` Stephen Hemminger 2021-09-13 15:22 ` Bruce Richardson 2021-09-13 15:45 ` Stephen Hemminger 2021-09-14 3:17 ` Lin, Xueqin 2021-09-14 3:11 ` Lin, Xueqin 2021-09-10 17:58 ` David Christensen 2021-09-13 5:35 ` Peng, ZhihongX 2021-09-17 20:50 ` David Christensen 2021-09-18 7:21 ` Peng, ZhihongX 2021-09-20 19:41 ` David Christensen 2021-09-21 8:29 ` David Marchand 2021-09-21 10:15 ` Jerin Jacob 2021-09-22 7:32 ` Peng, ZhihongX 2021-09-16 1:38 ` [dpdk-dev] [PATCH v2] " zhihongx.peng 2021-09-17 8:23 ` David Marchand 2021-09-17 9:12 ` Peng, ZhihongX 2021-09-17 14:58 ` Stephen Hemminger 2021-09-18 6:36 ` Peng, ZhihongX 2021-09-18 7:41 ` [dpdk-dev] [PATCH v3] " zhihongx.peng 2021-09-20 10:03 ` David Marchand 2021-09-22 7:26 ` Peng, ZhihongX 2021-09-24 2:20 ` [dpdk-dev] [PATCH v4 1/2] Enable ASan for memory detector " zhihongx.peng 2021-09-24 2:20 ` [dpdk-dev] [PATCH v4 2/2] lib/pipeline: Fix gcc compilation error using ASan zhihongx.peng 2021-09-24 9:33 ` [dpdk-dev] [PATCH v5 1/2] Enable ASan for memory detector on DPDK zhihongx.peng 2021-09-24 9:33 ` [dpdk-dev] [PATCH v5 2/2] Fix gcc compilation error using ASan zhihongx.peng 2021-09-24 10:03 ` [dpdk-dev] [PATCH v5 1/2] Enable ASan for memory detector on DPDK zhihongx.peng 2021-09-24 10:03 ` [dpdk-dev] [PATCH v5 2/2] lib/pipeline: Fix gcc compilation error using ASan zhihongx.peng 2021-09-30 5:27 ` [dpdk-dev] [PATCH v6 1/2] Enable ASan for memory detector on DPDK zhihongx.peng 2021-09-30 5:27 ` [dpdk-dev] [PATCH v6 2/2] lib/pipeline: Fix gcc compilation error using ASan zhihongx.peng 2021-09-30 8:29 ` [dpdk-dev] [dpdk-stable] " David Marchand 2021-10-12 2:41 ` Peng, ZhihongX 2021-09-30 8:20 ` [dpdk-dev] [PATCH v6 1/2] Enable ASan for memory detector on DPDK David Marchand 2021-10-08 8:07 ` Peng, ZhihongX 2021-10-08 8:30 ` David Marchand 2021-10-12 5:41 ` Peng, ZhihongX 2021-10-12 7:17 ` Peng, ZhihongX 2021-10-13 7:59 ` Bruce Richardson 2021-10-14 6:33 ` Peng, ZhihongX 2021-10-14 6:53 ` Peng, ZhihongX [this message] 2021-09-30 12:59 ` zhihongx.peng 2021-09-30 12:59 ` [dpdk-dev] [PATCH v6 2/2] lib/pipeline: Fix compilation error with gcc ASan zhihongx.peng 2021-09-30 13:59 ` [dpdk-dev] [PATCH v6 1/2] Enable ASan for memory detector on DPDK Burakov, Anatoly 2021-09-30 18:49 ` David Marchand 2021-10-08 9:17 ` [dpdk-dev] [PATCH v7 1/3] " zhihongx.peng 2021-10-08 9:17 ` [dpdk-dev] [PATCH v7 2/3] DPDK code adapts to ASan zhihongx.peng 2021-10-08 9:17 ` [dpdk-dev] [PATCH v7 3/3] lib/pipeline: Fix compilation error with gcc ASan zhihongx.peng 2021-10-11 6:28 ` [dpdk-dev] [PATCH v8 1/3] Enable ASan for memory detector on DPDK zhihongx.peng 2021-10-11 6:28 ` [dpdk-dev] [PATCH v8 2/3] DPDK code adapts to ASan zhihongx.peng 2021-10-11 6:28 ` [dpdk-dev] [PATCH v8 3/3] lib/pipeline: Fix compilation error with gcc ASan zhihongx.peng 2021-10-12 9:43 ` [dpdk-dev] [PATCH v9 1/3] Enable ASan for memory detector on DPDK zhihongx.peng 2021-10-12 9:43 ` [dpdk-dev] [PATCH v9 2/3] DPDK code adapts to ASan zhihongx.peng 2021-10-13 16:45 ` David Marchand 2021-10-14 11:45 ` Peng, ZhihongX 2021-10-12 9:43 ` [dpdk-dev] [PATCH v9 3/3] pipeline: Fix compilation error with gcc ASan zhihongx.peng 2021-10-15 14:27 ` [dpdk-dev] [PATCH v10 1/4] Enable ASan for memory detector on DPDK zhihongx.peng 2021-10-15 14:27 ` [dpdk-dev] [PATCH v10 2/4] DPDK code adapts to ASan zhihongx.peng 2021-10-15 14:27 ` [dpdk-dev] [PATCH v10 3/4] pipeline: Fix compilation error with gcc ASan zhihongx.peng 2021-10-15 14:27 ` [dpdk-dev] [PATCH v10 4/4] performance-thread: Fix cross compilation failed zhihongx.peng 2021-10-19 9:02 ` [dpdk-dev] [PATCH v10 1/4] Enable ASan for memory detector on DPDK Mcnamara, John 2021-10-19 9:28 ` Peng, ZhihongX 2021-10-15 15:11 ` zhihongx.peng 2021-10-15 15:11 ` [dpdk-dev] [PATCH v10 2/4] DPDK code adapts to ASan zhihongx.peng 2021-10-15 15:11 ` [dpdk-dev] [PATCH v10 3/4] pipeline: Fix compilation error with gcc ASan zhihongx.peng 2021-10-18 12:21 ` Dumitrescu, Cristian 2021-10-18 12:54 ` Peng, ZhihongX 2021-10-19 11:26 ` Dumitrescu, Cristian 2021-10-19 12:11 ` Peng, ZhihongX 2021-10-15 15:11 ` [dpdk-dev] [PATCH v10 4/4] performance-thread: Fix cross compilation failed zhihongx.peng 2021-10-19 6:02 ` Peng, ZhihongX 2021-10-19 10:12 ` [dpdk-dev] [PATCH v11 1/4] Enable ASan for memory detector on DPDK zhihongx.peng 2021-10-19 10:12 ` [dpdk-dev] [PATCH v11 2/4] DPDK code adapts to ASan zhihongx.peng 2021-10-19 10:12 ` [dpdk-dev] [PATCH v11 3/4] pipeline: Fix compilation error with gcc ASan zhihongx.peng 2021-10-19 10:12 ` [dpdk-dev] [PATCH v11 4/4] performance-thread: Fix cross compilation failed zhihongx.peng 2021-10-19 10:37 ` Bruce Richardson 2021-10-19 13:04 ` [dpdk-dev] [PATCH v12 1/4] Enable ASan for memory detector on DPDK zhihongx.peng 2021-10-19 13:04 ` [dpdk-dev] [PATCH v12 2/4] DPDK code adapts to ASan zhihongx.peng 2021-10-19 13:04 ` [dpdk-dev] [PATCH v12 3/4] pipeline: Fix compilation error with gcc ASan zhihongx.peng 2021-10-19 13:04 ` [dpdk-dev] [PATCH v12 4/4] performance-thread: Fix cross compilation failed zhihongx.peng 2021-10-19 13:58 ` [dpdk-dev] [PATCH v12 1/4] Enable ASan Address Sanitization zhihongx.peng 2021-10-19 13:58 ` [dpdk-dev] [PATCH v12 2/4] DPDK code adapts to ASan zhihongx.peng 2021-10-19 13:58 ` [dpdk-dev] [PATCH v12 3/4] Code changes to avoid the ASan error zhihongx.peng 2021-10-19 14:05 ` Dumitrescu, Cristian 2021-10-19 13:58 ` [dpdk-dev] [PATCH v12 4/4] performance-thread: Fix cross compilation failed zhihongx.peng 2021-10-19 14:47 ` [dpdk-dev] [PATCH v12 1/4] Enable ASan Address Sanitization Peng, ZhihongX 2021-10-19 15:17 ` Mcnamara, John 2021-10-20 1:55 ` Peng, ZhihongX 2021-10-19 15:20 ` David Marchand 2021-10-20 2:41 ` Lin, Xueqin 2021-10-19 15:15 ` [dpdk-dev] [PATCH v12 1/4] Enable ASan AddressSanitizer zhihongx.peng 2021-10-19 15:15 ` [dpdk-dev] [PATCH v12 2/4] DPDK code adapts to ASan zhihongx.peng 2021-10-19 15:15 ` [dpdk-dev] [PATCH v12 3/4] Code changes to avoid the ASan error zhihongx.peng 2021-10-19 15:15 ` [dpdk-dev] [PATCH v12 4/4] performance-thread: Fix cross compilation failed zhihongx.peng 2021-10-20 7:46 ` [dpdk-dev] [PATCH v13 1/4] enable ASan AddressSanitizer zhihongx.peng 2021-10-20 7:46 ` [dpdk-dev] [PATCH v13 2/4] DPDK code adapts to ASan zhihongx.peng 2021-10-29 9:23 ` David Marchand 2021-10-29 12:54 ` Peng, ZhihongX 2021-10-20 7:46 ` [dpdk-dev] [PATCH v13 3/4] code changes to avoid the ASan error zhihongx.peng 2021-10-20 7:46 ` [dpdk-dev] [PATCH v13 4/4] performance-thread: avoid cross compilation fail zhihongx.peng 2021-10-25 1:58 ` [dpdk-dev] [PATCH v13 1/4] enable ASan AddressSanitizer Peng, ZhihongX 2021-10-29 9:21 ` David Marchand 2021-10-29 12:48 ` Peng, ZhihongX 2021-10-29 14:50 ` David Marchand 2021-11-01 3:37 ` Lin, Xueqin 2021-11-02 17:29 ` David Marchand 2021-11-03 9:36 ` Lin, Xueqin 2021-11-03 9:44 ` David Marchand 2021-10-19 10:24 ` [dpdk-dev] [PATCH v11 1/4] Enable ASan for memory detector on DPDK Peng, ZhihongX 2021-10-19 5:52 ` [dpdk-dev] [PATCH v10 " Peng, ZhihongX 2021-10-13 16:44 ` [dpdk-dev] [PATCH v9 1/3] " David Marchand 2021-10-14 6:46 ` Peng, ZhihongX 2021-10-14 7:04 ` Thomas Monjalon 2021-10-14 11:42 ` Peng, ZhihongX 2021-09-27 12:02 ` [dpdk-dev] [PATCH v3] Enable AddressSanitizer feature " Burakov, Anatoly 2021-09-30 5:18 ` Peng, ZhihongX
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=DM8PR11MB55917DB099FFB84B021CBADEF0B89@DM8PR11MB5591.namprd11.prod.outlook.com \ --to=zhihongx.peng@intel.com \ --cc=anatoly.burakov@intel.com \ --cc=bruce.richardson@intel.com \ --cc=david.marchand@redhat.com \ --cc=dev@dpdk.org \ --cc=konstantin.ananyev@intel.com \ --cc=stephen@networkplumber.org \ --cc=thomas@monjalon.net \ --cc=xueqin.lin@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git