Re: [dpdk-dev] [PATCHv5 1/2] testpmd: add ability to split outgoing packets

["De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>]

> -----Original Message-----
> From: Ananyev, Konstantin
> Sent: Monday, November 09, 2015 1:45 PM
> To: De Lara Guarch, Pablo; dev@dpdk.org
> Subject: RE: [dpdk-dev] [PATCHv5 1/2] testpmd: add ability to split outgoing
> packets
> 
> 
> 
> > -----Original Message-----
> > From: De Lara Guarch, Pablo
> > Sent: Monday, November 09, 2015 1:39 PM
> > To: Ananyev, Konstantin; dev@dpdk.org
> > Subject: RE: [dpdk-dev] [PATCHv5 1/2] testpmd: add ability to split
> outgoing packets
> >
> > Hi Konstantin,
> >
> > > -----Original Message-----
> > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Konstantin
> > > Ananyev
> > > Sent: Monday, November 09, 2015 9:20 AM
> > > To: dev@dpdk.org
> > > Subject: [dpdk-dev] [PATCHv5 1/2] testpmd: add ability to split outgoing
> > > packets
> > >
> > > For CSUM forwarding mode add ability to copy & split outgoing packet
> > > into the new mbuf that consists of multiple segments.
> > > For TXONLY and CSUM forwarding modes add ability to make number of
> > > segments in the outgoing packet to vary on a per packet basis.
> > > Number of segments and size of each segment is controlled by
> > > 'set txpkts' command.
> > > Split policy is controlled by 'set txsplit' command.
> > > Possible values are: on | off | rand.
> > > Tha allows to increase test coverage for TX PMD codepaths.
> > >
> > > Signed-off-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
> > > ---
> > >  app/test-pmd/cmdline.c                      |  57 +++++++++-
> > >  app/test-pmd/config.c                       |  61 +++++++++++
> > >  app/test-pmd/csumonly.c                     | 163
> > > +++++++++++++++++++++++++++-
> > >  app/test-pmd/testpmd.c                      |   3 +
> > >  app/test-pmd/testpmd.h                      |  10 ++
> > >  app/test-pmd/txonly.c                       |  13 ++-
> > >  doc/guides/testpmd_app_ug/testpmd_funcs.rst |  11 +-
> > >  7 files changed, 309 insertions(+), 9 deletions(-)
> > >
> >
> > [...]
> >
> > > diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> > > b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> > > index 4fb1e0b..4608b3f 100644
> > > --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> > > +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> > > @@ -211,7 +211,7 @@ show config
> > >  Displays the configuration of the application.
> > >  The configuration comes from the command-line, the runtime or the
> > > application defaults::
> > >
> > > -   testpmd> show config (rxtx|cores|fwd)
> > > +   testpmd> show config (rxtx|cores|fwd|txpkts)
> > >
> > >  The available information categories are:
> > >
> > > @@ -221,6 +221,8 @@ The available information categories are:
> > >
> > >  * ``fwd``: Packet forwarding configuration.
> > >
> > > +* ``txpkts``: Packets to TX configuration.
> > > +
> > >  For example:
> > >
> > >  .. code-block:: console
> > > @@ -396,6 +398,13 @@ Set the length of each segment of the TX-ONLY
> > > packets::
> > >
> > >  Where x[,y]* represents a CSV list of values, without white space.
> > >
> > > +set txsplit
> > > +~~~~~~~~~~~
> > > +
> > > +Set the length of each segment of the TX packets, applicable for TX-
> ONLY
> > > and CSUM forwarding modes::
> > > +
> > > +   testpmd> set txsplit (off|on|rand)
> > > +
> > >  set corelist
> > >  ~~~~~~~~~~~~
> > >
> > > --
> > > 1.8.5.3
> >
> > Description of "set txsplit" does not look correct. Could you fix it?
> 
> Ups, sure will fix it.
> 
> > It would be nice to describe the three different options (off, on, rand) as
> well.
> 
> Ok, will do.
> Any other comments before I'll re-spin it?

Just a typo ("packts") in config.c

+ tx_pkt_split tx_pkt_split = TX_PKT_SPLIT_OFF;
+ /**< Split policy for packts to TX. */


> Thanks
> Konstantin
> 
> 
> >
> > Thanks,
> > Pablo