Re: [dpdk-dev] [PATCH v2 8/8] examples: remove unnecessary include of atomic

["Xia, Chenbo" <chenbo.xia@intel.com>]

Hi Joyce,

> -----Original Message-----
> From: Joyce Kong <joyce.kong@arm.com>
> Sent: Monday, August 23, 2021 1:50 PM
> To: Chas Williams <chas3@att.com>; Min Hu (Connor) <humin29@huawei.com>;
> Ananyev, Konstantin <konstantin.ananyev@intel.com>; Nicolau, Radu
> <radu.nicolau@intel.com>; Akhil Goyal <gakhil@marvell.com>; Doherty, Declan
> <declan.doherty@intel.com>; Sunil Kumar Kori <skori@marvell.com>; Pavan
> Nikhilesh <pbhagavatula@marvell.com>; Richardson, Bruce
> <bruce.richardson@intel.com>; Hunt, David <david.hunt@intel.com>; Burakov,
> Anatoly <anatoly.burakov@intel.com>; Marohn, Byron <byron.marohn@intel.com>;
> Wang, Yipeng1 <yipeng1.wang@intel.com>; Maxime Coquelin
> <maxime.coquelin@redhat.com>; Xia, Chenbo <chenbo.xia@intel.com>
> Cc: dev@dpdk.org; thomas@monjalon.net; david.marchand@redhat.com;
> honnappa.nagarahalli@arm.com; ruifeng.wang@arm.com; nd@arm.com
> Subject: [PATCH v2 8/8] examples: remove unnecessary include of atomic
> 
> Remove the unnecessary header file rte_atomic.h
> included in example module.
> 
> Signed-off-by: Joyce Kong <joyce.kong@arm.com>
> Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
> ---
>  examples/bond/main.c                                       | 1 -
>  examples/ip_fragmentation/main.c                           | 1 -
>  examples/ip_reassembly/main.c                              | 1 -
>  examples/ipsec-secgw/ipsec-secgw.c                         | 1 -
>  examples/ipv4_multicast/main.c                             | 1 -
>  examples/l2fwd-crypto/main.c                               | 1 -
>  examples/l2fwd-event/l2fwd_common.h                        | 1 -
>  examples/l2fwd-event/l2fwd_event.c                         | 1 -
>  examples/l2fwd-keepalive/main.c                            | 1 -
>  examples/l2fwd/main.c                                      | 1 -
>  examples/l3fwd-acl/main.c                                  | 1 -
>  examples/l3fwd-power/main.c                                | 1 -
>  examples/l3fwd/main.c                                      | 1 -
>  examples/link_status_interrupt/main.c                      | 1 -
>  examples/multi_process/client_server_mp/mp_client/client.c | 1 -
>  examples/multi_process/client_server_mp/mp_server/init.c   | 1 -
>  examples/multi_process/simple_mp/main.c                    | 1 -
>  examples/multi_process/simple_mp/mp_commands.c             | 1 -
>  examples/multi_process/symmetric_mp/main.c                 | 1 -
>  examples/server_node_efd/node/node.c                       | 1 -
>  examples/server_node_efd/server/init.c                     | 1 -
>  examples/vhost_blk/blk.c                                   | 1 -
>  examples/vhost_blk/vhost_blk.c                             | 1 -

In vhost_blk.c, some atomic API is used (rte_atomic_thread_fence).
Although it compiles well, I think it's better to keep the include
rather than depending on other header includes rte_atomic.h.

Thanks,
Chenbo

>  examples/vm_power_manager/channel_manager.c                | 1 -
>  examples/vm_power_manager/channel_manager.h                | 1 -
>  examples/vmdq/main.c                                       | 1 -
>  examples/vmdq_dcb/main.c                                   | 1 -
>  27 files changed, 27 deletions(-)