From: "Gujjar, Abhinandan S" <abhinandan.gujjar@intel.com>
To: Aakash Sasidharan <asasidharan@marvell.com>,
Akhil Goyal <gakhil@marvell.com>
Cc: "jerinj@marvell.com" <jerinj@marvell.com>,
"sthotton@marvell.com" <sthotton@marvell.com>,
"anoobj@marvell.com" <anoobj@marvell.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: RE: [PATCH 3/3] test/event_crypto_adapter: fix crypto null dev creation
Date: Wed, 23 Aug 2023 04:48:47 +0000 [thread overview]
Message-ID: <PH0PR11MB5832E0270D84687DE743C042E81CA@PH0PR11MB5832.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20230822131649.3509986-3-asasidharan@marvell.com>
> -----Original Message-----
> From: Aakash Sasidharan <asasidharan@marvell.com>
> Sent: Tuesday, August 22, 2023 6:47 PM
> To: Gujjar, Abhinandan S <abhinandan.gujjar@intel.com>; Akhil Goyal
> <gakhil@marvell.com>
> Cc: jerinj@marvell.com; sthotton@marvell.com; anoobj@marvell.com;
> dev@dpdk.org; asasidharan@marvell.com
> Subject: [PATCH 3/3] test/event_crypto_adapter: fix crypto null dev creation
>
> Create crypto null device only if no other crypto devices were found.
>
> Fixes: 3c2c535ecfc0 ("test: add event crypto adapter auto-test")
> Cc: abhinandan.gujjar@intel.com
>
> Signed-off-by: Aakash Sasidharan <asasidharan@marvell.com>
> ---
> app/test/test_event_crypto_adapter.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/app/test/test_event_crypto_adapter.c
> b/app/test/test_event_crypto_adapter.c
> index 00b20fa443..0c56744ba0 100644
> --- a/app/test/test_event_crypto_adapter.c
> +++ b/app/test/test_event_crypto_adapter.c
> @@ -1072,11 +1072,10 @@ configure_cryptodev(void)
> return TEST_FAILED;
> }
>
> - /* Create a NULL crypto device */
> - nb_devs = rte_cryptodev_device_count_by_driver(
> - rte_cryptodev_driver_id_get(
> - RTE_STR(CRYPTODEV_NAME_NULL_PMD)));
> +
> + nb_devs = rte_cryptodev_count();
The test is intended to do on NULL cipher with NULL PMD.
Right now, the test does cipher with " RTE_CRYPTO_CIPHER_NULL".
With this changes, does this test work, if you provide any other cryptodev like AESNI, QAT, OpenSSL other than NULL PMD?
> if (!nb_devs) {
> + /* Create a NULL crypto device */
> ret = rte_vdev_init(
> RTE_STR(CRYPTODEV_NAME_NULL_PMD), NULL);
>
> --
> 2.25.1
next prev parent reply other threads:[~2023-08-23 4:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-22 13:16 [PATCH 1/3] event/cnxk: fix return values for capability API Aakash Sasidharan
2023-08-22 13:16 ` [PATCH 2/3] test/event_crypto_adapter: skip unsupported test Aakash Sasidharan
2023-08-23 4:01 ` Anoob Joseph
2023-08-23 4:33 ` Gujjar, Abhinandan S
2023-08-23 7:48 ` Aakash Sasidharan
2023-08-23 8:16 ` Aakash Sasidharan
2023-08-23 8:37 ` Gujjar, Abhinandan S
2023-08-22 13:16 ` [PATCH 3/3] test/event_crypto_adapter: fix crypto null dev creation Aakash Sasidharan
2023-08-23 4:00 ` Anoob Joseph
2023-08-23 4:48 ` Gujjar, Abhinandan S [this message]
2023-08-23 5:47 ` Anoob Joseph
2023-08-23 6:17 ` Gujjar, Abhinandan S
2023-08-23 14:20 ` Jerin Jacob
2023-08-23 3:59 ` [PATCH 1/3] event/cnxk: fix return values for capability API Anoob Joseph
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH0PR11MB5832E0270D84687DE743C042E81CA@PH0PR11MB5832.namprd11.prod.outlook.com \
--to=abhinandan.gujjar@intel.com \
--cc=anoobj@marvell.com \
--cc=asasidharan@marvell.com \
--cc=dev@dpdk.org \
--cc=gakhil@marvell.com \
--cc=jerinj@marvell.com \
--cc=sthotton@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).