From: Jerin Jacob <jerinjacobk@gmail.com>
To: "Gujjar, Abhinandan S" <abhinandan.gujjar@intel.com>
Cc: Anoob Joseph <anoobj@marvell.com>,
Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
Shijith Thotton <sthotton@marvell.com>,
"dev@dpdk.org" <dev@dpdk.org>,
Aakash Sasidharan <asasidharan@marvell.com>,
Akhil Goyal <gakhil@marvell.com>
Subject: Re: [PATCH 3/3] test/event_crypto_adapter: fix crypto null dev creation
Date: Wed, 23 Aug 2023 19:50:28 +0530 [thread overview]
Message-ID: <CALBAE1PRA5gyaEpVS=ZiM95YE8z0GMGWb8Wmo6foBzDUxKEc5g@mail.gmail.com> (raw)
In-Reply-To: <PH0PR11MB5832ED5D06561A2AD543D16DE81CA@PH0PR11MB5832.namprd11.prod.outlook.com>
On Wed, Aug 23, 2023 at 11:47 AM Gujjar, Abhinandan S
<abhinandan.gujjar@intel.com> wrote:
>
> It is not about supporting other PMDs.
> This is about keeping the test case simple with minimal conf overhead so that it is easy for testing and maintaining.
> From the code, I see that few PMDs supports NULL too without much changes to the app. It should be ok.
> >
> > Also, what we have seen is, if there are other cryptodevs (like cnxk), that
> > would be the first cryptodev. And the test application is only testing CDEV_ID
> > 0. So creating a NULL crypto PMD when other PMDs are available is pointless.
> Sounds good.
>
> Acked-by: Abhinandan Gujjar <abhinandan.gujjar@intel.com>
Series applied to dpdk-next-net-eventdev/for-main. Thanks
next prev parent reply other threads:[~2023-08-23 14:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-22 13:16 [PATCH 1/3] event/cnxk: fix return values for capability API Aakash Sasidharan
2023-08-22 13:16 ` [PATCH 2/3] test/event_crypto_adapter: skip unsupported test Aakash Sasidharan
2023-08-23 4:01 ` Anoob Joseph
2023-08-23 4:33 ` Gujjar, Abhinandan S
2023-08-23 7:48 ` Aakash Sasidharan
2023-08-23 8:16 ` Aakash Sasidharan
2023-08-23 8:37 ` Gujjar, Abhinandan S
2023-08-22 13:16 ` [PATCH 3/3] test/event_crypto_adapter: fix crypto null dev creation Aakash Sasidharan
2023-08-23 4:00 ` Anoob Joseph
2023-08-23 4:48 ` Gujjar, Abhinandan S
2023-08-23 5:47 ` Anoob Joseph
2023-08-23 6:17 ` Gujjar, Abhinandan S
2023-08-23 14:20 ` Jerin Jacob [this message]
2023-08-23 3:59 ` [PATCH 1/3] event/cnxk: fix return values for capability API Anoob Joseph
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALBAE1PRA5gyaEpVS=ZiM95YE8z0GMGWb8Wmo6foBzDUxKEc5g@mail.gmail.com' \
--to=jerinjacobk@gmail.com \
--cc=abhinandan.gujjar@intel.com \
--cc=anoobj@marvell.com \
--cc=asasidharan@marvell.com \
--cc=dev@dpdk.org \
--cc=gakhil@marvell.com \
--cc=jerinj@marvell.com \
--cc=sthotton@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).