* [PATCH v1] common/cnxk: fix initialization of timer LF count
@ 2023-03-14 3:46 Shijith Thotton
2023-03-14 5:59 ` Pavan Nikhilesh Bhagavatula
0 siblings, 1 reply; 3+ messages in thread
From: Shijith Thotton @ 2023-03-14 3:46 UTC (permalink / raw)
To: jerinj; +Cc: Shijith Thotton, dev, pbhagavatula
Assignment of nb_lfs variable with the available number of timer LFs was
not happening in the success case after the addition of the new label
"done". This patch fixes the same by moving the assignment under the
label.
Fixes: 44a9307c0908 ("common/cnxk: support mailbox locking")
Signed-off-by: Shijith Thotton <sthotton@marvell.com>
---
drivers/common/cnxk/roc_tim.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/common/cnxk/roc_tim.c b/drivers/common/cnxk/roc_tim.c
index 6f256c60fa..f8607b2852 100644
--- a/drivers/common/cnxk/roc_tim.c
+++ b/drivers/common/cnxk/roc_tim.c
@@ -394,11 +394,11 @@ roc_tim_init(struct roc_tim *roc_tim)
} else {
goto done;
}
- roc_tim->nb_lfs = nb_lfs;
fail:
mbox_put(dev->mbox);
done:
+ roc_tim->nb_lfs = nb_lfs;
return nb_lfs;
}
--
2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH v1] common/cnxk: fix initialization of timer LF count
2023-03-14 3:46 [PATCH v1] common/cnxk: fix initialization of timer LF count Shijith Thotton
@ 2023-03-14 5:59 ` Pavan Nikhilesh Bhagavatula
2023-03-15 5:52 ` Jerin Jacob
0 siblings, 1 reply; 3+ messages in thread
From: Pavan Nikhilesh Bhagavatula @ 2023-03-14 5:59 UTC (permalink / raw)
To: Shijith Thotton, Jerin Jacob Kollanukkaran; +Cc: Shijith Thotton, dev
[-- Attachment #1: Type: text/plain, Size: 1352 bytes --]
> -----Original Message-----
> From: Shijith Thotton <sthotton@marvell.com>
> Sent: Tuesday, March 14, 2023 9:17 AM
> To: Jerin Jacob Kollanukkaran <jerinj@marvell.com>
> Cc: Shijith Thotton <sthotton@marvell.com>; dev@dpdk.org; Pavan
> Nikhilesh Bhagavatula <pbhagavatula@marvell.com>
> Subject: [PATCH v1] common/cnxk: fix initialization of timer LF count
>
> Assignment of nb_lfs variable with the available number of timer LFs was
> not happening in the success case after the addition of the new label
> "done". This patch fixes the same by moving the assignment under the
> label.
>
> Fixes: 44a9307c0908 ("common/cnxk: support mailbox locking")
>
> Signed-off-by: Shijith Thotton <sthotton@marvell.com>
Acked-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
> ---
> drivers/common/cnxk/roc_tim.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/common/cnxk/roc_tim.c
> b/drivers/common/cnxk/roc_tim.c
> index 6f256c60fa..f8607b2852 100644
> --- a/drivers/common/cnxk/roc_tim.c
> +++ b/drivers/common/cnxk/roc_tim.c
> @@ -394,11 +394,11 @@ roc_tim_init(struct roc_tim *roc_tim)
> } else {
> goto done;
> }
> - roc_tim->nb_lfs = nb_lfs;
>
> fail:
> mbox_put(dev->mbox);
> done:
> + roc_tim->nb_lfs = nb_lfs;
> return nb_lfs;
> }
>
> --
> 2.25.1
[-- Attachment #2: winmail.dat --]
[-- Type: application/ms-tnef, Size: 23601 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1] common/cnxk: fix initialization of timer LF count
2023-03-14 5:59 ` Pavan Nikhilesh Bhagavatula
@ 2023-03-15 5:52 ` Jerin Jacob
0 siblings, 0 replies; 3+ messages in thread
From: Jerin Jacob @ 2023-03-15 5:52 UTC (permalink / raw)
To: Pavan Nikhilesh Bhagavatula
Cc: Shijith Thotton, Jerin Jacob Kollanukkaran, dev
On Tue, Mar 14, 2023 at 11:29 AM Pavan Nikhilesh Bhagavatula
<pbhagavatula@marvell.com> wrote:
>
>
>
> > -----Original Message-----
> > From: Shijith Thotton <sthotton@marvell.com>
> > Sent: Tuesday, March 14, 2023 9:17 AM
> > To: Jerin Jacob Kollanukkaran <jerinj@marvell.com>
> > Cc: Shijith Thotton <sthotton@marvell.com>; dev@dpdk.org; Pavan
> > Nikhilesh Bhagavatula <pbhagavatula@marvell.com>
> > Subject: [PATCH v1] common/cnxk: fix initialization of timer LF count
> >
> > Assignment of nb_lfs variable with the available number of timer LFs was
> > not happening in the success case after the addition of the new label
> > "done". This patch fixes the same by moving the assignment under the
> > label.
> >
> > Fixes: 44a9307c0908 ("common/cnxk: support mailbox locking")
> >
> > Signed-off-by: Shijith Thotton <sthotton@marvell.com>
>
> Acked-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
Applied to dpdk-next-net-mrvl/for-next-net. Thanks
>
> > ---
> > drivers/common/cnxk/roc_tim.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/common/cnxk/roc_tim.c
> > b/drivers/common/cnxk/roc_tim.c
> > index 6f256c60fa..f8607b2852 100644
> > --- a/drivers/common/cnxk/roc_tim.c
> > +++ b/drivers/common/cnxk/roc_tim.c
> > @@ -394,11 +394,11 @@ roc_tim_init(struct roc_tim *roc_tim)
> > } else {
> > goto done;
> > }
> > - roc_tim->nb_lfs = nb_lfs;
> >
> > fail:
> > mbox_put(dev->mbox);
> > done:
> > + roc_tim->nb_lfs = nb_lfs;
> > return nb_lfs;
> > }
> >
> > --
> > 2.25.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-03-15 5:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-14 3:46 [PATCH v1] common/cnxk: fix initialization of timer LF count Shijith Thotton
2023-03-14 5:59 ` Pavan Nikhilesh Bhagavatula
2023-03-15 5:52 ` Jerin Jacob
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).