* [dpdk-dev] [PATCH] crypto/qat: fix illegal access of an array
@ 2021-07-26 16:47 Arek Kusztal
2021-07-27 9:31 ` Dybkowski, AdamX
0 siblings, 1 reply; 3+ messages in thread
From: Arek Kusztal @ 2021-07-26 16:47 UTC (permalink / raw)
To: dev; +Cc: gakhil, fiona.trahe, roy.fan.zhang, Arek Kusztal
Fix possible access of an array by negative index in function
qat_sym_qp_setup.
Fixes: 8f393c4ffdc1 ("common/qat: support GEN4 devices")
Coverity issue: 372131
Coverity issue: 372134
Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
---
drivers/crypto/qat/qat_sym_pmd.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/crypto/qat/qat_sym_pmd.c b/drivers/crypto/qat/qat_sym_pmd.c
index 1c7b142511..6868e5f001 100644
--- a/drivers/crypto/qat/qat_sym_pmd.c
+++ b/drivers/crypto/qat/qat_sym_pmd.c
@@ -176,16 +176,17 @@ static int qat_sym_qp_setup(struct rte_cryptodev *dev, uint16_t qp_id,
int ring_pair =
qat_select_valid_queue(qat_dev, qp_id,
QAT_SERVICE_SYMMETRIC);
- sym_hw_qps =
- &qat_dev->qp_gen4_data[0][0];
- qp_hw_data =
- &qat_dev->qp_gen4_data[ring_pair][0];
+
if (ring_pair < 0) {
QAT_LOG(ERR,
"qp_id %u invalid for this device, no enough services allocated for GEN4 device",
qp_id);
return -EINVAL;
}
+ sym_hw_qps =
+ &qat_dev->qp_gen4_data[0][0];
+ qp_hw_data =
+ &qat_dev->qp_gen4_data[ring_pair][0];
} else {
sym_hw_qps = qat_gen_config[qat_dev->qat_dev_gen]
.qp_hw_data[QAT_SERVICE_SYMMETRIC];
--
2.30.2
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] crypto/qat: fix illegal access of an array
2021-07-26 16:47 [dpdk-dev] [PATCH] crypto/qat: fix illegal access of an array Arek Kusztal
@ 2021-07-27 9:31 ` Dybkowski, AdamX
2021-07-27 17:36 ` Akhil Goyal
0 siblings, 1 reply; 3+ messages in thread
From: Dybkowski, AdamX @ 2021-07-27 9:31 UTC (permalink / raw)
To: Kusztal, ArkadiuszX, dev
Cc: gakhil, Trahe, Fiona, Zhang, Roy Fan, Kusztal, ArkadiuszX
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Arek Kusztal
> Sent: Monday, 26 July, 2021 18:48
> To: dev@dpdk.org
> Cc: gakhil@marvell.com; Trahe, Fiona <fiona.trahe@intel.com>; Zhang, Roy
> Fan <roy.fan.zhang@intel.com>; Kusztal, ArkadiuszX
> <arkadiuszx.kusztal@intel.com>
> Subject: [dpdk-dev] [PATCH] crypto/qat: fix illegal access of an array
>
> Fix possible access of an array by negative index in function
> qat_sym_qp_setup.
>
> Fixes: 8f393c4ffdc1 ("common/qat: support GEN4 devices") Coverity issue:
> 372131 Coverity issue: 372134
>
> Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
Acked-by: Adam Dybkowski <adamx.dybkowski@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] crypto/qat: fix illegal access of an array
2021-07-27 9:31 ` Dybkowski, AdamX
@ 2021-07-27 17:36 ` Akhil Goyal
0 siblings, 0 replies; 3+ messages in thread
From: Akhil Goyal @ 2021-07-27 17:36 UTC (permalink / raw)
To: Dybkowski, AdamX, Kusztal, ArkadiuszX, dev
Cc: Trahe, Fiona, Zhang, Roy Fan, Kusztal, ArkadiuszX
> > Fix possible access of an array by negative index in function
> > qat_sym_qp_setup.
> >
> > Fixes: 8f393c4ffdc1 ("common/qat: support GEN4 devices") Coverity issue:
> > 372131 Coverity issue: 372134
> >
> > Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
>
> Acked-by: Adam Dybkowski <adamx.dybkowski@intel.com>
Applied to dpdk-next-crypto
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-07-27 17:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-26 16:47 [dpdk-dev] [PATCH] crypto/qat: fix illegal access of an array Arek Kusztal
2021-07-27 9:31 ` Dybkowski, AdamX
2021-07-27 17:36 ` Akhil Goyal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).