From: Amit Prakash Shukla <amitprakashs@marvell.com>
To: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Cc: Anatoly Burakov <anatoly.burakov@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
"david.marchand@redhat.com" <david.marchand@redhat.com>,
"bruce.richardson@intel.com" <bruce.richardson@intel.com>,
"ciara.power@intel.com" <ciara.power@intel.com>
Subject: RE: [EXT] Re: [PATCH v5 1/2] mem: telemetry support for memseg and element information
Date: Tue, 25 Oct 2022 07:25:22 +0000 [thread overview]
Message-ID: <PH0PR18MB51679FB496110B1499E58233C8319@PH0PR18MB5167.namprd18.prod.outlook.com> (raw)
In-Reply-To: <20221021230751.0b5cbb38@sovereign>
Hi Dmitry,
Sure, will implement 2 new request (1. Msl properties, 2. Address lookup) in a separate patch.
I will work on other review suggestions as part of v6.
Thanks,
Amit Shukla
> -----Original Message-----
> From: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
> Sent: Saturday, October 22, 2022 1:38 AM
> To: Amit Prakash Shukla <amitprakashs@marvell.com>
> Cc: Anatoly Burakov <anatoly.burakov@intel.com>; dev@dpdk.org; Jerin
> Jacob Kollanukkaran <jerinj@marvell.com>; david.marchand@redhat.com;
> bruce.richardson@intel.com; ciara.power@intel.com
> Subject: Re: [EXT] Re: [PATCH v5 1/2] mem: telemetry support for memseg
> and element information
>
> Hi Amit,
>
> 2022-10-21 19:26 (UTC+0000), Amit Prakash Shukla:
> [...]
> > > How does the user learn heap_id?
> > > There probably should be /eal/heap_id returning a list of heap IDs.
> >
> > Request for list of active heap Id's is already present.
> > " /eal/heap_list"
>
> My bad!
>
> > > > --> /eal/element_list,0,1,15
> > > > {"/eal/element_list": {"Element_count": 52}}
> > > >
> > > > 5. /eal/element_info,<heap-id>,<memseg-list-id>,<memseg-id>, \
> > > > <elem-start-id>,<elem-end-id>
> > > > The command outputs element information like element start
> > > > address, end address, to which memseg it belongs, element state,
> element size.
> > > > User can give a range of elements to be printed.
> > > > Example:
> > > > --> /eal/element_info,0,1,15,1,2
> > > > {"/eal/element_info": {"element.1": {"msl_id": 1, \
> > > > "ms_id": 15, "memseg_start_addr": "0xb20000000", \
> > > > "memseg_end_addr": "0xb40000000", \
> > > > "element_start_addr": "0xb201fe680", \
> > > > "element_end_addr": "0xb20bfe700", \
> > > > "element_size": 10485888, "element_state": "Busy"}, \
> > > > "element.2": {"msl_id": 1, "ms_id": 15, \
> > > > "memseg_start_addr": "0xb20000000", \
> > > > "memseg_end_addr": "0xb40000000", \
> > > > "element_start_addr": "0xb20bfe700", \
> > > > "element_end_addr": "0xb215fe780", "element_size": 10485888, \
> > > > "element_state": "Busy"}, "Element_count": 2}}
> > >
> > > How this request is going to be used?
> > > Elements don't have permanent IDs like MSL/memseg index or heap ID.
> > > Heap layout may change between /eal/element_list and this request.
> >
> > Idea here was to print information related to memory element. This
> > information Can be printed for a single element or for a range of elements.
>
> I understand what this request does, the question is: what info the user has
> initially, what they want to learn, and whether the request helps them.
> For example, if the user wants to understand which elements hold the
> known hugepage from being freed, then your request is good as it is.
> On the other hand, if the user initially has an address from some debug print
> and wants to know if it's free, and if not, what's there, then my suggestion
> about query by address is more suitable.
> Or maybe both are good to have eventually.
>
> > > Maybe instead there should be a filter by address with maybe a
> > > context parameter (like "grep -C")?
> >
> > You mean that the user shall be able to grep for a memory address to
> > check which element it belongs to ? If my understanding is correct,
> > can I implement it as new request post rc2 and keep this request as-is?
>
> Yes, this is what I mean.
> AFAIU, rc1 is API freeze, and telemetry is API, so the new request must wait.
> If the current request helps solving actual issues, of course let's have it.
next prev parent reply other threads:[~2022-10-25 7:25 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-19 6:30 [PATCH] " Amit Prakash Shukla
2022-05-19 12:42 ` David Marchand
2022-05-19 18:57 ` [PATCH v2] " Amit Prakash Shukla
2022-05-23 11:14 ` Bruce Richardson
2022-05-23 13:35 ` [EXT] " Amit Prakash Shukla
2022-05-23 13:43 ` Bruce Richardson
2022-05-24 10:30 ` Amit Prakash Shukla
2022-05-24 10:33 ` [PATCH v3] " Amit Prakash Shukla
2022-05-25 10:33 ` [PATCH v4 1/2] " Amit Prakash Shukla
2022-05-25 10:33 ` [PATCH v4 2/2] mem: telemetry support for system memory information Amit Prakash Shukla
2022-06-30 5:54 ` Amit Prakash Shukla
2022-07-21 11:21 ` Amit Prakash Shukla
2022-06-14 12:50 ` [PATCH v4 1/2] mem: telemetry support for memseg and element information Amit Prakash Shukla
2022-06-30 5:52 ` Amit Prakash Shukla
2022-07-21 11:20 ` Amit Prakash Shukla
2022-09-29 8:29 ` David Marchand
2022-09-29 11:30 ` [EXT] " Amit Prakash Shukla
2022-09-29 11:43 ` [PATCH v5 " Amit Prakash Shukla
2022-09-29 11:43 ` [PATCH v5 2/2] mem: telemetry support for system memory information Amit Prakash Shukla
2022-10-07 19:46 ` David Marchand
2022-10-11 7:10 ` [EXT] " Amit Prakash Shukla
2022-10-20 19:18 ` Dmitry Kozlyuk
2022-10-20 19:50 ` Stephen Hemminger
2022-10-06 7:07 ` [PATCH v5 1/2] mem: telemetry support for memseg and element information Amit Prakash Shukla
2022-10-07 19:52 ` David Marchand
2022-10-07 19:48 ` David Marchand
2022-10-11 7:22 ` [EXT] " Amit Prakash Shukla
2022-10-20 11:40 ` Dmitry Kozlyuk
2022-10-21 19:26 ` [EXT] " Amit Prakash Shukla
2022-10-21 20:07 ` Dmitry Kozlyuk
2022-10-25 7:25 ` Amit Prakash Shukla [this message]
2022-10-25 11:51 ` [PATCH v6] " Amit Prakash Shukla
2022-10-25 13:02 ` [PATCH v7] " Amit Prakash Shukla
2022-12-06 11:46 ` Amit Prakash Shukla
2023-01-30 10:18 ` Amit Prakash Shukla
2023-02-20 11:10 ` Thomas Monjalon
2023-02-28 7:30 ` [EXT] " Amit Prakash Shukla
2023-05-15 11:51 ` Amit Prakash Shukla
2023-05-16 10:47 ` Burakov, Anatoly
2023-05-17 9:08 ` [EXT] " Amit Prakash Shukla
2023-05-17 9:21 ` [PATCH v8] " Amit Prakash Shukla
2023-06-07 20:40 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH0PR18MB51679FB496110B1499E58233C8319@PH0PR18MB5167.namprd18.prod.outlook.com \
--to=amitprakashs@marvell.com \
--cc=anatoly.burakov@intel.com \
--cc=bruce.richardson@intel.com \
--cc=ciara.power@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=jerinj@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).