From: Chaoyong He <chaoyong.he@corigine.com>
To: Stephen Hemminger <stephen@networkplumber.org>,
Simon Horman <simon.horman@corigine.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
oss-drivers <oss-drivers@corigine.com>,
Niklas Soderlund <niklas.soderlund@corigine.com>,
Long Wu <long.wu@corigine.com>
Subject: RE: [PATCH 1/2] net/bonding: add independent LACP sending function
Date: Wed, 22 Feb 2023 06:47:58 +0000 [thread overview]
Message-ID: <SJ0PR13MB55459918B4BCAFD9FC33206D9EAA9@SJ0PR13MB5545.namprd13.prod.outlook.com> (raw)
In-Reply-To: <20230220083133.02283b8f@hermes.local>
> On Mon, 20 Feb 2023 10:46:16 +0100
> Simon Horman <simon.horman@corigine.com> wrote:
>
> > On Thu, Feb 16, 2023 at 11:47:27AM -0800, Stephen Hemminger wrote:
> > > On Thu, 16 Feb 2023 15:15:13 +0800
> > > Chaoyong He <chaoyong.he@corigine.com> wrote:
> > >
> > > > +void
> > > > +rte_eth_bond_8023ad_lacp_send_one(void *queue) {
> > > > + uint32_t i;
> > > > + uint16_t slave_tx_count;
> > > > + uint16_t active_slave_count;
> > > > + uint16_t active_slave_ids[RTE_MAX_ETHPORTS];
> > >
> > > Thinking ahead, all of bonding driver should remove the usage of the
> > > terms master and slave. Perhaps you don't want to introduce new
> > > usages that will have to be fixed.
> > >
> > > FYI - there is no usage of master/slave in any of the IEEE
> > > standards, or operating systems other than Linux.
> >
> > Thanks Stephen,
> >
> > could we agree on alternative language?
>
> I did a little looking around and did not come to a great answer.
> Looking at FreeBSD (and Solaris) they use lagg for the aggregating device and
> laggport for the devices associated with it. Applying same logic to DPDK
> would be awkward because it already uses the term "port"
> in multiple ways.
>
> Cisco uses the term "port channel group" when configuring link aggregation.
> Going that way maybe use channels as the replacement for slave in code like
> this.
>
How about we use 'main' and 'member' ?
next prev parent reply other threads:[~2023-02-22 6:48 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-16 7:15 [PATCH 0/2] enhance bonding PMD to support the LACP negotiation Chaoyong He
2023-02-16 7:15 ` [PATCH 1/2] net/bonding: add independent LACP sending function Chaoyong He
2023-02-16 19:47 ` Stephen Hemminger
2023-02-20 9:46 ` Simon Horman
2023-02-20 16:31 ` Stephen Hemminger
2023-02-22 6:47 ` Chaoyong He [this message]
2023-02-16 7:15 ` [PATCH 2/2] app/testpmd: add support for bonding port's LACP negotiation Chaoyong He
2023-02-16 8:32 ` [PATCH v2 0/2] enhance bonding PMD to support the " Chaoyong He
2023-02-16 8:32 ` [PATCH v2 1/2] net/bonding: add independent LACP sending function Chaoyong He
2023-02-16 8:32 ` [PATCH v2 2/2] app/testpmd: add support for bonding port's LACP negotiation Chaoyong He
2023-02-16 17:05 ` Ferruh Yigit
2023-02-22 6:47 ` Chaoyong He
2023-03-01 2:48 ` [PATCH v3 0/2] enhance bonding PMD to support the " Chaoyong He
2023-03-01 2:48 ` [PATCH v3 1/2] net/bonding: add independent LACP sending function Chaoyong He
2023-03-01 2:48 ` [PATCH v3 2/2] app/testpmd: add support for bonding port's LACP negotiation Chaoyong He
2023-03-15 12:03 ` [PATCH v3 0/2] enhance bonding PMD to support the " Niklas Söderlund
2023-05-12 1:50 ` Chaoyong He
2023-06-06 1:23 ` Chaoyong He
2023-06-06 16:48 ` Ferruh Yigit
2023-06-07 3:10 ` Chaoyong He
2023-06-23 13:32 ` Ferruh Yigit
2023-06-25 1:32 ` humin (Q)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SJ0PR13MB55459918B4BCAFD9FC33206D9EAA9@SJ0PR13MB5545.namprd13.prod.outlook.com \
--to=chaoyong.he@corigine.com \
--cc=dev@dpdk.org \
--cc=long.wu@corigine.com \
--cc=niklas.soderlund@corigine.com \
--cc=oss-drivers@corigine.com \
--cc=simon.horman@corigine.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).