RE: [PATCH 3/3] net/nfp: add force reload firmware option

[Chaoyong He <chaoyong.he@corigine.com>]

> On 2/27/2024 11:15 AM, Chaoyong He wrote:
> > From: Peng Zhang <peng.zhang@corigine.com>
> >
> > Add an option to force reload the firmware.
> >
> > This option can be ignored in some case, for example:
> > When using a 2 port NFP card and both with this reload firmware
> > option, only the first one will cause the firmware reload and the
> > second one will be ignored.
> >
> > Signed-off-by: Peng Zhang <peng.zhang@corigine.com>
> > Reviewed-by: Chaoyong He <chaoyong.he@corigine.com>
> > ---
> >  drivers/net/nfp/nfp_ethdev.c     | 104 +++++++++++++++++++++++++++--
> --
> >  drivers/net/nfp/nfp_net_common.h |   8 +++
> >  2 files changed, 100 insertions(+), 12 deletions(-)
> >
> > diff --git a/drivers/net/nfp/nfp_ethdev.c
> > b/drivers/net/nfp/nfp_ethdev.c index 902a62a86b..8c38b4e134 100644
> > --- a/drivers/net/nfp/nfp_ethdev.c
> > +++ b/drivers/net/nfp/nfp_ethdev.c
> > @@ -9,6 +9,7 @@
> >
> >  #include <eal_firmware.h>
> >  #include <rte_alarm.h>
> > +#include <rte_kvargs.h>
> >
> >  #include "flower/nfp_flower.h"
> >  #include "nfd3/nfp_nfd3.h"
> > @@ -31,6 +32,71 @@
> >  #define NFP_NET_APP_CAP_SP_INDIFF       RTE_BIT64(0) /* Indifferent to
> port speed */
> >
> >  #define NFP_PF_DRIVER_NAME net_nfp_pf
> > +#define NFP_PF_FORCE_RELOAD_FW   "force_reload_fw"
> > +
> >
> 
> Can you please document the new devarg in the driver documentation,
> 'doc/guides/nics/nfp.rst'?
> 
> Also you may want to document FW upgrade process, as it checks FW version
> by default and this can be overridden by devarg etc..

Okay, we will document it in the next version patch series, thanks.