From: Akhil Goyal <akhil.goyal@nxp.com>
To: "fiona.trahe@intel.com" <fiona.trahe@intel.com>
Cc: "arkadiuszx.kusztal@intel.com" <arkadiuszx.kusztal@intel.com>,
Damian Nowak <damianx.nowak@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] crypto/qat: fix null auth issues when using vfio_pci
Date: Tue, 15 Oct 2019 13:42:01 +0000 [thread overview]
Message-ID: <VE1PR04MB6639E28ADDD0D7B87E9EA498E6930@VE1PR04MB6639.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20190809092901.17788-1-damianx.nowak@intel.com>
Hi Fiona,
Could you please Ack the following change.
Thanks,
Akhil
> -----Original Message-----
> From: Damian Nowak <damianx.nowak@intel.com>
> Sent: Friday, August 9, 2019 2:59 PM
> To: dev@dpdk.org
> Cc: Akhil Goyal <akhil.goyal@nxp.com>; fiona.trahe@intel.com;
> arkadiuszx.kusztal@intel.com; Damian Nowak <damianx.nowak@intel.com>
> Subject: [PATCH] crypto/qat: fix null auth issues when using vfio_pci
>
> When running auth NULL cases while using
> vfio_pci, DMAR read/write faults appear. It
> happens even if digest_length is set to 0.
> This is caused by auth_res_addr initialized
> as 0x0.
>
> Fixes: 4e0955bddb08
> Cc: Fiona Trahe <fiona.trahe@intel.com>
>
> Signed-off-by: Damian Nowak <damianx.nowak@intel.com>
> ---
> drivers/crypto/qat/qat_sym.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/crypto/qat/qat_sym.c b/drivers/crypto/qat/qat_sym.c
> index 46ef27a..6aa514c 100644
> --- a/drivers/crypto/qat/qat_sym.c
> +++ b/drivers/crypto/qat/qat_sym.c
> @@ -307,9 +307,8 @@ qat_sym_build_request(void *in_op, uint8_t *out_msg,
> }
> min_ofs = auth_ofs;
>
> - if (likely(ctx->qat_hash_alg !=
> ICP_QAT_HW_AUTH_ALGO_NULL))
> - auth_param->auth_res_addr =
> - op->sym->auth.digest.phys_addr;
> + auth_param->auth_res_addr =
> + op->sym->auth.digest.phys_addr;
>
> }
>
> --
> 2.7.4
next prev parent reply other threads:[~2019-10-15 13:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-09 9:29 Damian Nowak
2019-10-15 13:42 ` Akhil Goyal [this message]
2019-10-17 13:17 ` Trahe, Fiona
2019-10-21 9:43 ` Akhil Goyal
2019-10-21 9:44 ` Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VE1PR04MB6639E28ADDD0D7B87E9EA498E6930@VE1PR04MB6639.eurprd04.prod.outlook.com \
--to=akhil.goyal@nxp.com \
--cc=arkadiuszx.kusztal@intel.com \
--cc=damianx.nowak@intel.com \
--cc=dev@dpdk.org \
--cc=fiona.trahe@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).