Re: [dpdk-dev] [PATCH v3 2/8] security: modify PDCP xform to support SDAP

[Akhil Goyal <akhil.goyal@nxp.com>]

> 12/10/2020 16:10, Akhil Goyal:
> > The SDAP is a protocol in the LTE stack on top of PDCP for
> > QOS. A particular PDCP session may or may not have
> > SDAP enabled. But if it is enabled, SDAP header should be
> > authenticated but not encrypted if both confidentiality and
> > integrity is enabled. Hence, the driver should be intimated
> > from the xform so that it skip the SDAP header while encryption.
> >
> > A new field is added in the PDCP xform to specify SDAP is enabled.
> > The overall size of the xform is not changed, as hfn_ovrd is just
> > a flag and does not need uint32. Hence, it is converted to uint8_t
> > and a 16 bit reserved field is added for future.
> >
> > Signed-off-by: Akhil Goyal <akhil.goyal@nxp.com>
> > ---
> >  doc/guides/rel_notes/release_20_11.rst |  9 +++++++++
> >  lib/librte_security/rte_security.h     | 12 ++++++++++--
> >  2 files changed, 19 insertions(+), 2 deletions(-)
> >
> > diff --git a/doc/guides/rel_notes/release_20_11.rst
> b/doc/guides/rel_notes/release_20_11.rst
> > index c34ab5493..fad91487a 100644
> > --- a/doc/guides/rel_notes/release_20_11.rst
> > +++ b/doc/guides/rel_notes/release_20_11.rst
> > @@ -103,6 +103,11 @@ New Features
> >    also known as Mount Bryce.  See the
> >    :doc:`../bbdevs/acc100` BBDEV guide for more details on this new driver.
> >
> > +* **Updated rte_security library to support SDAP.**
> > +
> > +  ``rte_security_pdcp_xform`` in ``rte_security`` lib is updated to enable
> > +  5G NR processing of SDAP header in PMDs.
> > +
> 
> Please try to keep the ordering:
> crypto and security stuff should be after ethdev drivers
> and related stuff (I would say even after flow-perf).
> 
Fixed it while applying the series to dpdk-next-crypto

> >  * **Updated Virtio driver.**
> >
> >    * Added support for Vhost-vDPA backend to Virtio-user PMD.
> > @@ -307,6 +312,10 @@ API Changes
> >    ``rte_fpga_lte_fec_configure`` and structure ``fpga_lte_fec_conf`` to
> >    ``rte_fpga_lte_fec_conf``.
> >
> > +* security: ``hfn_ovrd`` field in ``rte_security_pdcp_xform`` is changed from
> > +  ``uint32_t`` to ``uint8_t`` so that a new field ``sdap_enabled`` can be added
> > +  to support SDAP.
> 
> For the API change,
> Acked-by: Thomas Monjalon <thomas@monjalon.net>
> 
Applied to dpdk-next-crypto