From: Slava Ovsiienko <viacheslavo@mellanox.com>
To: Jack Min <jackmin@mellanox.com>, Matan Azrad <matan@mellanox.com>,
Shahaf Shuler <shahafs@mellanox.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Moti Haimovsky <motih@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix set VLAN id/pcp in new VLAN header
Date: Fri, 1 Nov 2019 07:31:30 +0000 [thread overview]
Message-ID: <VI1PR05MB32785B891EAB0E3ED165E950D2620@VI1PR05MB3278.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <3044c96c749c83daf43e85754113c5bef68af855.1572571554.git.jackmin@mellanox.com>
> -----Original Message-----
> From: Xiaoyu Min <jackmin@mellanox.com>
> Sent: Friday, November 1, 2019 3:33
> To: Matan Azrad <matan@mellanox.com>; Shahaf Shuler
> <shahafs@mellanox.com>; Slava Ovsiienko <viacheslavo@mellanox.com>
> Cc: dev@dpdk.org; Moti Haimovsky <motih@mellanox.com>
> Subject: [PATCH] net/mlx5: fix set VLAN id/pcp in new VLAN header
>
> Currently if user want to set VLAN id/pcp on an about to be pushed VLAN
> header, the of_set_vlan_vid/of_set_vlan_pcp must be present _before_
> action of_push_vlan:
>
> [1] ... actions of_set_vlan_vid vlan_vid 2 / of_push_vlan ...
>
> This is misleading because people think rule [1] intends to set VLAN id on the
> existing VLAN header and then push one new VLAN header on top of it.
>
> A more natual way to set VLAN id/pcp on an to be pushed VLAN header
> should be:
>
> [2] ... actions of_push_vlan / of_set_vlan_vid vlan_vid 2 / ...
>
> Fixes: a5f2da0b816b ("net/mlx5: support modify VLAN ID on new VLAN
> header")
> Fixes: 68fad3635042 ("net/mlx5: support modifying VLAN priority on VLAN
> header")
> Cc: motih@mellanox.com
>
> Signed-off-by: Xiaoyu Min <jackmin@mellanox.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
next prev parent reply other threads:[~2019-11-01 7:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-01 1:32 Xiaoyu Min
2019-11-01 7:31 ` Slava Ovsiienko [this message]
2019-11-03 14:27 ` Raslan Darawsheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR05MB32785B891EAB0E3ED165E950D2620@VI1PR05MB3278.eurprd05.prod.outlook.com \
--to=viacheslavo@mellanox.com \
--cc=dev@dpdk.org \
--cc=jackmin@mellanox.com \
--cc=matan@mellanox.com \
--cc=motih@mellanox.com \
--cc=shahafs@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).