DPDK patches and discussions
 help / color / mirror / Atom feed
From: Olivier Matz <olivier.matz@6wind.com>
To: zhihongx.peng@intel.com
Cc: dmitry.kozliuk@gmail.com, dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v4 1/2] lib/cmdline: release cl when cmdline exit
Date: Fri, 15 Oct 2021 14:58:11 +0200	[thread overview]
Message-ID: <YWl645tInjBTRiBZ@platinum> (raw)
In-Reply-To: <20211013015223.1155876-1-zhihongx.peng@intel.com>

On Wed, Oct 13, 2021 at 01:52:22AM +0000, zhihongx.peng@intel.com wrote:
> From: Zhihong Peng <zhihongx.peng@intel.com>
> 
> Malloc cl in the cmdline_stdin_new function, so release in the
> cmdline_stdin_exit function is logical, so that cl will not be
> released alone.
> 
> Fixes: af75078fece3 ("first public release")
> Cc: stable@dpdk.org

As said by Dmitry, we should not backport this fix to avoid breaking
external apps.

> Signed-off-by: Zhihong Peng <zhihongx.peng@intel.com>

I suggest to merge the 2 patches in one, because the second is mandatory
when the first one is applied.

Thanks Zhihong, and thanks Dmitry for the previous review.

  parent reply	other threads:[~2021-10-15 12:58 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-31  2:28 [dpdk-dev] [PATCH] " zhihongx.peng
2021-08-31 16:59 ` Stephen Hemminger
2021-09-06  5:45   ` Peng, ZhihongX
2021-08-31 17:52 ` Dmitry Kozlyuk
2021-09-06  5:51   ` Peng, ZhihongX
2021-09-06  7:33     ` Dmitry Kozlyuk
2021-09-30  6:53       ` Peng, ZhihongX
2021-09-30  7:44         ` Dmitry Kozlyuk
2021-10-08  6:55           ` Peng, ZhihongX
2021-09-17  2:15 ` [dpdk-dev] [PATCH v2 1/2] " zhihongx.peng
2021-09-17  2:15   ` [dpdk-dev] [PATCH v2 2/2] app/test: Delete cmdline free function zhihongx.peng
2021-10-08  6:41     ` [dpdk-dev] [PATCH v3 1/2] lib/cmdline: release cl when cmdline exit zhihongx.peng
2021-10-08  6:41       ` [dpdk-dev] [PATCH v3 2/2] app/test: delete cmdline free function zhihongx.peng
2021-10-11  8:26         ` Dmitry Kozlyuk
2021-10-11  5:20       ` [dpdk-dev] [PATCH v3 1/2] lib/cmdline: release cl when cmdline exit Peng, ZhihongX
2021-10-11  8:25       ` Dmitry Kozlyuk
2021-10-13  1:53         ` Peng, ZhihongX
2021-10-13  2:36           ` Dmitry Kozlyuk
2021-10-13  3:12             ` Peng, ZhihongX
2021-10-13  1:52       ` [dpdk-dev] [PATCH v4 " zhihongx.peng
2021-10-13  1:52         ` [dpdk-dev] [PATCH v4 2/2] app/test: delete cmdline free function zhihongx.peng
2021-10-18 13:58           ` [dpdk-dev] [PATCH v5] lib/cmdline: release cl when cmdline exit zhihongx.peng
2021-10-18 14:29             ` Dmitry Kozlyuk
2021-10-20  7:03               ` Olivier Matz
2021-10-22 21:33                 ` Thomas Monjalon
2021-10-20  9:22             ` Peng, ZhihongX
2021-10-15 12:58         ` Olivier Matz [this message]
2021-10-18  5:16           ` [dpdk-dev] [PATCH v4 1/2] " Peng, ZhihongX
2021-09-30  6:47   ` [dpdk-dev] [PATCH v2 " Peng, ZhihongX

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YWl645tInjBTRiBZ@platinum \
    --to=olivier.matz@6wind.com \
    --cc=dev@dpdk.org \
    --cc=dmitry.kozliuk@gmail.com \
    --cc=stable@dpdk.org \
    --cc=zhihongx.peng@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).