From: Bruce Richardson <bruce.richardson@intel.com>
To: Wenwu Ma <wenwux.ma@intel.com>
Cc: anatoly.burakov@intel.com, dev@dpdk.org, jiayu.hu@intel.com,
yinan.wang@intel.com, xingguang.he@intel.com
Subject: Re: [PATCH] examples/multi_process: add options to control port configuration
Date: Thu, 17 Feb 2022 09:06:14 +0000 [thread overview]
Message-ID: <Yg4QBoSecTgkY0lv@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <20220217151755.442306-1-wenwux.ma@intel.com>
On Thu, Feb 17, 2022 at 03:17:55PM +0000, Wenwu Ma wrote:
> The default values of rx mq_mode and rx offloads for port will cause
> symmetric_mp startup failure if the port do not support rss or csum.
> Therefore, we added two new options --rx-mq-mode and --rx-offloads,
> through which the user can set the values appropriately according to the
> situation to make app startup normally.
>
> Signed-off-by: Wenwu Ma <wenwux.ma@intel.com> ---
The idea seems reasonable enough, but I think the implementation requiring
the user to pass in special "magic numbers" for the offload values is not a
good idea. Perhaps add in a separate flag for "no-csum" to disable that.
For the no-rss case, can you explain how you would see this app being used
in the absense of RSS support to distribute traffic among the separate
processes?
next prev parent reply other threads:[~2022-02-17 9:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-17 15:17 Wenwu Ma
2022-02-17 9:06 ` Bruce Richardson [this message]
2022-02-18 6:49 ` Ma, WenwuX
2022-02-18 9:41 ` Bruce Richardson
2022-02-18 10:10 ` Ma, WenwuX
2022-02-18 10:22 ` Bruce Richardson
2022-02-21 15:35 ` [PATCH v2] examples/multi_process: reconfigure port when rss or csum isn't supported Wenwu Ma
2022-02-21 9:21 ` Bruce Richardson
2022-02-22 10:51 ` [PATCH v3] " Wenwu Ma
2022-02-22 9:41 ` Bruce Richardson
2022-02-28 7:55 ` Ling, WeiX
2022-03-08 13:22 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yg4QBoSecTgkY0lv@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=jiayu.hu@intel.com \
--cc=wenwux.ma@intel.com \
--cc=xingguang.he@intel.com \
--cc=yinan.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).