From: Andrew Rybchenko <arybchenko@solarflare.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: <dev@dpdk.org>, <ferruh.yigit@intel.com>
Subject: Re: [dpdk-dev] [PATCH] net/sfc: enable TSO by default
Date: Fri, 20 Jan 2017 17:37:07 +0300 [thread overview]
Message-ID: <a1b34174-a0bd-276f-1c0a-bdfd746b999e@solarflare.com> (raw)
In-Reply-To: <18339814.hMek8iyv21@xps13>
On 01/20/2017 05:29 PM, Thomas Monjalon wrote:
> 2017-01-19 15:52, Andrew Rybchenko:
>> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
>> ---
>> It is a mistake that TSO support is compiled out by default.
>> We would be happy to enable it by deafult, but strictly speaking
>> it is not a bug fix.
>>
>> Arguments to enable are:
>> - be more feature-rich (and user-friendly) in default config
>> - the most of internal testing is done with TSO enabled
>>
>> config/common_base | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/config/common_base b/config/common_base
>> index b9fb8e2..134e9b9 100644
>> --- a/config/common_base
>> +++ b/config/common_base
>> @@ -261,7 +261,7 @@ CONFIG_RTE_LIBRTE_BNXT_PMD=y
>> #
>> CONFIG_RTE_LIBRTE_SFC_EFX_PMD=y
>> CONFIG_RTE_LIBRTE_SFC_EFX_DEBUG=n
>> -CONFIG_RTE_LIBRTE_SFC_EFX_TSO=n
>> +CONFIG_RTE_LIBRTE_SFC_EFX_TSO=y
> There should not be such option in the build-time configuration.
> Why keeping it (even enabled by default)?
Initially it was introduced since packet rates with TSO compiled out
were slightly but noticeable better. Finally we have changed approach
and performance improvements planned in 17.05 do not require it.
I'll be happy to remove it completely, if there is no problems to
include it in 17.02 (it will be a bit bigger but functionally equal to
this one).
next prev parent reply other threads:[~2017-01-20 14:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-19 15:52 Andrew Rybchenko
2017-01-20 14:29 ` Thomas Monjalon
2017-01-20 14:37 ` Andrew Rybchenko [this message]
2017-01-20 14:47 ` Ferruh Yigit
2017-01-20 15:22 ` [dpdk-dev] [PATCH v3] " Andrew Rybchenko
2017-01-23 9:56 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a1b34174-a0bd-276f-1c0a-bdfd746b999e@solarflare.com \
--to=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).