From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Jakub Grajciar -X (jgrajcia - PANTHEON TECH SRO at Cisco)"
<jgrajcia@cisco.com>, Junxiao Shi <git@mail1.yoursunny.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/memif: fix chained mbuf determination
Date: Mon, 27 Sep 2021 16:25:53 +0100 [thread overview]
Message-ID: <a5142ab1-9e50-6c5a-778d-bbaae02b8ade@intel.com> (raw)
In-Reply-To: <CY4PR1101MB2102716EA0646F2B7032645FDFA29@CY4PR1101MB2102.namprd11.prod.outlook.com>
On 9/22/2021 7:19 AM, Jakub Grajciar -X (jgrajcia - PANTHEON TECH SRO at Cisco)
wrote:
>>> Previously, TX functions call rte_pktmbuf_is_contiguous to determine
>>> whether an mbuf is chained. However, rte_pktmbuf_is_contiguous is
>>> designed to work on the first mbuf of a packet only. In case a packet
>>> contains three or more segment mbufs in a chain, it may cause
>>> truncated packets or rte_mbuf_sanity_check panics.
>>>
>>> This patch updates TX functions to determine chained mbufs using
>>> mbuf_head->nb_segs field, which works in all cases. Moreover, it
>>> maintains that the second cacheline is only accessed when chained mbuf
>>> is actually present.
>>>
>>> Signed-off-by: Junxiao Shi <git@mail1.yoursunny.com>
>
> Looks ok to me. Thanks for the patch!
>
> Reviewed-by: Jakub Grajciar <jgrajcia@cisco.com>
>
Fixes: 09c7e63a71f9 ("net/memif: introduce memory interface PMD")
Fixes: 43b815d88188 ("net/memif: support zero-copy slave")
Cc: stable@dpdk.org
Applied to dpdk-next-net/main, thanks.
prev parent reply other threads:[~2021-09-27 15:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-09 14:42 Junxiao Shi
2021-09-20 15:20 ` Ferruh Yigit
2021-09-22 6:19 ` Jakub Grajciar -X (jgrajcia - PANTHEON TECH SRO at Cisco)
2021-09-27 15:25 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a5142ab1-9e50-6c5a-778d-bbaae02b8ade@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=git@mail1.yoursunny.com \
--cc=jgrajcia@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).