DPDK patches and discussions
 help / color / mirror / Atom feed
* Re: [EXT] [dpdk-dev] [v2] [PATCH] test_compressdev:fix test case skipping due to missing device init
@ 2021-11-11 11:54 wuchangsheng (C)
  0 siblings, 0 replies; 3+ messages in thread
From: wuchangsheng (C) @ 2021-11-11 11:54 UTC (permalink / raw)
  To: Akhil Goyal, fiona.trahe, Ashish Gupta; +Cc: dev, Chenxiang (EulerOS)

>
>> The testsuite_setup function in the compressdev_autotest test case, 
>> the rte_compressdev_count() return 0 due to the lack of device init.
>> It is considered that there is no equitment to skip execution.
>> So add rte_vdev_init init compress_zlib device.
>
>Why? Devices can be added as command line argument.
>* Use ``--vdev="compress_isal"`` in the EAL options, which will call ``rte_vdev_init()`` internally.
>See documentation of compressdevs.
>
>And if at all it is required, why only the zlib, there are other devices as well.
>

When ut test in this steps, will not call rte_vdev_init()
1. meson build
2. cd build
3. meson test compressdev_autotest

This use case tests the framework code and doesn't care about the specific device, so zlib device is randomly selected.
According to what you said, it may affect the command-line test. I need to think it again.

>> Signed-off-by: Changsheng Wu <wuchangsheng2@huawei.com>
>> ---
>>  app/test/test_compressdev.c | 6 ++++++
>>  1 file changed, 6 insertions(+)
>> 
>> diff --git a/app/test/test_compressdev.c b/app/test/test_compressdev.c 
>> index a1b9f06250..f15fbe7f2d 100644
>> --- a/app/test/test_compressdev.c
>> +++ b/app/test/test_compressdev.c
>> @@ -14,6 +14,7 @@
>>  #include <rte_mbuf.h>
>>  #include <rte_compressdev.h>
>>  #include <rte_string_fns.h>
>> +#include <rte_bus_vdev.h>
>> 
>>  #include "test_compressdev_test_buffer.h"
>>  #include "test.h"
>> @@ -197,6 +198,11 @@ testsuite_setup(void)
>>  	uint32_t max_buf_size = 0;
>>  	unsigned int i;
>> 
>> +	if (rte_vdev_init("compress_zlib", NULL) != 0) {
>> +		RTE_LOG(WARNING, USER1, "not find compress_zlib
>> device\n");
>> +		return TEST_SKIPPED;
>> +	}
>> +
>>  	if (rte_compressdev_count() == 0) {
>>  		RTE_LOG(WARNING, USER1, "Need at least one compress device\n");
>>  		return TEST_SKIPPED;
>> --
>> 2.27.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* RE: [EXT] [dpdk-dev] [v2] [PATCH] test_compressdev:fix test case skipping due to missing device init
  2021-11-11 11:32 ` [EXT] " Akhil Goyal
@ 2021-11-11 11:42   ` Akhil Goyal
  0 siblings, 0 replies; 3+ messages in thread
From: Akhil Goyal @ 2021-11-11 11:42 UTC (permalink / raw)
  To: Changsheng Wu, fiona.trahe, Ashish Gupta; +Cc: dev, rose.chen



> > The testsuite_setup function in the compressdev_autotest test case,
> > the rte_compressdev_count() return 0 due to the lack of device init.
> > It is considered that there is no equitment to skip execution.
> > So add rte_vdev_init init compress_zlib device.
> 
> Why? Devices can be added as command line argument.
> * Use ``--vdev="compress_isal"`` in the EAL options, which will call
> ``rte_vdev_init()`` internally.
> See documentation of compressdevs.
> 
> And if at all it is required, why only the zlib, there are other devices as well.
> 
Please mark your previous versions of patches as superseded in patchworks.
It creates confusion when you change the title of the patch.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* RE: [EXT] [dpdk-dev] [v2] [PATCH] test_compressdev:fix test case skipping due to missing device init
  2021-11-08 12:35 Changsheng Wu
@ 2021-11-11 11:32 ` Akhil Goyal
  2021-11-11 11:42   ` Akhil Goyal
  0 siblings, 1 reply; 3+ messages in thread
From: Akhil Goyal @ 2021-11-11 11:32 UTC (permalink / raw)
  To: Changsheng Wu, fiona.trahe, Ashish Gupta; +Cc: dev, rose.chen

> The testsuite_setup function in the compressdev_autotest test case,
> the rte_compressdev_count() return 0 due to the lack of device init.
> It is considered that there is no equitment to skip execution.
> So add rte_vdev_init init compress_zlib device.

Why? Devices can be added as command line argument.
* Use ``--vdev="compress_isal"`` in the EAL options, which will call ``rte_vdev_init()`` internally.
See documentation of compressdevs.

And if at all it is required, why only the zlib, there are other devices as well.


> 
> Signed-off-by: Changsheng Wu <wuchangsheng2@huawei.com>
> ---
>  app/test/test_compressdev.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/app/test/test_compressdev.c b/app/test/test_compressdev.c
> index a1b9f06250..f15fbe7f2d 100644
> --- a/app/test/test_compressdev.c
> +++ b/app/test/test_compressdev.c
> @@ -14,6 +14,7 @@
>  #include <rte_mbuf.h>
>  #include <rte_compressdev.h>
>  #include <rte_string_fns.h>
> +#include <rte_bus_vdev.h>
> 
>  #include "test_compressdev_test_buffer.h"
>  #include "test.h"
> @@ -197,6 +198,11 @@ testsuite_setup(void)
>  	uint32_t max_buf_size = 0;
>  	unsigned int i;
> 
> +	if (rte_vdev_init("compress_zlib", NULL) != 0) {
> +		RTE_LOG(WARNING, USER1, "not find compress_zlib
> device\n");
> +		return TEST_SKIPPED;
> +	}
> +
>  	if (rte_compressdev_count() == 0) {
>  		RTE_LOG(WARNING, USER1, "Need at least one compress
> device\n");
>  		return TEST_SKIPPED;
> --
> 2.27.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-11-11 13:00 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-11 11:54 [EXT] [dpdk-dev] [v2] [PATCH] test_compressdev:fix test case skipping due to missing device init wuchangsheng (C)
  -- strict thread matches above, loose matches on Subject: below --
2021-11-08 12:35 Changsheng Wu
2021-11-11 11:32 ` [EXT] " Akhil Goyal
2021-11-11 11:42   ` Akhil Goyal

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).