Re: [dpdk-dev] [RFC v2 2/2] vhost: support requests only handled by external backend

[Maxime Coquelin <maxime.coquelin@redhat.com>]

On 3/8/19 10:18 AM, Stojaczyk, Dariusz wrote:
>> -----Original Message-----
>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Maxime Coquelin
>> Sent: Thursday, February 28, 2019 4:32 PM
>> To: dev@dpdk.org; Liu, Changpeng <changpeng.liu@intel.com>; Bie, Tiwei
>> <tiwei.bie@intel.com>; i.maximets@samsung.com
>> Cc: Maxime Coquelin <maxime.coquelin@redhat.com>
>> Subject: [dpdk-dev] [RFC v2 2/2] vhost: support requests only handled by
>> external backend
>>
>> External backends may have specific requests to handle, and so
>> we don't want the vhost-user lib to handle these requests as
>> errors.
>>
>> This patch also changes the experimental API by introducing
>> RTE_VHOST_MSG_RESULT_NOT_HANDLED so that vhost-user lib
>> can report an error if a message is handled neither by
>> the vhost-user library nor by the external backend.
>>
>> The logic changes a bit so that if the callback returns
>> with ERR, OK or REPLY, it is considered the message
>> is handled by the external backend so it won't be
>> handled by the vhost-user library.
>> It is still possible for an external backend to listen
>> to requests that have to be handled by the vhost-user
>> library like SET_MEM_TABLE, but the callback have to
>> return NOT_HANDLED in that case.
>>
>> Suggested-by: Ilya Maximets <i.maximets@samsung.com>
>> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
>> ---
> 
> Besides the fall-through compilation issue,
> 
> Tested-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
> 
> Thanks!
> 

Great, thanks Darek.
I was waiting for your feedback, I'll post v1 early next week.

Maxime