From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Ivan Malov <ivan.malov@arknetworks.am>, dev@dpdk.org
Cc: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
stable@dpdk.org, Andy Moreton <amoreton@xilinx.com>
Subject: Re: [PATCH v3] net/sfc: stop misuse of Rx ingress m-port metadata on EF100
Date: Wed, 12 Apr 2023 13:04:31 +0100 [thread overview]
Message-ID: <bdd074cc-0a77-7b8f-6237-2c43904167b1@amd.com> (raw)
In-Reply-To: <20230312105426.6732-1-ivan.malov@arknetworks.am>
On 3/12/2023 10:54 AM, Ivan Malov wrote:
> The driver supports representor functionality. In it,
> packets coming from VFs to the dedicated back-end Rx
> queue get demultiplexed into front-end Rx queues of
> representor ethdevs as per the per-packet metadata
> indicating logical HW ingress ports. On transmit,
> packets are provided with symmetrical metadata
> by front-end Tx queues, and the back-end queue
> transforms the data into so-called Tx override
> descriptors. These let the packets bypass flow
> lookup and go directly to the represented VFs.
>
> However, in the Rx part, the driver extracts
> the said metadata on every HW Rx queue, that
> is, not just on the one used by representors.
> Doing so leads to a buggy behaviour. It is
> revealed by operating testpmd as follows:
>
> dpdk-testpmd -a 0000:c6:00.0 -a 0000:c6:00.1 -- -i
>
> testpmd> flow create 0 transfer pattern port_representor \
> port_id is 0 / end actions port_representor port_id 1 / end
> Flow rule #0 created
>
> testpmd> set fwd io
> testpmd> start tx_first
>
> testpmd> flow destroy 0 rule 0
> Flow rule #0 destroyed
>
> testpmd> stop
>
> ---------------------- Forward statistics for port 0 -----------------
> RX-packets: 19196498 RX-dropped: 0 RX-total: 19196498
> TX-packets: 19196535 TX-dropped: 0 TX-total: 19196535
> -----------------------------------------------------------------------
>
> ---------------------- Forward statistics for port 1 -----------------
> RX-packets: 19196503 RX-dropped: 0 RX-total: 19196503
> TX-packets: 19196530 TX-dropped: 0 TX-total: 19196530
> -----------------------------------------------------------------------
>
> In this scenario, two physical functions of the adapter
> do not have any corresponding "back-to-back" forwarder
> on peer host. Packets transmitted from port 0 can only
> be forwarded to port 1 by means of a special flow rule.
>
> The flow rule indeed works, but destroying it does not
> stop forwarding. Port statistics carry on incrementing.
>
> Also, it is apparent that forwarding in the opposite
> direction must not have worked in this case as the
> flow is meant to target only one of the directions.
>
> Because of the bug, the first 32 mbufs received
> as a result of the flow rule operation have the
> said metadata present. In io mode, testpmd does
> not tamper with mbufs and passes them directly
> to transmit path, so this data remains in them
> instructing the PMD to override destinations
> of the packets via Tx option descriptors.
>
> Expected behaviour is as follows:
>
> ---------------------- Forward statistics for port 0 -----------------
> RX-packets: 0 RX-dropped: 0 RX-total: 0
> TX-packets: 15787496 TX-dropped: 0 TX-total: 15787496
> -----------------------------------------------------------------------
>
> ---------------------- Forward statistics for port 1 -----------------
> RX-packets: 15787464 RX-dropped: 0 RX-total: 15787464
> TX-packets: 32 TX-dropped: 0 TX-total: 32
> -----------------------------------------------------------------------
>
> These figures show the rule work only for one direction.
> Also, removing the flow shall cause forwarding to cease.
>
> Provided patch fixes the bug accordingly.
>
> Fixes: d0f981a3efd8 ("net/sfc: handle ingress mport in EF100 Rx prefix")
> Cc: stable@dpdk.org
>
> Signed-off-by: Ivan Malov <ivan.malov@arknetworks.am>
> Reviewed-by: Andy Moreton <amoreton@xilinx.com>
> ---
> v3: extra rework after review feedback
> v2: address community review notes
>
> drivers/net/sfc/sfc_dp_rx.h | 1 +
> drivers/net/sfc/sfc_ef100_rx.c | 18 ++++++++++++++----
> drivers/net/sfc/sfc_rx.c | 3 +++
> 3 files changed, 18 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/sfc/sfc_dp_rx.h b/drivers/net/sfc/sfc_dp_rx.h
> index 246adbd87c..8a504bdcf1 100644
> --- a/drivers/net/sfc/sfc_dp_rx.h
> +++ b/drivers/net/sfc/sfc_dp_rx.h
> @@ -69,6 +69,7 @@ struct sfc_dp_rx_qcreate_info {
> /** Receive queue flags initializer */
> unsigned int flags;
> #define SFC_RXQ_FLAG_RSS_HASH 0x1
> +#define SFC_RXQ_FLAG_INGRESS_MPORT 0x2
>
> /** Rx queue size */
> unsigned int rxq_entries;
> diff --git a/drivers/net/sfc/sfc_ef100_rx.c b/drivers/net/sfc/sfc_ef100_rx.c
> index b7e3397f77..e323156a26 100644
> --- a/drivers/net/sfc/sfc_ef100_rx.c
> +++ b/drivers/net/sfc/sfc_ef100_rx.c
> @@ -823,6 +823,9 @@ sfc_ef100_rx_qcreate(uint16_t port_id, uint16_t queue_id,
> if (rxq->nic_dma_info->nb_regions > 0)
> rxq->flags |= SFC_EF100_RXQ_NIC_DMA_MAP;
>
> + if (info->flags & SFC_RXQ_FLAG_INGRESS_MPORT)
> + rxq->flags |= SFC_EF100_RXQ_INGRESS_MPORT;
> +
> sfc_ef100_rx_debug(rxq, "RxQ doorbell is %p", rxq->doorbell);
>
> *dp_rxqp = &rxq->dp;
> @@ -889,11 +892,18 @@ sfc_ef100_rx_qstart(struct sfc_dp_rxq *dp_rxq, unsigned int evq_read_ptr,
> else
> rxq->flags &= ~SFC_EF100_RXQ_USER_MARK;
>
> +
> + /*
> + * At the moment, this feature is used only
> + * by the representor proxy Rx queue and is
> + * essential for representor support, so if
> + * it has been requested but is unsupported,
> + * point this inconsistency out to the user.
> + */
> if ((unsup_rx_prefix_fields &
> - (1U << EFX_RX_PREFIX_FIELD_INGRESS_MPORT)) == 0)
> - rxq->flags |= SFC_EF100_RXQ_INGRESS_MPORT;
> - else
> - rxq->flags &= ~SFC_EF100_RXQ_INGRESS_MPORT;
> + (1U << EFX_RX_PREFIX_FIELD_INGRESS_MPORT)) &&
> + (rxq->flags & SFC_EF100_RXQ_INGRESS_MPORT))
> + return ENOTSUP;
>
> if ((unsup_rx_prefix_fields &
> (1U << EFX_RX_PREFIX_FIELD_VLAN_STRIP_TCI)) == 0)
Hi Ivan,
The patch doesn't apply cleanly, and I can't find
'EFX_RX_PREFIX_FIELD_VLAN_STRIP_TCI' in the repo.
Can you please rebase the patch on top of latest 'next-net' and send a
new version? So that CI can run.
If there won't be any functional change, feel free to keep Andrew's ack
in next version.
next prev parent reply other threads:[~2023-04-12 12:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-09 4:11 [PATCH 1/1] " Ivan Malov
2023-03-10 14:01 ` Ferruh Yigit
2023-03-10 14:18 ` Andrew Rybchenko
2023-03-10 14:43 ` Ferruh Yigit
2023-03-10 17:01 ` [PATCH v2] " Ivan Malov
2023-03-12 7:59 ` Andrew Rybchenko
2023-03-12 10:54 ` [PATCH v3] " Ivan Malov
2023-03-16 17:02 ` Ferruh Yigit
2023-04-09 8:00 ` Andrew Rybchenko
2023-04-12 12:04 ` Ferruh Yigit [this message]
2023-04-12 13:57 ` [PATCH v4] " Ivan Malov
2023-04-17 9:06 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bdd074cc-0a77-7b8f-6237-2c43904167b1@amd.com \
--to=ferruh.yigit@amd.com \
--cc=amoreton@xilinx.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=ivan.malov@arknetworks.am \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).