DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Raja Zidane <rzidane@nvidia.com>, <dev@dpdk.org>
Cc: <matan@nvidia.com>, <stable@dpdk.org>
Subject: Re: [PATCH V4] app/testpmd: fix GENEVE parsing in csum forward mode
Date: Mon, 21 Feb 2022 17:36:47 +0000	[thread overview]
Message-ID: <bf26f50e-0a33-9903-8497-459ee8df6e2a@intel.com> (raw)
In-Reply-To: <20220221132423.14343-1-rzidane@nvidia.com>

On 2/21/2022 1:24 PM, Raja Zidane wrote:
> The csum FWD mode parses any received packet to set mbuf offloads for the
> transmitting burst, mainly in the checksum/TSO areas.
> In the case of a tunnel header, the csum FWD tries to detect known tunnels
> by the standard definition using the header'sdata and fallback to check the
> packet type in the mbuf to see if the Rx port driver already sign the
> packet as a tunnel.
> In the fallback case, the csum assumes the tunnel is VXLAN and parses the
> tunnel as VXLAN.
> When the GENEVE tunnel was added to the known tunnels in csum, its parsing
> trial was wrongly located after the pkt type detection, causing the csum to
> parse the GENEVE header as VXLAN when the Rx port set the tunnel packet
> type.
> 
> Remove the fall back case to VxLan.
> Log error of unrecognized tunnel if no tunnel was parsed successfully.
> 
> Fixes: c10a026c3b03 ("app/testpmd: introduce vxlan parsing function in csum fwd engine")
> Cc:stable@dpdk.org
> 
> Signed-off-by: Raja Zidane<rzidane@nvidia.com>

Moving Aman's ack from previous version:
Acked-by: Aman Singh <aman.deep.singh@intel.com>

Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied to dpdk-next-net/main, thanks.

      reply	other threads:[~2022-02-21 17:36 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-05  3:44 [PATCH] " Raja Zidane
2022-01-18  9:51 ` Ferruh Yigit
2022-01-18 11:27   ` Matan Azrad
2022-01-18 12:28     ` Ferruh Yigit
2022-01-18 12:55       ` Matan Azrad
2022-01-18 13:03         ` Ferruh Yigit
2022-01-18 13:19           ` Matan Azrad
2022-01-20 10:46             ` Singh, Aman Deep
2022-01-30 11:18               ` Raja Zidane
2022-01-31 16:47                 ` Singh, Aman Deep
2022-02-15 14:31                   ` Raja Zidane
2022-02-15 14:43                     ` Singh, Aman Deep
2022-02-16  2:02                     ` Xing, Beilei
2022-02-16 12:37 ` [PATCH V2] " Raja Zidane
2022-02-18  9:09   ` Singh, Aman Deep
2022-02-20 12:09   ` [PATCH V3] " Raja Zidane
2022-02-21 10:24     ` Singh, Aman Deep
2022-02-21 12:08     ` Ferruh Yigit
2022-02-21 13:24     ` [PATCH V4] " Raja Zidane
2022-02-21 17:36       ` Ferruh Yigit [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bf26f50e-0a33-9903-8497-459ee8df6e2a@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=dev@dpdk.org \
    --cc=matan@nvidia.com \
    --cc=rzidane@nvidia.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).